Skip to content

Development#1

Closed
mbuckton wants to merge 40 commits into
mainfrom
development
Closed

Development#1
mbuckton wants to merge 40 commits into
mainfrom
development

Conversation

@mbuckton

Copy link
Copy Markdown
Contributor

release merge

mbuckton and others added 30 commits January 4, 2026 10:27
MavLink allows truncated packets IF the framing is correct
Add the ability to validate V2 frames and to sign V2 frames
Introduce a new `loadDialect(Path dialectName)` method in `MavlinkMessageFormatLoader` to enable loading dialects directly from file paths, including custom include resolution with `FilePathIncludeResolver`. Updated `MavlinkEventFactory` to support dialects by path and added unit tests to verify functionality.
…L parsing logic

Refactored `CharFieldCodec` to handle `Number` types and ensure consistent value encoding. Updated `XmlParser` to properly decode hex values in the "value" attribute when present.
Added `MavlinkDialectLoadTest` to verify dialect loading from paths, message registry initialization, include chain resolution, and message validation.
…nd refactor test coverage

Removed `MavlinkFrameRoundTripAllMessagesTest` as its functionality is now consolidated into `MavlinkRoundTripAllMessagesTest` with enhanced dialect support. Refactored `RandomValueFactory` for improved random value generation and added dialect-specific handling of message round trips.
@coderabbitai

coderabbitai Bot commented Apr 28, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@mbuckton has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 54 minutes and 19 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a0515a68-c374-446c-9844-e5aef1380ff3

📥 Commits

Reviewing files that changed from the base of the PR and between e7b0aaf and 56352ab.

📒 Files selected for processing (136)
  • README.md
  • pom.xml
  • src/main/java/io/mapsmessaging/mavlink/MavlinkEventFactory.java
  • src/main/java/io/mapsmessaging/mavlink/MavlinkFrameEnvelope.java
  • src/main/java/io/mapsmessaging/mavlink/MavlinkMessageFormatLoader.java
  • src/main/java/io/mapsmessaging/mavlink/ProcessedFrame.java
  • src/main/java/io/mapsmessaging/mavlink/SystemContextManager.java
  • src/main/java/io/mapsmessaging/mavlink/codec/FrameEncoder.java
  • src/main/java/io/mapsmessaging/mavlink/codec/FrameFactory.java
  • src/main/java/io/mapsmessaging/mavlink/codec/JsonCodec.java
  • src/main/java/io/mapsmessaging/mavlink/codec/JsonValuesExtractor.java
  • src/main/java/io/mapsmessaging/mavlink/codec/MapConverter.java
  • src/main/java/io/mapsmessaging/mavlink/codec/MavlinkCodec.java
  • src/main/java/io/mapsmessaging/mavlink/codec/MavlinkFrameCodec.java
  • src/main/java/io/mapsmessaging/mavlink/codec/MavlinkFrameFactory.java
  • src/main/java/io/mapsmessaging/mavlink/codec/MavlinkMapConverter.java
  • src/main/java/io/mapsmessaging/mavlink/codec/MavlinkPayloadParser.java
  • src/main/java/io/mapsmessaging/mavlink/codec/PayloadPacker.java
  • src/main/java/io/mapsmessaging/mavlink/codec/PayloadParser.java
  • src/main/java/io/mapsmessaging/mavlink/context/Detection.java
  • src/main/java/io/mapsmessaging/mavlink/context/DetectionSeverity.java
  • src/main/java/io/mapsmessaging/mavlink/context/DetectionType.java
  • src/main/java/io/mapsmessaging/mavlink/context/FrameFailureReason.java
  • src/main/java/io/mapsmessaging/mavlink/context/FrameFingerprint.java
  • src/main/java/io/mapsmessaging/mavlink/context/SequenceProcessingResult.java
  • src/main/java/io/mapsmessaging/mavlink/context/SequenceProcessor.java
  • src/main/java/io/mapsmessaging/mavlink/context/SequenceProcessorConfig.java
  • src/main/java/io/mapsmessaging/mavlink/context/SequenceRingBuffer256.java
  • src/main/java/io/mapsmessaging/mavlink/context/SequenceRingEntry.java
  • src/main/java/io/mapsmessaging/mavlink/context/SequenceStats.java
  • src/main/java/io/mapsmessaging/mavlink/context/SourceStats.java
  • src/main/java/io/mapsmessaging/mavlink/context/SweepConfig.java
  • src/main/java/io/mapsmessaging/mavlink/context/SweepResult.java
  • src/main/java/io/mapsmessaging/mavlink/context/SystemContext.java
  • src/main/java/io/mapsmessaging/mavlink/context/SystemContextSnapshot.java
  • src/main/java/io/mapsmessaging/mavlink/framing/ByteBufferUtils.java
  • src/main/java/io/mapsmessaging/mavlink/framing/CrcHelper.java
  • src/main/java/io/mapsmessaging/mavlink/framing/DialectRegistry.java
  • src/main/java/io/mapsmessaging/mavlink/framing/FrameDecoder.java
  • src/main/java/io/mapsmessaging/mavlink/framing/FrameFramer.java
  • src/main/java/io/mapsmessaging/mavlink/framing/FrameHandler.java
  • src/main/java/io/mapsmessaging/mavlink/framing/FramePacker.java
  • src/main/java/io/mapsmessaging/mavlink/framing/MavlinkDialectRegistry.java
  • src/main/java/io/mapsmessaging/mavlink/framing/MavlinkFrameDecoder.java
  • src/main/java/io/mapsmessaging/mavlink/framing/MavlinkFrameHandler.java
  • src/main/java/io/mapsmessaging/mavlink/framing/MavlinkV2FrameHandler.java
  • src/main/java/io/mapsmessaging/mavlink/framing/SigningKeyProvider.java
  • src/main/java/io/mapsmessaging/mavlink/framing/V1FrameHandler.java
  • src/main/java/io/mapsmessaging/mavlink/framing/V2FrameHandler.java
  • src/main/java/io/mapsmessaging/mavlink/framing/V2FrameSigning.java
  • src/main/java/io/mapsmessaging/mavlink/framing/V2SignatureGenerator.java
  • src/main/java/io/mapsmessaging/mavlink/message/CompiledField.java
  • src/main/java/io/mapsmessaging/mavlink/message/CompiledMessage.java
  • src/main/java/io/mapsmessaging/mavlink/message/EnumResolver.java
  • src/main/java/io/mapsmessaging/mavlink/message/Frame.java
  • src/main/java/io/mapsmessaging/mavlink/message/FrameParser.java
  • src/main/java/io/mapsmessaging/mavlink/message/MavlinkCompiledField.java
  • src/main/java/io/mapsmessaging/mavlink/message/MavlinkCompiledMessage.java
  • src/main/java/io/mapsmessaging/mavlink/message/MavlinkFrame.java
  • src/main/java/io/mapsmessaging/mavlink/message/MavlinkMessageRegistry.java
  • src/main/java/io/mapsmessaging/mavlink/message/MavlinkVersion.java
  • src/main/java/io/mapsmessaging/mavlink/message/MessageDefinition.java
  • src/main/java/io/mapsmessaging/mavlink/message/MessageRegistry.java
  • src/main/java/io/mapsmessaging/mavlink/message/Version.java
  • src/main/java/io/mapsmessaging/mavlink/message/X25Crc.java
  • src/main/java/io/mapsmessaging/mavlink/message/fields/AbstractMavlinkFieldCodec.java
  • src/main/java/io/mapsmessaging/mavlink/message/fields/ArrayFieldCodec.java
  • src/main/java/io/mapsmessaging/mavlink/message/fields/CharFieldCodec.java
  • src/main/java/io/mapsmessaging/mavlink/message/fields/DoubleFieldCodec.java
  • src/main/java/io/mapsmessaging/mavlink/message/fields/EnumDefinition.java
  • src/main/java/io/mapsmessaging/mavlink/message/fields/EnumEntry.java
  • src/main/java/io/mapsmessaging/mavlink/message/fields/FieldCodecFactory.java
  • src/main/java/io/mapsmessaging/mavlink/message/fields/FieldDefinition.java
  • src/main/java/io/mapsmessaging/mavlink/message/fields/FloatFieldCodec.java
  • src/main/java/io/mapsmessaging/mavlink/message/fields/Int16FieldCodec.java
  • src/main/java/io/mapsmessaging/mavlink/message/fields/Int32FieldCodec.java
  • src/main/java/io/mapsmessaging/mavlink/message/fields/Int64FieldCodec.java
  • src/main/java/io/mapsmessaging/mavlink/message/fields/Int8FieldCodec.java
  • src/main/java/io/mapsmessaging/mavlink/message/fields/MavlinkEnumEntry.java
  • src/main/java/io/mapsmessaging/mavlink/message/fields/UInt16FieldCodec.java
  • src/main/java/io/mapsmessaging/mavlink/message/fields/UInt32FieldCodec.java
  • src/main/java/io/mapsmessaging/mavlink/message/fields/UInt64FieldCodec.java
  • src/main/java/io/mapsmessaging/mavlink/message/fields/UInt8FieldCodec.java
  • src/main/java/io/mapsmessaging/mavlink/message/fields/WireType.java
  • src/main/java/io/mapsmessaging/mavlink/parser/ClasspathIncludeResolver.java
  • src/main/java/io/mapsmessaging/mavlink/parser/ClasspathMavlinkIncludeResolver.java
  • src/main/java/io/mapsmessaging/mavlink/parser/DialectDefinition.java
  • src/main/java/io/mapsmessaging/mavlink/parser/DialectLoader.java
  • src/main/java/io/mapsmessaging/mavlink/parser/ExtraCrcCalculator.java
  • src/main/java/io/mapsmessaging/mavlink/parser/FilePathIncludeResolver.java
  • src/main/java/io/mapsmessaging/mavlink/parser/IncludeResolver.java
  • src/main/java/io/mapsmessaging/mavlink/parser/MavlinkDialectDefinition.java
  • src/main/java/io/mapsmessaging/mavlink/parser/MavlinkIncludeResolver.java
  • src/main/java/io/mapsmessaging/mavlink/parser/XmlParser.java
  • src/main/java/io/mapsmessaging/mavlink/schema/JsonSchemaBuilder.java
  • src/main/java/io/mapsmessaging/mavlink/signing/MapSigningKeyProvider.java
  • src/main/java/io/mapsmessaging/mavlink/signing/NoSigningKeyProvider.java
  • src/main/java/io/mapsmessaging/mavlink/signing/StaticSigningKeyProvider.java
  • src/main/resources/mavlink/ardupilot/ASLUAV.xml
  • src/main/resources/mavlink/ardupilot/AVSSUAS.xml
  • src/main/resources/mavlink/ardupilot/all.xml
  • src/main/resources/mavlink/ardupilot/ardupilotmega.xml
  • src/main/resources/mavlink/ardupilot/common.xml
  • src/main/resources/mavlink/ardupilot/csAirLink.xml
  • src/main/resources/mavlink/ardupilot/cubepilot.xml
  • src/main/resources/mavlink/ardupilot/development.xml
  • src/main/resources/mavlink/ardupilot/icarous.xml
  • src/main/resources/mavlink/ardupilot/loweheiser.xml
  • src/main/resources/mavlink/ardupilot/matrixpilot.xml
  • src/main/resources/mavlink/ardupilot/minimal.xml
  • src/main/resources/mavlink/ardupilot/paparazzi.xml
  • src/main/resources/mavlink/ardupilot/python_array_test.xml
  • src/main/resources/mavlink/ardupilot/standard.xml
  • src/main/resources/mavlink/ardupilot/storm32.xml
  • src/main/resources/mavlink/ardupilot/test.xml
  • src/main/resources/mavlink/ardupilot/uAvionix.xml
  • src/main/resources/mavlink/ardupilot/ualberta.xml
  • src/test/java/io/mapsmessaging/mavlink/BaseRoudTripTest.java
  • src/test/java/io/mapsmessaging/mavlink/HeartbeatTest.java
  • src/test/java/io/mapsmessaging/mavlink/MavlinkDialectLoadTest.java
  • src/test/java/io/mapsmessaging/mavlink/MavlinkEventFactoryTest.java
  • src/test/java/io/mapsmessaging/mavlink/MavlinkFrameRoundTripAllMessagesTest.java
  • src/test/java/io/mapsmessaging/mavlink/MavlinkMessageFormatLoaderPathTest.java
  • src/test/java/io/mapsmessaging/mavlink/MavlinkPayloadJsonSchemaValidationTest.java
  • src/test/java/io/mapsmessaging/mavlink/MavlinkRoundTripAllMessagesTest.java
  • src/test/java/io/mapsmessaging/mavlink/MavlinkTestSupport.java
  • src/test/java/io/mapsmessaging/mavlink/RandomValueFactory.java
  • src/test/java/io/mapsmessaging/mavlink/SystemContextManagerTest.java
  • src/test/java/io/mapsmessaging/mavlink/TestMavlinkCharArrays.java
  • src/test/java/io/mapsmessaging/mavlink/TestMavlinkConcurrency.java
  • src/test/java/io/mapsmessaging/mavlink/TestMavlinkExtensions.java
  • src/test/java/io/mapsmessaging/mavlink/TestMavlinkNumericArrays.java
  • src/test/java/io/mapsmessaging/mavlink/TestMavlinkRegistryInvariants.java
  • src/test/java/io/mapsmessaging/mavlink/TestMavlinkRobustness.java
  • src/test/java/io/mapsmessaging/mavlink/TestMavlinkXmlParserIncludes.java
  • src/test/java/io/mapsmessaging/mavlink/X25CrcTest.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch development

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

dependabot Bot and others added 10 commits May 19, 2026 04:31
Bumps [org.apache.maven.plugins:maven-source-plugin](https://github.com/apache/maven-source-plugin) from 3.3.1 to 3.4.0.
- [Release notes](https://github.com/apache/maven-source-plugin/releases)
- [Commits](apache/maven-source-plugin@maven-source-plugin-3.3.1...maven-source-plugin-3.4.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-source-plugin
  dependency-version: 3.4.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.5.4 to 3.5.5.
- [Release notes](https://github.com/apache/maven-surefire/releases)
- [Commits](apache/maven-surefire@surefire-3.5.4...surefire-3.5.5)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-surefire-plugin
  dependency-version: 3.5.5
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps io.swagger.core.v3:swagger-annotations from 2.2.41 to 2.2.50.

---
updated-dependencies:
- dependency-name: io.swagger.core.v3:swagger-annotations
  dependency-version: 2.2.50
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.mockito:mockito-junit-jupiter](https://github.com/mockito/mockito) from 5.21.0 to 5.23.0.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](mockito/mockito@v5.21.0...v5.23.0)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-junit-jupiter
  dependency-version: 5.23.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito) from 5.21.0 to 5.23.0.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](mockito/mockito@v5.21.0...v5.23.0)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-core
  dependency-version: 5.23.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…t/org.mockito-mockito-core-5.23.0

Bump org.mockito:mockito-core from 5.21.0 to 5.23.0
…t/org.mockito-mockito-junit-jupiter-5.23.0

Bump org.mockito:mockito-junit-jupiter from 5.21.0 to 5.23.0
…t/io.swagger.core.v3-swagger-annotations-2.2.50

Bump io.swagger.core.v3:swagger-annotations from 2.2.41 to 2.2.50
…t/org.apache.maven.plugins-maven-surefire-plugin-3.5.5

Bump org.apache.maven.plugins:maven-surefire-plugin from 3.5.4 to 3.5.5
…t/org.apache.maven.plugins-maven-source-plugin-3.4.0

Bump org.apache.maven.plugins:maven-source-plugin from 3.3.1 to 3.4.0
@mbuckton mbuckton closed this May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant