chore: Merge pull request #887 from DocSvartz/restore-v7.4.0-behavior-for-Property-without-setter

Fix: Restore v7.4.0 behavior for property without setter in class

Author: DocSvartz

src/Mapster.Tests/WhenUsingDestinationValue.cs

@@ -42,16 +42,35 @@ public void MapUsingDestinationValue()
         public void MappingToReadonlyPropertyWhenPocoDetectRegression()
         {
             var studentDto = new StudentDtoOrigin { Name = "Marta" };
-            var student = studentDto.Adapt<StudentOrigin>();  // No exception.
 
-            student.Name.ShouldBe("John");
+            Should.NotThrow(() =>
+            {
+                var student = studentDto.Adapt<StudentOrigin>();  // No exception.
+            });
         }
 
+        [TestMethod]
+        public void MappingToReadonlyAutoPropertyPrimitiveOrImmutableType()
+        {
+            var studentDto = new StudentDtoOrigin { Name = "Marta" };
+            var UseDestinationValue = studentDto.Adapt<StudentOrigin>();
+            var NotUseDestinationValue = studentDto.Adapt<StudentOriginNoUseDestinationValue>();
+
+            UseDestinationValue.Name.ShouldBe(studentDto.Name);
+            NotUseDestinationValue.Name.ShouldBe("John"); // not modified Name == "John" - origin value
+        }
+
+        #region TestClasses
+
+        public class StudentOriginNoUseDestinationValue
+        {
+            public string Name { get; } = "John"; // readonly primitive type autoproperty
+        }
 
         public class StudentOrigin
         {
             [UseDestinationValue]
-            public string Name { get; } = "John"; // only readonly
+            public string Name { get; } = "John"; // readonly primitive type autoproperty
         }
 
         public class StudentDtoOrigin
@@ -93,5 +112,7 @@ public class InvoiceDto
             public IEnumerable<int> Numbers { get; set; }
             public ICollection<string> Strings { get; set; }
         }
+
+        #endregion TestClasses
     }
 }

src/Mapster/Adapters/ClassAdapter.cs

@@ -115,9 +115,11 @@ protected override Expression CreateBlockExpression(Expression source, Expressio
 
                 var adapt = CreateAdaptExpression(member.Getter, member.DestinationMember.Type, arg, member, destMember);
 
-                if (!member.UseDestinationValue && member.DestinationMember.SetterModifier == AccessModifier.None)
+                if (member.UseDestinationValue
+                    && member.DestinationMember.Type.IsMapsterImmutable()
+                    && member.DestinationMember.SetterModifier == AccessModifier.None)
                 {
-                    if (member.DestinationMember is PropertyModel && arg.MapType == MapType.MapToTarget)
+                    if (member.DestinationMember is PropertyModel && arg.MapType != MapType.Projection)
                         adapt = SetValueTypeAutoPropertyByReflection(member, adapt, classModel);
                     else
                         continue;

src/Mapster/Utils/ReflectionUtils.cs

@@ -448,5 +448,10 @@ public static bool isDefaultCtor(this Type type)
         {
           return  type.GetConstructor(new Type[] { }) is not null ? true : false;
         }
+
+        public static bool IsMapsterImmutable(this Type type)
+        {
+            return type.IsMapsterPrimitive() || type.IsRecordType();
+        }
     }
 }