Review Common Engine Methods and remove outdated

[MarcosMeli]

There are a lot of methods in the CommonEngine from old days in .net so we can safetly remove some of them like: SortRecordsByField
Now you can use sort with lamba

[rmegal]

There are methods marked with [Obsolete] but SortRecordsByField isn't one of them.

Do you have a list of the obsolete methods you want removed for 4.0?

[MarcosMeli]

@rmegal You are right, so we must to add an Obsolete mark there 👍

If you want we can add an Analyzer rule to rewrite the SortRecordsByField with a lambda expression.

Wanna add the obsole and help me with the Analyzer ?

Thanks !!

[rmegal]

OK. I haven't written a Roslyn Analyzer before so I'm working through this: https://msdn.microsoft.com/en-us/magazine/dn879356.aspx Very interesting.

So the idea is:

1. Mark the existing method Obsolete
2. Write a custom analyzer that identifies the obsolete calls to the existing method and provides a CodeAction with the suggested fix?

Is this what you want to do?

[MarcosMeli]

@rmegal exactly !!!

The Analyzer is already implemented

http://www.filehelpers.net/analyzer/

Code is in the FileHelpers.Analyzer folder, open the sln from there

You can copy the initial implementation from any of the the current Analyzer and code fixes and change inside the values.

After that I recomend that you create a console aplication that uses FileHelpers and installe the Syntax Visualizer Window so you can see the Roslyn structure of the code to change.

After that you can start playing, any question you can enter gitter chat:

https://gitter.im/MarcosMeli/FileHelpers

PS: A great Roslyn tutorial https://joshvarty.wordpress.com/learn-roslyn-now/
Thanks !!