rpm install/upgrade - remove xargs

echo $v | sudo xargs ..

is a antipattern, just use bash arrays.

Author: grooverdan

scripts/rpm-install.sh

@@ -44,17 +44,13 @@ rpm_setup_bb_artifacts_mirror
 rpm_pkg_makecache
 
 # install all packages
-pkg_list=$(rpm_repoquery) ||
-  bb_log_err "Unable to retrieve package list from repository"
+read -ra package_array = <<< "$(rpm_repoquery)"
 
-# ID_LIKE may not exist
-set +u
-if [[ $ID_LIKE =~ ^suse* ]]; then
-  echo "$pkg_list" | xargs sudo "$pkg_cmd" -n install
-else
-  echo "$pkg_list" | xargs sudo "$pkg_cmd" -y install
+if [ ${#package_array[@]} -eq 0 ]; then
+  bb_log_err "Unable to retrieve package list from repository"
 fi
-set -u
+
+sudo "$pkg_cmd" -n install "${package_array[@]}"
 
 sh -c 'g=/usr/lib*/galera*/libgalera_smm.so; echo -e "[galera]\nwsrep_provider=$g"' | sudo tee /etc/my.cnf.d/galera.cnf
 

scripts/rpm-upgrade.sh

@@ -139,10 +139,13 @@ set -u
 # Any of the below steps could fail
 trap save_failure_logs ERR
 
+read -ra package_array <<< "$package_list"
+
 # Install previous release
-echo "$package_list" | xargs sudo "$pkg_cmd" "$pkg_cmd_options" install ||
+if sudo "$pkg_cmd" "$pkg_cmd_options" install "${package_array[@]}"; then
   bb_log_err "installation of a previous release failed, see the output above"
-#fi
+  save_failure_logs
+fi
 
 # Start the server, check that it is working and create some structures
 #
@@ -174,19 +177,19 @@ fi
 # //TEMP upgrade does not work without this but why? Can't we fix it?
 if [[ $test_type == "major" ]]; then
   bb_log_info "remove old packages for major upgrade"
-  packages_to_remove=$(rpm -qa | grep 'MariaDB-' | awk -F'-' '{print $1"-"$2}')
-  echo "$packages_to_remove" | xargs sudo "$pkg_cmd" "$pkg_cmd_options" remove
+  readarray -t package_array <<< "$(rpm -qa | grep 'MariaDB-' | awk -F'-' '{print $1"-"$2}')"
+  sudo "$pkg_cmd" "$pkg_cmd_options" remove "${package_array[@]}"
   rpm -qa | grep -iE 'maria|mysql' || true
 fi
 
 rpm_setup_bb_galera_artifacts_mirror
 rpm_setup_bb_artifacts_mirror
 if [[ $test_type == "major" ]]; then
   # major upgrade (remove then install)
-  echo "$package_list" | xargs sudo "$pkg_cmd" "$pkg_cmd_options" install
+  sudo "$pkg_cmd" "$pkg_cmd_options" install "${package_array[@]}"
 else
   # minor upgrade (upgrade works)
-  echo "$package_list" | xargs sudo "$pkg_cmd" "$pkg_cmd_options" "$pkg_cmd_upgrade"
+  sudo "$pkg_cmd" "$pkg_cmd_options" "$pkg_cmd_upgrade" "${package_array[@]}"
 fi
 # set +e