Skip to content

MDBF-1201: add --view tests to branch protection#980

Open
RazvanLiviuVarzaru wants to merge 1 commit into
MariaDB:devfrom
RazvanLiviuVarzaru:MDBF-1201
Open

MDBF-1201: add --view tests to branch protection#980
RazvanLiviuVarzaru wants to merge 1 commit into
MariaDB:devfrom
RazvanLiviuVarzaru:MDBF-1201

Conversation

@RazvanLiviuVarzaru

@RazvanLiviuVarzaru RazvanLiviuVarzaru commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Only known green mtr tests under --view-protocol, i.e. --suite=main.
MDEV-40142 should be fixed before adding deploying the changes to a protected branches builder.

@fauust fauust left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good!

Comment thread master-protected-branches/master.cfg Outdated
@grooverdan

Copy link
Copy Markdown
Member

Curious on the rational of a new builder for this. Is a ~2 min build for a ~2 min test.

Having a separate builder is allowing for a branch protection to run across multiple machines as fast as the slowest builder, which seems to be amd64-ubuntu-2204-debug / amd64-ubuntu-2204-debug.

Could the view protocol test be appended to an existing amd64-debian-11-debug-ps-embedded or amd64-debian-12-debug-embedded? I notice (sampled rather than full analysis) the longer runs on these seem to be the compile step, or than the mtr step so its a sunken cost.

The basis of a reduction is a shorter, more visible (on GH) list of protected branch builders, and a small amount of overhead reduction as by all accounts resources are a bit precious.

@RazvanLiviuVarzaru

Copy link
Copy Markdown
Collaborator Author

Curious on the rational of a new builder for this. Is a ~2 min build for a ~2 min test.

Having a separate builder is allowing for a branch protection to run across multiple machines as fast as the slowest builder, which seems to be amd64-ubuntu-2204-debug / amd64-ubuntu-2204-debug.

Could the view protocol test be appended to an existing amd64-debian-11-debug-ps-embedded or amd64-debian-12-debug-embedded? I notice (sampled rather than full analysis) the longer runs on these seem to be the compile step, or than the mtr step so its a sunken cost.

The basis of a reduction is a shorter, more visible (on GH) list of protected branch builders, and a small amount of overhead reduction as by all accounts resources are a bit precious.

Hi @grooverdan !
My angle was having a status but non-protected builder while the outstanding failures are sorted out, particularly MDEV-40142, but in the long-term your statement makes a lot more sense for the good of CI resources consumption.
I will go with your solution and this PR will have to wait for MDEV-40142 to be closed before deploying the patch.

Only known green mtr tests under --view-protocol, i.e. --suite=main.
MDEV-40142 should be fixed before adding deploying the changes to a protected branches builder.
@RazvanLiviuVarzaru

Copy link
Copy Markdown
Collaborator Author

Forced push 36de8d9
requested your review @grooverdan , thanks again for the feedback.

@grooverdan grooverdan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Myself or Yuchen will hopefully get to MDEV-40142 soonish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants