MDEV-39541 mem_pressure::~mem_pressure() causes a crash on bootstrap

Fill in the anomaly shutdown paths of InnoDB to include call to
buf_mem_pressure_shutdown now that MDEV-39585 provides some
proper calls shutdown InnoDB and other plugins during the shutdown
under --bootstrap.

Alternate: destructor attribute on buf_mem_pressure_shutdown would
acheive the same thing and given Linux compilers are capabile of
this. This is possible as mem_pressure is currently implemented
in Linux onny.

Author: grooverdan

mysql-test/main/bootstrap_innodb.result

@@ -1,8 +1,12 @@
 create table t1(a int) engine=innodb;
+#
+# MDEV-39541 mem_pressure::~mem_pressure() causes a crash on bootstrap
+#
 # restart
 select * from t1;
 a
 1
 2
 5
 drop table t1;
+# End of 10.11 tests

mysql-test/main/bootstrap_innodb.test

@@ -22,6 +22,18 @@ EOF
 exec $MYSQLD_BOOTSTRAP_CMD --datadir=$datadir --tmpdir=$MYSQL_TMP_DIR --innodb < $MYSQLTEST_VARDIR/tmp/bootstrap_test.sql >> $MYSQLTEST_VARDIR/tmp/bootstrap.log 2>&1;
 remove_file $MYSQLTEST_VARDIR/tmp/bootstrap_test.sql;
 
+--echo #
+--echo # MDEV-39541 mem_pressure::~mem_pressure() causes a crash on bootstrap
+--echo #
+
+write_file $MYSQLTEST_VARDIR/tmp/bootstrap_test.sql;
+SHUTDOWN;
+EOF
+exec $MYSQLD_BOOTSTRAP_CMD --datadir=$datadir --tmpdir=$MYSQL_TMP_DIR --innodb < $MYSQLTEST_VARDIR/tmp/bootstrap_test.sql >> $MYSQLTEST_VARDIR/tmp/bootstrap.log 2>&1;
+remove_file $MYSQLTEST_VARDIR/tmp/bootstrap_test.sql;
+
 source include/start_mysqld.inc;
 select * from t1;
 drop table t1;
+
+--echo # End of 10.11 tests

storage/innobase/handler/ha_innodb.cc

@@ -4379,6 +4379,8 @@ innobase_end(handlerton*, ha_panic_function)
 		innodb_shutdown();
 		mysql_mutex_destroy(&log_requests.mutex);
 	}
+	else
+		buf_mem_pressure_shutdown();
 
 	DBUG_RETURN(0);
 }

storage/innobase/include/srv0start.h

@@ -52,6 +52,12 @@ void innodb_preshutdown();
 /** Shut down InnoDB. */
 void innodb_shutdown();
 
+/** Stop mem presure thread and free file descriptors */
+#ifdef __linux__
+void buf_mem_pressure_shutdown() noexcept;
+#else
+inline void buf_mem_pressure_shutdown() noexcept {}
+#endif
 /*************************************************************//**
 Copy the file path component of the physical file to parameter. It will
 copy up to and including the terminating path separator.

storage/innobase/log/log0log.cc

@@ -2120,12 +2120,6 @@ void log_free_check() noexcept
     log_sys.checkpoint_margin();
 }
 
-#ifdef __linux__
-extern void buf_mem_pressure_shutdown() noexcept;
-#else
-inline void buf_mem_pressure_shutdown() noexcept {}
-#endif
-
 /** Make a checkpoint at the latest lsn on shutdown.
 @return the shutdown LSN */
 ATTRIBUTE_COLD lsn_t logs_empty_and_mark_files_at_shutdown() noexcept