Commit c3f9ddf
committed
MDEV-28374 UBSAN signed integer overflow PROCEDURE ANALYSE (fix)
The test cases added in [1] had a > 64 character recommendation
for Optimal_fieldtype. This was the limit on output of the field.
Under cursor mode the limit was enforced truncating the output.
Raised to a 1024 character limits as a fix for the MDEV-28374
tests, which exceeds the amount needed for for the utility of
users.
Note currently the output_str_length used in analyse::change_columns
is not currently set (so is 0) until analyse::end_of_records
is called, which is later. Consequently output_str_length is 0
and the 1024 raised maximium is used. MDEV-39586 has been raised
to correct this.
[1] 6eda0af1 parent da950e1 commit c3f9ddf
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1196 | 1196 | | |
1197 | 1197 | | |
1198 | 1198 | | |
| 1199 | + | |
| 1200 | + | |
| 1201 | + | |
| 1202 | + | |
1199 | 1203 | | |
1200 | | - | |
| 1204 | + | |
1201 | 1205 | | |
1202 | 1206 | | |
1203 | 1207 | | |
| |||
0 commit comments