MDEV-39196: SELECT from information schema fails when FederatedX loses underlying table

When a remote table is unavailable, FederatedX was passing a hard error back to the SQL layer, causing INFORMATION_SCHEMA queries to abort entirely.

This patch intercepts the remote error in ha_federatedx::info, downgrades it to a warning using push_warning_printf, and includes the local table name in the warning message so the user knows which table is inaccessible.

Signed-off-by: Anway Durge <124391429+itzanway@users.noreply.github.com>

Author: itzanway

mysql-test/suite/federated/federated.test

@@ -17,7 +17,7 @@ create table t1 (a int);
 --replace_result $MASTER_MYPORT MASTER_PORT
 eval create table fed (a int) engine=Federated CONNECTION='mysql://root@127.0.0.1:$MASTER_MYPORT/test/t1';
 drop table t1;
---error 1146,1431
+--error ER_NO_SUCH_TABLE,ER_FOREIGN_DATA_SOURCE_DOESNT_EXIST
 select * from fed;
 drop table fed;
 

mysql-test/suite/federated/federatedx_mdev39196.result

@@ -0,0 +1,39 @@
+#
+# MDEV-39196: INFORMATION_SCHEMA query must succeed with a
+# warning when a FederatedX remote table is unreachable.
+#
+CREATE DATABASE IF NOT EXISTS test_remote;
+CREATE TABLE test_remote.t1_backing (
+  id INT NOT NULL,
+  name VARCHAR(64)
+) ENGINE=MyISAM;
+INSERT INTO test_remote.t1_backing VALUES (1, 'foo');
+CREATE DATABASE IF NOT EXISTS federated;
+CREATE TABLE federated.t1 (
+  id INT NOT NULL,
+  name VARCHAR(64)
+) ENGINE=FEDERATED
+CONNECTION='mysql://root@127.0.0.1:MASTER_PORT/test_remote/t1_backing';
+# Verify the federated table works before dropping remote table.
+SELECT * FROM federated.t1;
+id	name
+1	foo
+# Drop the remote table to simulate unreachable/missing table.
+DROP TABLE test_remote.t1_backing;
+# INFORMATION_SCHEMA query must succeed and issue a warning.
+SELECT TABLE_NAME, TABLE_ROWS
+FROM information_schema.TABLES
+WHERE TABLE_SCHEMA = 'federated'
+  AND TABLE_NAME = 't1';
+TABLE_NAME	TABLE_ROWS
+t1	NULL
+Warnings:
+Warning	1430	FederatedX: Table 't1' is inaccessible: 1146 : Remote table does not exist
+# Warning must be present.
+SHOW WARNINGS;
+Level	Code	Message
+Warning	1430	FederatedX: Table 't1' is inaccessible: 1146 : Remote table does not exist
+# Cleanup.
+DROP TABLE IF EXISTS federated.t1;
+DROP DATABASE IF EXISTS federated;
+DROP DATABASE IF EXISTS test_remote;

mysql-test/suite/federated/federatedx_mdev39196.test

@@ -0,0 +1,43 @@
+--source include/not_embedded.inc
+--source include/have_federatedx.inc
+
+--echo #
+--echo # MDEV-39196: INFORMATION_SCHEMA query must succeed with a
+--echo # warning when a FederatedX remote table is unreachable.
+--echo #
+
+CREATE DATABASE IF NOT EXISTS test_remote;
+CREATE TABLE test_remote.t1_backing (
+  id INT NOT NULL,
+  name VARCHAR(64)
+) ENGINE=MyISAM;
+
+INSERT INTO test_remote.t1_backing VALUES (1, 'foo');
+
+CREATE DATABASE IF NOT EXISTS federated;
+--replace_result $MASTER_MYPORT MASTER_PORT
+eval CREATE TABLE federated.t1 (
+  id INT NOT NULL,
+  name VARCHAR(64)
+) ENGINE=FEDERATED
+CONNECTION='mysql://root@127.0.0.1:$MASTER_MYPORT/test_remote/t1_backing';
+
+--echo # Verify the federated table works before dropping remote table.
+SELECT * FROM federated.t1;
+
+--echo # Drop the remote table to simulate unreachable/missing table.
+DROP TABLE test_remote.t1_backing;
+
+--echo # INFORMATION_SCHEMA query must succeed and issue a warning.
+SELECT TABLE_NAME, TABLE_ROWS
+FROM information_schema.TABLES
+WHERE TABLE_SCHEMA = 'federated'
+  AND TABLE_NAME = 't1';
+
+--echo # Warning must be present.
+SHOW WARNINGS;
+
+--echo # Cleanup.
+DROP TABLE IF EXISTS federated.t1;
+DROP DATABASE IF EXISTS federated;
+DROP DATABASE IF EXISTS test_remote;

storage/federatedx/federatedx_io_mysql.cc

@@ -68,6 +68,8 @@ class federatedx_io_mysql :public federatedx_io
   DYNAMIC_ARRAY savepoints;
   bool requested_autocommit;
   bool actual_autocommit;
+  int stored_error_code;
+  char stored_error_msg[MYSQL_ERRMSG_SIZE];
 
   int actual_query(const char *buffer, size_t length);
   bool test_all_restrict() const;
@@ -134,12 +136,14 @@ federatedx_io *instantiate_io_mysql(MEM_ROOT *server_root,
 
 federatedx_io_mysql::federatedx_io_mysql(FEDERATEDX_SERVER *aserver)
   : federatedx_io(aserver),
-    requested_autocommit(TRUE), actual_autocommit(TRUE)
+    requested_autocommit(TRUE), actual_autocommit(TRUE),
+    stored_error_code(0)
 {
   DBUG_ENTER("federatedx_io_mysql::federatedx_io_mysql");
 
   bzero(&mysql, sizeof(MYSQL));
   bzero(&savepoints, sizeof(DYNAMIC_ARRAY));
+  bzero(stored_error_msg, sizeof(stored_error_msg));
 
   my_init_dynamic_array(PSI_INSTRUMENT_ME, &savepoints, sizeof(SAVEPT), 16, 16, MYF(0));
 
@@ -483,12 +487,16 @@ my_ulonglong federatedx_io_mysql::last_insert_id() const
 
 int federatedx_io_mysql::error_code()
 {
+  if (stored_error_code)
+    return stored_error_code;
   return mysql_errno(&mysql);
 }
 
 
 const char *federatedx_io_mysql::error_str()
 {
+  if (stored_error_code)
+    return stored_error_msg;
   return mysql_error(&mysql);
 }
 
@@ -583,7 +591,11 @@ bool federatedx_io_mysql::table_metadata(ha_statistics *stats,
     goto error;
 
   if (!(row= fetch_row(result)))
+  {
+    stored_error_code= 0;
+    bzero(stored_error_msg, sizeof(stored_error_msg));
     goto error;
+  }
 
   /*
     deleted is set in ha_federatedx::info
@@ -618,8 +630,13 @@ bool federatedx_io_mysql::table_metadata(ha_statistics *stats,
 error:
   if (!mysql_errno(&mysql))
   {
-    mysql.net.last_errno= ER_NO_SUCH_TABLE;
-    strmake_buf(mysql.net.last_error, "Remote table does not exist");
+    stored_error_code= ER_NO_SUCH_TABLE;
+    strmake_buf(stored_error_msg, "Remote table does not exist");
+  }
+  else
+  {
+    stored_error_code= mysql_errno(&mysql);
+    strmake_buf(stored_error_msg, mysql_error(&mysql));
   }
   free_result(result);
   return 1;

storage/federatedx/ha_federatedx.cc

@@ -3091,47 +3091,65 @@ int ha_federatedx::info(uint flag)
   DBUG_ENTER("ha_federatedx::info");
 
   error_code= ER_QUERY_ON_FOREIGN_DATA_SOURCE;
-  
+
   // external_lock may not have been called so txn may not be set
   tmp_txn= get_txn(thd);
 
   /* we want not to show table status if not needed to do so */
   if (flag & (HA_STATUS_VARIABLE | HA_STATUS_CONST | HA_STATUS_AUTO))
   {
-    if (!*(iop= &io) && (error_code= tmp_txn->acquire(share, thd, TRUE, (iop= &tmp_io))))
+    if (!*(iop= &io) && (error_code= tmp_txn->acquire(share, thd, TRUE,
+                                                       (iop= &tmp_io))))
       goto fail;
   }
 
   if (flag & (HA_STATUS_VARIABLE | HA_STATUS_CONST))
   {
-    /*
-      size of IO operations (This is based on a good guess, no high science
-      involved)
-    */
     if (flag & HA_STATUS_CONST)
       stats.block_size= 4096;
 
     if ((*iop)->table_metadata(&stats, share->table_name,
                                (uint)share->table_name_length, flag))
+    {
+      error_code= (uint)(*iop)->error_code();  /* capture NOW before it clears */
       goto error;
+    }
   }
 
   if (flag & HA_STATUS_AUTO)
     stats.auto_increment_value= (*iop)->last_insert_id();
 
-  /*
-    If ::info created it's own transaction, close it. This happens in case
-    of show table status;
-  */
   tmp_txn->release(&tmp_io);
-
   DBUG_RETURN(0);
 
 error:
   if (iop && *iop)
   {
-    my_printf_error((*iop)->error_code(), "Received error: %d : %s", MYF(0),
-                    (*iop)->error_code(), (*iop)->error_str());
+    uint remote_err= error_code;  /* already captured before goto */
+    if ((flag & HA_STATUS_VARIABLE) &&
+        (remote_err == 1146 ||   /* ER_NO_SUCH_TABLE */
+         remote_err == 2002 ||   /* CR_CONNECTION_ERROR */
+         remote_err == 2003 ||   /* CR_CONN_HOST_ERROR */
+         remote_err == 2005 ||   /* CR_UNKNOWN_HOST */
+         remote_err == 2006 ||   /* CR_SERVER_GONE_ERROR */
+         remote_err == 2013))    /* CR_SERVER_LOST */
+    {
+      push_warning_printf(thd, Sql_condition::WARN_LEVEL_WARN,
+                          ER_QUERY_ON_FOREIGN_DATA_SOURCE,
+                          "FederatedX: Table '%s' is inaccessible: "
+                          "%d : %s",
+                          share->table_name,
+                          remote_err,
+                          (*iop)->error_str());
+      error_code= 0;
+    }
+    else
+    {
+      my_printf_error(remote_err,
+                      "Received error: %d : %s", MYF(0),
+                      remote_err, (*iop)->error_str());
+      error_code= remote_err;
+    }
   }
   else if (remote_error_number != -1 /* error already reported */)
   {