MDEV-39561 : Galera test failure on mysql-wsrep-features#8#5062
MDEV-39561 : Galera test failure on mysql-wsrep-features#8#5062janlindstrom wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request updates the mysql-wsrep-features#8.test file to replace standard wait conditions with a debug-enabled version that captures specific diagnostic information on failure. Feedback suggests applying this change consistently across the file and replacing SELECT * with SELECT COUNT(*) in debug outputs to avoid excessive logging when tables contain many rows.
| --connection node_2 | ||
| --let $wait_condition = SELECT COUNT(*) = 13 FROM INFORMATION_SCHEMA.INNODB_SYS_TABLES WHERE name LIKE 'test/%' | ||
| --let $wait_condition_on_error_output = | ||
| --source include/wait_condition.inc |
There was a problem hiding this comment.
To maintain consistency with the other improvements in this PR and provide better diagnostic information upon failure, consider using wait_condition_with_debug.inc here as well.
--let $wait_condition_on_error_output = SELECT COUNT(*) FROM INFORMATION_SCHEMA.INNODB_SYS_TABLES WHERE name LIKE 'test/%'
--source include/wait_condition_with_debug.inc
| --connection node_1 | ||
| --let $wait_condition = SELECT COUNT(*) = 1000 FROM t1 WHERE MATCH(f1) AGAINST ('foobarbaz') | ||
| --source include/wait_condition.inc | ||
| --let $wait_condition_on_error_output = SELECT * FROM t1 |
There was a problem hiding this comment.
Using SELECT * FROM t1 as debug output for a table with 1000 rows can lead to excessive log output in case of test failure. It is generally better to use SELECT COUNT(*) to diagnose the failure, which is also consistent with the approach used in other parts of this test file (e.g., line 35 and 44).
--let $wait_condition_on_error_output = SELECT COUNT(*) FROM t1
| --connection node_2 | ||
| --let $wait_condition = SELECT COUNT(*) = 1000 FROM t1 WHERE MATCH(f1) AGAINST ('abcdefjhk') | ||
| --source include/wait_condition.inc | ||
| --let $wait_condition_on_error_output = SELECT * FROM t1 |
There was a problem hiding this comment.
Using SELECT * FROM t1 as debug output for a table with 1000 rows can lead to excessive log output. For debugging a failed count condition, SELECT COUNT(*) is usually sufficient and much cleaner in the logs.
--let $wait_condition_on_error_output = SELECT COUNT(*) FROM t1
Test case changes only. Fix wait_conditions.
janlindstrom
force-pushed
the
12.3-MDEV-39561
branch
from
63711ec to
7604734
Compare
This won't fix issue, this is more debugging with more data. Please provide more detail of change in commit message. |
2 participants
Test case changes only. Fix wait_conditions.