Skip to content

Moved some logic from build.sh to csla-mcp-server/Dockerfile to allow…#22

Open
vijaygill wants to merge 4 commits into
MarimerLLC:mainfrom
vijaygill:main
Open

Moved some logic from build.sh to csla-mcp-server/Dockerfile to allow…#22
vijaygill wants to merge 4 commits into
MarimerLLC:mainfrom
vijaygill:main

Conversation

@vijaygill
Copy link
Copy Markdown

@vijaygill vijaygill commented Mar 18, 2026

Fixes #21. I have not tested it with Azure side because I don't have the subscription...

… building docker image on a machine which does not have dotnet.
Copilot AI review requested due to automatic review settings March 18, 2026 18:43
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Moves embeddings generation responsibilities from the host-side build.sh script into the Docker build process so the final image can always include an embeddings.json (either generated or empty), controlled by a build arg.

Changes:

  • Adds SKIP_EMBEDDINGS build arg and generates /embeddings.json during the Docker build stage.
  • Updates the final image to copy embeddings.json from the build stage instead of the local build context.
  • Removes embeddings generation/fallback logic from build.sh and forwards SKIP_EMBEDDINGS into docker build.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
csla-mcp-server/Dockerfile Adds conditional embeddings generation during image build and copies the result into the final stage.
build.sh Removes local embeddings generation and passes SKIP_EMBEDDINGS as a Docker build arg.

Comment thread csla-mcp-server/Dockerfile Outdated
Comment thread csla-mcp-server/Dockerfile Outdated
Comment thread csla-mcp-server/Dockerfile Outdated
Comment thread csla-mcp-server/Dockerfile Outdated
Comment thread build.sh
@vijaygill
Copy link
Copy Markdown
Author

@copilot open a new pull request to apply changes based on the comments in this thread

@vijaygill vijaygill closed this Mar 18, 2026
@vijaygill vijaygill reopened this May 19, 2026
@vijaygill
Copy link
Copy Markdown
Author

@rockfordlhotka - apologies for the delay on this work item. Life got in my way and I still like coding using my 3 braincells :) ("real stupidity" instead of "artificial intelligence").

Please check this branch on your side and let me know if it is OK / needs some work / needs to be rejected.

PS: I rely upon the docker's caching mechanism to save embeddings for future rebuilding of images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate embeddings within the docker build stage "build" to allow building images on machines without dotnet

2 participants