Moved some logic from build.sh to csla-mcp-server/Dockerfile to allow…#22
Moved some logic from build.sh to csla-mcp-server/Dockerfile to allow…#22vijaygill wants to merge 4 commits into
Conversation
… building docker image on a machine which does not have dotnet.
There was a problem hiding this comment.
Pull request overview
Moves embeddings generation responsibilities from the host-side build.sh script into the Docker build process so the final image can always include an embeddings.json (either generated or empty), controlled by a build arg.
Changes:
- Adds
SKIP_EMBEDDINGSbuild arg and generates/embeddings.jsonduring the Docker build stage. - Updates the final image to copy
embeddings.jsonfrom the build stage instead of the local build context. - Removes embeddings generation/fallback logic from
build.shand forwardsSKIP_EMBEDDINGSintodocker build.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| csla-mcp-server/Dockerfile | Adds conditional embeddings generation during image build and copies the result into the final stage. |
| build.sh | Removes local embeddings generation and passes SKIP_EMBEDDINGS as a Docker build arg. |
|
@copilot open a new pull request to apply changes based on the comments in this thread |
|
@rockfordlhotka - apologies for the delay on this work item. Life got in my way and I still like coding using my 3 braincells :) ("real stupidity" instead of "artificial intelligence"). Please check this branch on your side and let me know if it is OK / needs some work / needs to be rejected. PS: I rely upon the docker's caching mechanism to save embeddings for future rebuilding of images. |
Fixes #21. I have not tested it with Azure side because I don't have the subscription...