Default float response examples to 0.0 when no example is provided

Author: MarioRuiz

lib/open_api_import/get_examples.rb

@@ -31,8 +31,16 @@ module LibOpenApiImport
           case val[:type].downcase
           when "string"
             example << " #{prop.to_sym}: \"#{format}\", "
-          when "integer", "number"
+          when "integer"
             example << " #{prop.to_sym}: 0, "
+          when "number"
+            format_name = format.to_s.downcase
+            number_value = if %w[float double decimal].include?(format_name)
+                "0.0"
+              else
+                "0"
+              end
+            example << " #{prop.to_sym}: #{number_value}, "
           when "boolean"
             example << " #{prop.to_sym}: true, "
           when "array"
@@ -59,13 +67,12 @@ module LibOpenApiImport
             else
               #todo: differ between response examples and data examples
               examplet = get_response_examples({ schema: val }, remove_readonly).join("\n")
-              examplet = '[]' if examplet.empty?
+              examplet = "[]" if examplet.empty?
               if type == :only_value
                 example << examplet
               else
                 example << " #{prop.to_sym}: " + examplet + ", "
-              end              
-
+              end
             end
           when "object"
             #todo: differ between response examples and data examples

spec/fixtures/v2.0/yaml/float_response.yaml

@@ -0,0 +1,28 @@
+swagger: "2.0"
+info:
+  title: "Float API"
+  version: "1.0.0"
+host: example.com
+basePath: /
+schemes:
+  - https
+produces:
+  - application/json
+paths:
+  /resource:
+    get:
+      operationId: getResource
+      responses:
+        '200':
+          description: Float response example
+          schema:
+            type: object
+            properties:
+              floatValue:
+                type: number
+                format: float
+                description: Float field with float format
+              integerValue:
+                type: integer
+                format: int32
+                description: Integer field with int format

spec/open_api_import/open_api_import_responses_spec.rb

@@ -1,53 +1,61 @@
-require 'open_api_import'
+require "open_api_import"
 
 RSpec.describe OpenApiImport do
+  describe "#from" do
+    it "adds response codes as keys on responses array" do
+      file_name = "./spec/fixtures/v2.0/yaml/petstore-simple.yaml"
+      File.delete("#{file_name}.rb") if File.exist?("#{file_name}.rb")
+      OpenApiImport.from file_name, create_method_name: :operation_id
+      expect(File.exist?("#{file_name}.rb")).to eq true
+      content = File.read("#{file_name}.rb")
+      eval(content)
+      req = Swagger::SwaggerPetstore::V1_0_0::Root.find_pets
+      expect(req.key?(:responses)).to eq true
+      expect(req[:responses].class).to eq Hash
+      expect(req[:responses].keys).to eq [:'200', :'default']
+    end
 
-    describe '#from' do
-        
-        it 'adds response codes as keys on responses array' do
-            file_name = './spec/fixtures/v2.0/yaml/petstore-simple.yaml'
-            File.delete("#{file_name}.rb") if File.exist?("#{file_name}.rb")
-            OpenApiImport.from file_name, create_method_name: :operation_id
-            expect(File.exist?("#{file_name}.rb")).to eq true
-            content = File.read("#{file_name}.rb")
-            eval(content)
-            req = Swagger::SwaggerPetstore::V1_0_0::Root.find_pets
-            expect(req.key?(:responses)).to eq true
-            expect(req[:responses].class).to eq Hash
-            expect(req[:responses].keys).to eq  [:'200', :'default']
-        end
-
-        it 'adds the message for the response on responses array' do
-            file_name = './spec/fixtures/v2.0/yaml/petstore-simple.yaml'
-            File.delete("#{file_name}.rb") if File.exist?("#{file_name}.rb")
-            OpenApiImport.from file_name, create_method_name: :operation_id
-            expect(File.exist?("#{file_name}.rb")).to eq true
-            content = File.read("#{file_name}.rb")
-            eval(content)
-            req = Swagger::SwaggerPetstore::V1_0_0::Root.find_pets
-            expect(req[:responses][:'200'].key?(:message)).to eq true
-            expect(req[:responses][:'200'][:message]).to eq "pet response"
-        end
-
-        it 'adds the data body for the response on responses array' do
-            file_name = './spec/fixtures/v2.0/yaml/petstore-simple.yaml'
-            File.delete("#{file_name}.rb") if File.exist?("#{file_name}.rb")
-            OpenApiImport.from file_name, create_method_name: :operation_id
-            expect(File.exist?("#{file_name}.rb")).to eq true
-            content = File.read("#{file_name}.rb")
-            eval(content)
-            req = Swagger::SwaggerPetstore::V1_0_0::Root.find_pets
-            expect(req[:responses][:'200'].key?(:data)).to eq true
-            data = [{
-                name: "string",
-                tag: "string",
-                id: 0,
-            }]
-            expect(req[:responses][:'200'][:data]).to eq data
-        end
-
-
+    it "adds the message for the response on responses array" do
+      file_name = "./spec/fixtures/v2.0/yaml/petstore-simple.yaml"
+      File.delete("#{file_name}.rb") if File.exist?("#{file_name}.rb")
+      OpenApiImport.from file_name, create_method_name: :operation_id
+      expect(File.exist?("#{file_name}.rb")).to eq true
+      content = File.read("#{file_name}.rb")
+      eval(content)
+      req = Swagger::SwaggerPetstore::V1_0_0::Root.find_pets
+      expect(req[:responses][:'200'].key?(:message)).to eq true
+      expect(req[:responses][:'200'][:message]).to eq "pet response"
     end
 
+    it "adds the data body for the response on responses array" do
+      file_name = "./spec/fixtures/v2.0/yaml/petstore-simple.yaml"
+      File.delete("#{file_name}.rb") if File.exist?("#{file_name}.rb")
+      OpenApiImport.from file_name, create_method_name: :operation_id
+      expect(File.exist?("#{file_name}.rb")).to eq true
+      content = File.read("#{file_name}.rb")
+      eval(content)
+      req = Swagger::SwaggerPetstore::V1_0_0::Root.find_pets
+      expect(req[:responses][:'200'].key?(:data)).to eq true
+      data = [{
+        name: "string",
+        tag: "string",
+        id: 0,
+      }]
+      expect(req[:responses][:'200'][:data]).to eq data
+    end
 
+    it "uses 0.0 as default example for float numbers without explicit example" do
+      file_name = "./spec/fixtures/v2.0/yaml/float_response.yaml"
+      File.delete("#{file_name}.rb") if File.exist?("#{file_name}.rb")
+      OpenApiImport.from file_name, create_method_name: :operation_id
+      expect(File.exist?("#{file_name}.rb")).to eq true
+      content = File.read("#{file_name}.rb")
+      eval(content)
+      req = Swagger::FloatApi::V1_0_0::Root.get_resource
+      expect(req[:responses][:'200'][:data]).to eq({
+                                                  floatValue: 0.0,
+                                                  integerValue: 0,
+                                                })
+    end
+  end
 end