nit-picking

Author: cyanzhong

src/view.ts

@@ -63,40 +63,6 @@ export function setUp() {
     }
   });
 
-  // Delegate relative links to native file opening
-  previewPane.addEventListener('click', async event => {
-    const target = event.target;
-    if (!(target instanceof HTMLElement)) {
-      return;
-    }
-
-    const anchor = target.closest('a');
-    if (anchor === null) {
-      return;
-    }
-
-    // Use getAttribute to get the raw href, not the resolved absolute URL
-    const href = anchor.getAttribute('href');
-    if (!href?.startsWith('../')) {
-      return;
-    }
-
-    if (typeof MarkEdit.getFileInfo !== 'function') {
-      return;
-    }
-
-    const basePath = (await MarkEdit.getFileInfo())?.parentPath;
-    if (basePath === undefined) {
-      return;
-    }
-
-    event.preventDefault();
-    event.stopPropagation();
-
-    const absolutePath = joinPaths(basePath, decodeURIComponent(href));
-    await MarkEdit.openFile(absolutePath);
-  });
-
   const mutationObserver = new MutationObserver(updateGutterStyle);
   mutationObserver.observe(previewPane, { attributes: true, attributeFilter: ['style', 'class'] });
 
@@ -109,6 +75,11 @@ export function setUp() {
       renderHtmlPreview();
     }
   });
+
+  // Delegate relative links to native file opening
+  if (typeof MarkEdit.getFileInfo === 'function') {
+    previewPane.addEventListener('click', handleExternalFiles);
+  }
 }
 
 export function setViewMode(mode: ViewMode, needsDisplay = true) {
@@ -325,6 +296,38 @@ async function saveGeneratedHtml(styled: boolean) {
   MarkEdit.showSavePanel({ fileName, string });
 }
 
+async function handleExternalFiles(event: MouseEvent) {
+  if (!(event.target instanceof Element)) {
+    return;
+  }
+
+  const anchor = event.target.closest('a');
+  if (anchor === null) {
+    return;
+  }
+
+  // We need to handle this because it is outside of the webpage root
+  const href = anchor.getAttribute('href');
+  if (!href?.startsWith('../')) {
+    return;
+  }
+
+  const basePath = (await MarkEdit.getFileInfo())?.parentPath;
+  if (basePath === undefined) {
+    return;
+  }
+
+  try {
+    const absolutePath = joinPaths(basePath, decodeURIComponent(href));
+    await MarkEdit.openFile(absolutePath);
+
+    event.preventDefault();
+    event.stopPropagation();
+  } catch (error) {
+    console.error(`Failed to open file: ${error}`);
+  }
+}
+
 const states: {
   viewMode: ViewMode;
   splitter: Splitter | undefined;