Retract incorrect suggestion to move window.MarkEditGetHtml outside the else block#78
Closed
Copilot wants to merge 1 commit into
Closed
Retract incorrect suggestion to move window.MarkEditGetHtml outside the else block#78Copilot wants to merge 1 commit into
Copilot wants to merge 1 commit into
Conversation
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on global function exposure in MarkEditGetHtml PR
Retract incorrect suggestion to move window.MarkEditGetHtml outside the else block
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A prior automated review suggested wrapping
window.MarkEditGetHtml = generateStaticHtmlwith??=and moving it outside the__markeditPreviewInitialized__guard, claiming the global could be lost on extension reload. That reasoning is wrong.Why the suggestion was invalid:
windowproperties persist until the page is fully unloaded — script re-execution does not clear themwindow.MarkEditGetHtmlwould be absent, but that also resetswindow.__markeditPreviewInitialized__(not persisted), so theelsebranch runs again and reassigns the globalResolution:
elseblock in the original PR is correct as-is📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.