Code quality

[Copilot]

Comprehensive code quality pass: fix an async safety bug, reduce duplication, tighten style, and improve test coverage from 41 → 58 tests.

Bug fix

proofreadNow() was missing the stale-doc guard that reviewProblems() and lintScheduler.runLint() both have — async lint results could be dispatched against a changed document.

async function proofreadNow() {
  const view = MarkEdit.editorView;
  const doc = view.state.doc;
  const text = doc.toString();
  const lints = await lint(text);
  if (view.state.doc !== doc) return; // was missing
  view.dispatch({ effects: setDiagnosticsEffect.of(lints.map(lintToDiagnostic)) });
}

DRY refactoring

Extracted injectStyleSheet(id, css) in styling.ts to replace 4 copies of the same check-create-append pattern across extension.ts, tooltip.ts, card.ts, and panel.ts.

Style

• async() → async () in menu.ts
• raw.addToDict === false ? false : true → raw.addToDict !== false in settings.ts

Test coverage

• rules.test.ts — preset behavior, subset invariants, no duplicate rule names
• kinds.test.ts — preset values, subset invariants
• card.test.ts — shared card CSS structure validation
• styling.test.ts — all kinds have light+dark colors, hover/active/badge rules generated

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Comprehensive codebase quality scan</issue_title>
<issue_description>The goal is to conduct a comprehensive code review of the existing codebase. This includes refactoring where appropriate, ensuring consistent code style, removing unused code and resources, improving test coverage and quality, and validating that the overall architecture is coherent and maintainable. The code should be clear and easy for developers to read and follow.

Existing user-facing behavior must remain unchanged.</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Comprehensive codebase quality scan #39

---

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.