Comprehensive code quality pass: fix an async safety bug, reduce duplication, tighten style, and improve test coverage from 41 → 58 tests.

Bug fix

proofreadNow() was missing the stale-doc guard that reviewProblems() and lintScheduler.runLint() both have — async lint results could be dispatched against a changed document.

async function proofreadNow() {
  const view = MarkEdit.editorView;
  const doc = view.state.doc;
  const text = doc.toString();
  const lints = await lint(text);
  if (view.state.doc !== doc) return; // was missing
  view.dispatch({ effects: setDiagnosticsEffect.of(lints.map(lintToDiagnostic)) });
}

DRY refactoring

Extracted injectStyleSheet(id, css) in styling.ts to replace 4 copies of the same check-create-append pattern across extension.ts, tooltip.ts, card.ts, and panel.ts.

Style

• async() → async () in menu.ts
• raw.addToDict === false ? false : true → raw.addToDict !== false in settings.ts

Test coverage

• rules.test.ts — preset behavior, subset invariants, no duplicate rule names
• kinds.test.ts — preset values, subset invariants
• card.test.ts — shared card CSS structure validation
• styling.test.ts — all kinds have light+dark colors, hover/active/badge rules generated

• Fixes Comprehensive codebase quality scan #39

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.