Skip to content

Commit a6174e9

Browse files
jorbenclaude
andauthored
fix(icon): 🐛 fix app icon not displaying on macOS when running via npx (#8)
- Add `public/icons/` to npm package files to include icons in published package - Add `getIconPath()` function to intelligently locate icon files across different run modes (dev/npx/packaged) - Use `nativeImage` API for better icon loading with proper error handling - Use PNG format for non-packaged mode as nativeImage has poor .icns/.ico support - Add dedicated macOS PNG icons with transparent margins for Dock magnification effect - Set Dock icon explicitly on macOS using `app.dock.setIcon()` - Add window title 'MarkPDFdown' - Add icons to extraResources for electron-builder packaging Co-authored-by: Claude <noreply@anthropic.com>
1 parent f3b785d commit a6174e9

11 files changed

Lines changed: 93 additions & 9 deletions

File tree

package.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
"files": [
1616
"bin/",
1717
"dist/",
18+
"public/icons/",
1819
"src/core/infrastructure/db/migrations/",
1920
"src/core/infrastructure/db/schema.prisma"
2021
],
@@ -63,6 +64,10 @@
6364
"filter": [
6465
"**/*.sql"
6566
]
67+
},
68+
{
69+
"from": "public/icons",
70+
"to": "icons"
6671
}
6772
],
6873
"asarUnpack": [

public/icons/mac/png/1024x1024.png

403 KB
Loading

public/icons/mac/png/128x128.png

8.04 KB
Loading

public/icons/mac/png/16x16.png

631 Bytes
Loading

public/icons/mac/png/24x24.png

1010 Bytes
Loading

public/icons/mac/png/256x256.png

22 KB
Loading

public/icons/mac/png/32x32.png

1.41 KB
Loading

public/icons/mac/png/48x48.png

2.45 KB
Loading

public/icons/mac/png/512x512.png

83.5 KB
Loading

public/icons/mac/png/64x64.png

3.34 KB
Loading

0 commit comments

Comments
 (0)