fix(updater): 🐛 sanitize update error details (#38)

* fix(updater): 🐛 sanitize update error details

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* ci: 👷 validate update manifests

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: jorben

.github/workflows/release.yml

@@ -124,13 +124,28 @@ jobs:
           echo "Downloaded manifests:"
           find manifests -type f -name "*.yml" | sort
 
-      - name: Filter out builder-debug.yml and keep only latest manifests
+      - name: Filter out builder-debug.yml
         run: |
           # Remove builder-debug.yml from manifests directory (exists in all platform artifacts)
           find manifests -name "builder-debug.yml" -delete
+
           echo "Remaining manifests:"
           find manifests -type f -name "*.yml" | sort
 
+      - name: Validate required manifests
+        run: |
+          REQUIRED=(
+            manifests/update-manifests-win/latest.yml
+            manifests/update-manifests-mac/latest-mac.yml
+            manifests/update-manifests-linux/latest-linux.yml
+          )
+          for file in "${REQUIRED[@]}"; do
+            if [ ! -f "$file" ]; then
+              echo "::error::Missing required update manifest: $file"
+              exit 1
+            fi
+          done
+
       - name: Upload update manifests to release
         uses: softprops/action-gh-release@v2
         with:

src/main/services/UpdateService.ts

@@ -61,8 +61,18 @@ class UpdateService {
     });
 
     autoUpdater.on('error', (error) => {
-      console.error('[UpdateService] Error:', error.message);
-      this.sendStatus({ status: UpdateStatus.ERROR, error: error.message });
+      const errorMessage = error instanceof Error ? error.message : String(error);
+      const safeMessage =
+        errorMessage.length > 200 ? `${errorMessage.slice(0, 200)}...` : errorMessage;
+      const errorDetails = {
+        message: safeMessage,
+        name: error instanceof Error ? error.name : undefined,
+        stack: error instanceof Error ? error.stack : undefined,
+        code: (error as { code?: string | number }).code,
+        statusCode: (error as { statusCode?: number }).statusCode,
+      };
+      console.error('[UpdateService] Error:', errorDetails);
+      this.sendStatus({ status: UpdateStatus.ERROR, error: safeMessage });
     });
   }
 

src/renderer/components/UpdateChecker.tsx

@@ -110,10 +110,17 @@ const UpdateChecker: React.FC = () => {
 
       case "error":
         return (
-          <Space>
-            <CloseCircleOutlined style={{ color: "#ff4d4f" }} />
-            <Text type="danger">{t("update.error")}</Text>
-            <Button onClick={handleCheckForUpdates}>{t("update.retry")}</Button>
+          <Space direction="vertical">
+            <Space>
+              <CloseCircleOutlined style={{ color: "#ff4d4f" }} />
+              <Text type="danger">{t("update.error")}</Text>
+              <Button onClick={handleCheckForUpdates}>{t("update.retry")}</Button>
+            </Space>
+            {statusData.error && (
+              <Text type="secondary" style={{ maxWidth: 420, wordBreak: 'break-word' }}>
+                {statusData.error}
+              </Text>
+            )}
           </Space>
         );