Skip to content

fix(list): 🐛 Prevent cloud task progress regression on page load#65

Merged
jorben merged 1 commit into
masterfrom
fix/cloud-task-progress-merge
May 8, 2026
Merged

fix(list): 🐛 Prevent cloud task progress regression on page load#65
jorben merged 1 commit into
masterfrom
fix/cloud-task-progress-merge

Conversation

@jorben

@jorben jorben commented May 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Fix race condition where fetchTasks API response overwrites SSE real-time progress for cloud tasks
  • Change setData(paginatedList) to functional update with Math.max merge strategy
  • Prevents progress bar from jumping back to 0% when entering the task list page

Root Cause

fetchTasks() unconditionally replaced React state with API response data. Since the cloud API's pages_completed field lags behind SSE events (due to write latency), the progress would regress when the API response arrived after SSE had already updated the UI.

Test Plan

  • Enter task list page while cloud tasks are processing — progress should not flash to 0%
  • Switch tabs and return — progress should remain monotonically increasing
  • New cloud tasks (not yet in state) should display API-provided progress correctly
  • All 935 existing tests pass

🤖 Generated with TiyCode

@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown

AI Code Review Summary

PR: #65 (fix(list): 🐛 Prevent cloud task progress regression on page load)
Preferred language: English

Overall Assessment

No blocking issue was detected in the reviewed diff; keep focused regression testing before merge.

Major Findings by Severity

No major issues identified from the reviewed diff.

Actionable Suggestions

  • Address the highest severity findings first and add targeted tests for changed logic.

Potential Risks

  • Potential hidden risks remain in edge cases not covered by the current diff context.

Test Suggestions

  • Add happy-path + boundary + failure-path tests for touched modules.

File-Level Coverage Notes

  • src/renderer/pages/List.tsx: File was in scope but not fully reviewed before budget limits. (coverage_incomplete)

Inline Downgraded Items (processed but not inline)

  • None

Coverage Status

  • Target files: 1
  • Covered files: 0
  • Uncovered files: 1
  • No-patch/binary covered as file-level: 0
  • Findings with unknown confidence (N/A): 0

Uncovered list:

  • src/renderer/pages/List.tsx: coverage_incomplete

No-patch covered list:

  • None

Runtime/Budget

  • Rounds used: 1/4
  • Planned batches: 1
  • Executed batches: 1
  • Sub-agent runs: 1
  • Planner calls: 2
  • Reviewer calls: 2
  • Model calls: 4/64
  • Structured-output summary-only degradation: YES

Reasons:

  • planner_structured_output_failed_round_1: Structured output failed after repair: 404 The requested model is not included in your subscription plan. Please create a Pay-As-You-Go API Key to access this model, or check available models for your plan at
  • reviewer_structured_output_failed_round_1_general: Structured output failed after repair: 404 The requested model is not included in your subscription plan. Please create a Pay-As-You-Go API Key to access this model, or check available models for your plan at

@jorben
jorben merged commit 15b5436 into master May 8, 2026
3 checks passed
@jorben
jorben deleted the fix/cloud-task-progress-merge branch May 8, 2026 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant