fix(cloud): 🐛 Correct retry progress tracking for partial failures#67
Merged
Conversation
Previously, during retry of failed pages (status PARTIAL_FAILED), the completed count was based on page number from replayed events, which could lead to duplicate counting or incorrect progress. The failed count was not decremented when a retried page succeeded. This commit ensures: - Completed count increments and failed count decrements for each successful retried page. - When all pages are completed after a retry (failed count reaches 0), any remaining non-completed pages are marked as completed. - Both CloudPreview and List components handle retry scenarios consistently.
AI Code Review SummaryPR: #67 (fix(cloud): 🐛 Correct retry progress tracking for partial failures) Overall AssessmentNo blocking issue was detected in the reviewed diff; keep focused regression testing before merge. Major Findings by SeverityNo major issues identified from the reviewed diff. Actionable Suggestions
Potential Risks
Test Suggestions
File-Level Coverage Notes
Inline Downgraded Items (processed but not inline)
Coverage Status
Uncovered list:
No-patch covered list:
Runtime/Budget
Reasons:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Math.maxwith page number)page_retry_startedSSE event handling in CloudPreviewpages_failedwhen a retried page completes in CloudPreviewcompletedevent arrives withpages_failed === 0(retry triggers status 8→6 transition)Test Plan
completedevent after retry: status transitions to COMPLETED, UI refreshes🤖 Generated with TiyCode