Skip to content

fix(cloud): 🐛 Correct retry progress tracking for partial failures#67

Merged
jorben merged 1 commit into
masterfrom
fix/cloud-preview-retry
May 8, 2026
Merged

fix(cloud): 🐛 Correct retry progress tracking for partial failures#67
jorben merged 1 commit into
masterfrom
fix/cloud-preview-retry

Conversation

@jorben

@jorben jorben commented May 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Fix progress calculation in List view during single-page retry (PARTIAL_FAILED → increment completed / decrement failed instead of using Math.max with page number)
  • Add page_retry_started SSE event handling in CloudPreview
  • Decrement pages_failed when a retried page completes in CloudPreview
  • Mark remaining pages as COMPLETED when completed event arrives with pages_failed === 0 (retry triggers status 8→6 transition)

Test Plan

  • Single page retry: progress updates correctly during retry
  • Retry all failed pages: completed/failed counts track accurately
  • SSE completed event after retry: status transitions to COMPLETED, UI refreshes
  • Normal (non-retry) processing: progress still works as before

🤖 Generated with TiyCode

Previously, during retry of failed pages (status PARTIAL_FAILED), the
completed count was based on page number from replayed events, which
could lead to duplicate counting or incorrect progress. The failed
count was not decremented when a retried page succeeded.

This commit ensures:
- Completed count increments and failed count decrements for each
  successful retried page.
- When all pages are completed after a retry (failed count reaches 0),
  any remaining non-completed pages are marked as completed.
- Both CloudPreview and List components handle retry scenarios
  consistently.
@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown

AI Code Review Summary

PR: #67 (fix(cloud): 🐛 Correct retry progress tracking for partial failures)
Preferred language: English

Overall Assessment

No blocking issue was detected in the reviewed diff; keep focused regression testing before merge.

Major Findings by Severity

No major issues identified from the reviewed diff.

Actionable Suggestions

  • Address the highest severity findings first and add targeted tests for changed logic.

Potential Risks

  • Potential hidden risks remain in edge cases not covered by the current diff context.

Test Suggestions

  • Add happy-path + boundary + failure-path tests for touched modules.

File-Level Coverage Notes

  • src/renderer/pages/CloudPreview.tsx: File was in scope but not fully reviewed before budget limits. (coverage_incomplete)
  • src/renderer/pages/List.tsx: File was in scope but not fully reviewed before budget limits. (coverage_incomplete)

Inline Downgraded Items (processed but not inline)

  • None

Coverage Status

  • Target files: 2
  • Covered files: 0
  • Uncovered files: 2
  • No-patch/binary covered as file-level: 0
  • Findings with unknown confidence (N/A): 0

Uncovered list:

  • src/renderer/pages/CloudPreview.tsx: coverage_incomplete
  • src/renderer/pages/List.tsx: coverage_incomplete

No-patch covered list:

  • None

Runtime/Budget

  • Rounds used: 1/4
  • Planned batches: 1
  • Executed batches: 1
  • Sub-agent runs: 1
  • Planner calls: 2
  • Reviewer calls: 2
  • Model calls: 4/64
  • Structured-output summary-only degradation: YES

Reasons:

  • planner_structured_output_failed_round_1: Structured output failed after repair: 404 The requested model is not included in your subscription plan. Please create a Pay-As-You-Go API Key to access this model, or check available models for your plan at
  • reviewer_structured_output_failed_round_1_general: Structured output failed after repair: 404 The requested model is not included in your subscription plan. Please create a Pay-As-You-Go API Key to access this model, or check available models for your plan at

@jorben
jorben merged commit c3ce5d4 into master May 8, 2026
3 checks passed
@jorben
jorben deleted the fix/cloud-preview-retry branch May 8, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant