remove used parameters

Author: MarketDataDev03

docs/FUNDS_REVIEW_GUIDE.md

@@ -84,7 +84,7 @@ These are the load-bearing review points — each is a *contract* fact, verified
 3. **No §12 auto-chunking.** The ~one-year span cap that chunking works around only applies to intraday candle requests. A multi-decade daily funds request is **one** HTTP request, on both the typed resource and the CSV facet (which is why `FundsCsvResource` has no `mergeCsvBodies` analogue). Test: `candlesLongDailyRangeIsASingleRequest`.
 4. **No `extended` parameter.** Extended-hours sessions only exist intraday; exposing the flag would be dead surface. (The backend's OpenAPI schema lists it because funds reuse the stock-candles schema helper, but it can never have an effect.)
 
-Python-SDK parity note: `sdk-py` exposes `symbol/resolution/from/to/countback` only. This PR additionally exposes `date`, `exchange`, `country`, `adjustsplits`, `adjustdividends` — all accepted by the funds endpoint (shared candles serializer/handler) and all meaningful for daily-and-up fund series (CRSP split/dividend adjustment very much applies to funds).
+Python-SDK parity note: `sdk-py` exposes `symbol/resolution/from/to/countback` only. This PR additionally exposes `date` (a window shape the backend honors). It does **not** expose `exchange`, `country`, `adjustsplits`, `adjustdividends`: although the funds OpenAPI schema declares them (it reuses the shared candles serializer), the funds handler ignores `exchange`/`country` entirely and `adjustdividends` is commented out — only `adjustsplits` is read, and `sdk-py` does not surface it either, so all four were dropped for cross-language parity.
 
 ---
 
@@ -94,7 +94,7 @@ One spec builder, `FundsResource.candlesSpec` (package-private static, reused by
 
 | Endpoint | Path | Params |
 |---|---|---|
-| `candlesSpec` | `funds/candles/{resolution}/{symbol}` | `date`/`from`/`to`/`countback`, `exchange`, `country`, `adjustsplits`, `adjustdividends` |
+| `candlesSpec` | `funds/candles/{resolution}/{symbol}` | `date`/`from`/`to`/`countback` |
 
 What to verify:
 - Path segments encoded via `PathSegments.encode` (resolution token too); dates ISO-formatted (`2025-01-17`).

examples/consumer-test/src/main/java/com/marketdata/consumer/FundsApp.java

@@ -19,7 +19,7 @@
  * <ul>
  *   <li>the single endpoint ({@code candles}) with its full parameter surface — universal params
  *       (dateFormat/mode/limit/offset) + the three window shapes ({@code from}/{@code to}, {@code
- *       date}, {@code to}+{@code countback}) and the adjustment/exchange params;
+ *       date}, {@code to}+{@code countback});
  *   <li>what funds do NOT have: no volume column (NAV series), no intraday resolutions (the API
  *       rejects them), and therefore no §12 auto-chunking — a multi-decade daily range is one
  *       request;
@@ -66,7 +66,7 @@ public static void main(String[] args) {
   private static void candlesWithParams(MockServerControl mock, MarketDataClient client) {
     Console.header("funds.candles — the parameter surface");
 
-    // from/to window + adjustment/exchange params + universal params, set fluently.
+    // from/to window + universal params, set fluently.
     Console.step("candles(...) — daily OHLC + universal params (dateFormat/mode/limit)");
     mock.reset();
     mock.script(Step.of(200, CANDLES));
@@ -80,8 +80,6 @@ private static void candlesWithParams(MockServerControl mock, MarketDataClient c
                 FundCandlesRequest.builder(FundResolution.DAILY, "VFINX") // required: resolution + symbol
                     .from(LocalDate.of(2025, 1, 1))
                     .to(LocalDate.of(2025, 1, 31))
-                    .adjustSplits(true)
-                    .adjustDividends(true)
                     .build());
     List<FundCandle> bars = candles.values(); // List<FundCandle>
     Console.ok("candles.values() → " + bars.size() + " bars; iterating (note: no volume column):");

src/main/java/com/marketdata/sdk/FundsResource.java

@@ -153,18 +153,6 @@ static RequestSpec.Builder candlesSpec(FundCandlesRequest r) {
     if (r.countback() != null) {
       b.query("countback", r.countback());
     }
-    if (r.exchange() != null) {
-      b.query("exchange", r.exchange());
-    }
-    if (r.country() != null) {
-      b.query("country", r.country());
-    }
-    if (r.adjustSplits() != null) {
-      b.query("adjustsplits", r.adjustSplits());
-    }
-    if (r.adjustDividends() != null) {
-      b.query("adjustdividends", r.adjustDividends());
-    }
     return b;
   }
 

src/main/java/com/marketdata/sdk/funds/FundCandlesRequest.java

@@ -6,15 +6,15 @@
 
 /**
  * Parameters for {@code GET /v1/funds/candles/{resolution}/{symbol}/}. The {@link FundResolution}
- * and the fund's ticker {@code symbol} are required; the rest bound the window and tune
- * adjustment/exchange resolution.
+ * and the fund's ticker {@code symbol} are required; the rest bound the window.
  *
  * <p>Window rules (enforced in {@link Builder#build()}): {@code date} selects a single trading day
  * and is incompatible with {@code from}/{@code to}/{@code countback}; {@code countback} pairs with
  * {@code to} (not {@code from}) and must be positive.
  *
  * <p>There is no {@code extended} parameter: extended-hours sessions only exist on intraday
- * candles, which the funds endpoint does not serve.
+ * candles, which the funds endpoint does not serve. The funds endpoint also does not honor {@code
+ * exchange}/{@code country}/{@code adjustsplits}/{@code adjustdividends}, so those are not exposed.
  */
 public final class FundCandlesRequest {
 
@@ -24,10 +24,6 @@ public final class FundCandlesRequest {
   private final @Nullable LocalDate from;
   private final @Nullable LocalDate to;
   private final @Nullable Integer countback;
-  private final @Nullable String exchange;
-  private final @Nullable String country;
-  private final @Nullable Boolean adjustSplits;
-  private final @Nullable Boolean adjustDividends;
 
   private FundCandlesRequest(Builder b) {
     this.resolution = b.resolution;
@@ -36,10 +32,6 @@ private FundCandlesRequest(Builder b) {
     this.from = b.from;
     this.to = b.to;
     this.countback = b.countback;
-    this.exchange = b.exchange;
-    this.country = b.country;
-    this.adjustSplits = b.adjustSplits;
-    this.adjustDividends = b.adjustDividends;
   }
 
   /** Shortcut for {@code builder(resolution, symbol).build()}. */
@@ -75,33 +67,13 @@ public String symbol() {
     return countback;
   }
 
-  public @Nullable String exchange() {
-    return exchange;
-  }
-
-  public @Nullable String country() {
-    return country;
-  }
-
-  public @Nullable Boolean adjustSplits() {
-    return adjustSplits;
-  }
-
-  public @Nullable Boolean adjustDividends() {
-    return adjustDividends;
-  }
-
   public static final class Builder {
     private final FundResolution resolution;
     private final String symbol;
     private @Nullable LocalDate date;
     private @Nullable LocalDate from;
     private @Nullable LocalDate to;
     private @Nullable Integer countback;
-    private @Nullable String exchange;
-    private @Nullable String country;
-    private @Nullable Boolean adjustSplits;
-    private @Nullable Boolean adjustDividends;
 
     private Builder(FundResolution resolution, String symbol) {
       this.resolution = Objects.requireNonNull(resolution, "resolution");
@@ -134,30 +106,6 @@ public Builder countback(int countback) {
       return this;
     }
 
-    /** Disambiguate the exchange (acronym, MIC code, or two-digit Yahoo code). */
-    public Builder exchange(String exchange) {
-      this.exchange = Objects.requireNonNull(exchange, "exchange");
-      return this;
-    }
-
-    /** Disambiguate the exchange country (two-digit ISO 3166 code). */
-    public Builder country(String country) {
-      this.country = Objects.requireNonNull(country, "country");
-      return this;
-    }
-
-    /** Adjust for splits and reverse splits (daily default true). */
-    public Builder adjustSplits(boolean adjustSplits) {
-      this.adjustSplits = adjustSplits;
-      return this;
-    }
-
-    /** Adjust for dividends (daily default true). */
-    public Builder adjustDividends(boolean adjustDividends) {
-      this.adjustDividends = adjustDividends;
-      return this;
-    }
-
     public FundCandlesRequest build() {
       FundRequests.requireNonEmpty(symbol, "symbol");
       FundRequests.validateWindow(date, from, to, countback);

src/test/java/com/marketdata/sdk/FundsResourceTest.java

@@ -79,22 +79,14 @@ void candlesAttachesAllParams() {
             FundCandlesRequest.builder(FundResolution.WEEKLY, "VFINX")
                 .from(LocalDate.of(2025, Month.JANUARY, 1))
                 .to(LocalDate.of(2025, Month.JANUARY, 31))
-                .exchange("XNAS")
-                .country("US")
-                .adjustSplits(true)
-                .adjustDividends(false)
                 .build())
         .join();
 
     String url = client.captured.get(0).uri().toString();
     assertThat(url)
         .contains("/v1/funds/candles/W/VFINX/")
         .contains("from=2025-01-01")
-        .contains("to=2025-01-31")
-        .contains("exchange=XNAS")
-        .contains("country=US")
-        .contains("adjustsplits=true")
-        .contains("adjustdividends=false");
+        .contains("to=2025-01-31");
   }
 
   @Test