add from -> to validation

Author: MarketDataDev03

src/main/java/com/marketdata/sdk/funds/FundRequests.java

@@ -12,7 +12,7 @@ private FundRequests() {}
    * Validates the historical-window parameters: {@code date} is a single-point lookup incompatible
    * with any ranging parameter; {@code countback} is an alternative to {@code from} for the left
    * edge (per the API: "if you use from, countback is not required"), so the two cannot be
-   * combined; and {@code countback} must be positive.
+   * combined; {@code countback} must be positive; and {@code from} must not be after {@code to}.
    */
   static void validateWindow(
       @Nullable LocalDate date,
@@ -22,6 +22,9 @@ static void validateWindow(
     if (date != null && (from != null || to != null || countback != null)) {
       throw new IllegalArgumentException("date and from/to/countback are mutually exclusive");
     }
+    if (from != null && to != null && from.isAfter(to)) {
+      throw new IllegalArgumentException("from must not be after to");
+    }
     if (countback != null) {
       if (countback <= 0) {
         throw new IllegalArgumentException("countback must be positive");

src/main/java/com/marketdata/sdk/options/OptionsQuoteRequest.java

@@ -112,8 +112,8 @@ public OptionsQuoteRequest build() {
   /**
    * Shared validation for the historical-window parameters across both quote request forms: {@code
    * date} is a single snapshot incompatible with any ranging parameter; {@code countback} is an
-   * alternative to {@code from} for the left edge, so the two cannot be combined; and {@code
-   * countback} must be positive.
+   * alternative to {@code from} for the left edge, so the two cannot be combined; {@code countback}
+   * must be positive; and {@code from} must not be after {@code to}.
    */
   static void validateWindow(
       @Nullable LocalDate date,
@@ -123,6 +123,9 @@ static void validateWindow(
     if (date != null && (from != null || to != null || countback != null)) {
       throw new IllegalArgumentException("date and from/to/countback are mutually exclusive");
     }
+    if (from != null && to != null && from.isAfter(to)) {
+      throw new IllegalArgumentException("from must not be after to");
+    }
     if (countback != null) {
       if (countback <= 0) {
         throw new IllegalArgumentException("countback must be positive");

src/main/java/com/marketdata/sdk/stocks/StockRequests.java

@@ -12,7 +12,8 @@ private StockRequests() {}
    * Validates the historical-window parameters shared by candles/news/earnings: {@code date} is a
    * single-point lookup incompatible with any ranging parameter; {@code countback} is an
    * alternative to {@code from} for the left edge (per the API: "if you use from, countback is not
-   * required"), so the two cannot be combined; and {@code countback} must be positive.
+   * required"), so the two cannot be combined; {@code countback} must be positive; and {@code from}
+   * must not be after {@code to}.
    */
   static void validateWindow(
       @Nullable LocalDate date,
@@ -22,6 +23,9 @@ static void validateWindow(
     if (date != null && (from != null || to != null || countback != null)) {
       throw new IllegalArgumentException("date and from/to/countback are mutually exclusive");
     }
+    if (from != null && to != null && from.isAfter(to)) {
+      throw new IllegalArgumentException("from must not be after to");
+    }
     if (countback != null) {
       if (countback <= 0) {
         throw new IllegalArgumentException("countback must be positive");

src/test/java/com/marketdata/sdk/FundsResourceTest.java

@@ -151,11 +151,14 @@ void candlesAcceptsDateOnlyTimestampStringForDailyBars() {
 
   @Test
   void candlesNoDataEnvelopeYieldsEmptyList() {
-    CapturingClient client = okWith("{\"s\":\"no_data\"}");
+    // The backend signals no_data with 404 + {"s":"no_data"} (the API-wide convention) — the SDK
+    // surfaces that as a successful empty response (isNoData() == true), not an exception.
+    CapturingClient client = notFoundWith("{\"s\":\"no_data\"}");
     FundsResource funds = resourceWith(client);
 
-    assertThat(funds.candles(FundCandlesRequest.of(FundResolution.DAILY, "NOPE")).values())
-        .isEmpty();
+    var response = funds.candles(FundCandlesRequest.of(FundResolution.DAILY, "NOPE"));
+    assertThat(response.values()).isEmpty();
+    assertThat(response.isNoData()).isTrue();
   }
 
   @Test
@@ -374,6 +377,18 @@ void candlesRequestRejectsCountbackWithFrom() {
         .hasMessageContaining("countback and from");
   }
 
+  @Test
+  void candlesRequestRejectsFromAfterTo() {
+    assertThatThrownBy(
+            () ->
+                FundCandlesRequest.builder(FundResolution.DAILY, "VFINX")
+                    .from(LocalDate.of(2025, Month.JANUARY, 31))
+                    .to(LocalDate.of(2025, Month.JANUARY, 1))
+                    .build())
+        .isInstanceOf(IllegalArgumentException.class)
+        .hasMessageContaining("from must not be after to");
+  }
+
   @Test
   void candlesRequestRequiresNonEmptySymbol() {
     assertThatThrownBy(() -> FundCandlesRequest.of(FundResolution.DAILY, ""))
@@ -406,6 +421,10 @@ private static CapturingClient okWith(String body) {
     return new CapturingClient(200, body.getBytes(StandardCharsets.UTF_8), EMPTY_HEADERS);
   }
 
+  private static CapturingClient notFoundWith(String body) {
+    return new CapturingClient(404, body.getBytes(StandardCharsets.UTF_8), EMPTY_HEADERS);
+  }
+
   private static final class CapturingClient extends TestHttpClients.StubHttpClient {
     final List<HttpRequest> captured = new ArrayList<>();
     final int status;

src/test/java/com/marketdata/sdk/OptionsResourceTest.java

@@ -636,6 +636,18 @@ void quoteRequestRejectsNonPositiveCountback() {
         .hasMessageContaining("countback must be positive");
   }
 
+  @Test
+  void quoteRequestRejectsFromAfterTo() {
+    assertThatThrownBy(
+            () ->
+                OptionsQuoteRequest.builder("X")
+                    .from(LocalDate.of(2025, Month.JANUARY, 31))
+                    .to(LocalDate.of(2025, Month.JANUARY, 1))
+                    .build())
+        .isInstanceOf(IllegalArgumentException.class)
+        .hasMessageContaining("from must not be after to");
+  }
+
   // ---------- quote: response decoding ----------
 
   @Test

src/test/java/com/marketdata/sdk/StocksResourceTest.java

@@ -735,6 +735,18 @@ void earningsRequestRejectsCountbackWithFrom() {
         .hasMessageContaining("countback and from");
   }
 
+  @Test
+  void candlesRequestRejectsFromAfterTo() {
+    assertThatThrownBy(
+            () ->
+                StockCandlesRequest.builder(StockResolution.DAILY, "AAPL")
+                    .from(LocalDate.of(2025, Month.JANUARY, 31))
+                    .to(LocalDate.of(2025, Month.JANUARY, 1))
+                    .build())
+        .isInstanceOf(IllegalArgumentException.class)
+        .hasMessageContaining("from must not be after to");
+  }
+
   @Test
   void quotesRequestRequiresAtLeastOneSymbol() {
     assertThatThrownBy(() -> StockQuotesRequest.builder(""))