change attempts 3->4

Author: MarketDataDev03

CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+- Default retry attempts corrected from 3 to 4 (one initial + three retries) to
+  match SDK requirements §9.3 ("max 3 retries, yielding 4 total attempts").
+
 ### Added
 - Project scaffold per ADRs 001–007: Gradle Kotlin DSL build, JDK 17 toolchain,
   `integrationTest` source set, Spotless + JaCoCo, Vanniktech Maven Publish.

CLAUDE.md

@@ -67,7 +67,7 @@ The Java SDK must also satisfy the canonical, cross-language [SDK Requirements](
 - §6 sealed `MarketDataException` hierarchy with the 7 canonical subtypes and full support context (`requestId`, `requestUrl`, `statusCode`, `timestamp`, `exceptionType`) + `getSupportInfo()`.
 - §10 timeouts: `REQUEST_TIMEOUT = 99s` and `CONNECT_TIMEOUT = 2s` exposed as constants on `MarketDataClient`. Connect timeout is wired into the `HttpClient`; the per-request 99 s timeout is applied via `HttpRequest.Builder#timeout` in `HttpTransport.buildRequest`.
 - §12 concurrency: 50-permit `AsyncSemaphore` on `HttpTransport` with acquire/release wired around every dispatch. The custom semaphore replaces `java.util.concurrent.Semaphore` so `executeAsync` never parks the caller's thread on a full pool (ADR-007).
-- §9 retry/backoff: `RetryPolicy` (3 attempts, exponential 1s→30s) wired into `HttpTransport.executeAsync` via a per-attempt loop using `CompletableFuture.delayedExecutor` (no scheduled threads). Network errors and HTTP 501–599 retry; 500 and 4xx do not.
+- §9 retry/backoff: `RetryPolicy` (4 total attempts = 1 initial + 3 retries, exponential 1s→30s per §9.3) wired into `HttpTransport.executeAsync` via a per-attempt loop using `CompletableFuture.delayedExecutor` (no scheduled threads). Network errors and HTTP 501–599 retry; 500 and 4xx do not.
 - §15 packaging: SemVer, MIT `LICENSE`, `CHANGELOG.md` in Keep a Changelog format, version auto-detected via JAR manifest (`Implementation-Version`).
 - §16 security: tokens never logged verbatim (use `Tokens.redact`); TLS validated by default (`HttpClient` does not expose a skip-verify option).
 - ADR-002 CI: split into four workflows.

src/main/java/com/marketdata/sdk/RetryPolicy.java

@@ -7,15 +7,15 @@
 import java.time.Duration;
 
 /**
- * Decides which failures get retried and how long to wait between attempts. SDK requirements §9
- * fixes the parameters: max 3 attempts total (one initial + two retries), exponential backoff
- * starting at 1s, capped at 30s. Network errors (only when wrapping an {@link IOException}-shaped
- * cause — see {@link #shouldRetry}) and HTTP 501–599 are retriable; 500 specifically is not, and
- * 4xx (including 401/429) surfaces immediately.
+ * Decides which failures get retried and how long to wait between attempts. Per SDK requirements
+ * §9.3: max 3 retries (yielding 4 total attempts) with exponential backoff {@code initial *
+ * 2^retry} starting at 1s, capped at 30s. Network errors (only when wrapping an {@link
+ * IOException}-shaped cause — see {@link #shouldRetry}) and HTTP 501–599 are retriable; 500
+ * specifically is not, and 4xx (including 401/429) surfaces immediately.
  *
- * <p><strong>Worst-case wall-clock per {@code executeAsync} call (defaults):</strong> 3 attempts ×
- * 99s per-request timeout + 1s + 2s backoff ≈ 5 minutes. SDK requirements §10 only mandates the
- * per-request timeout, not an overall deadline, so this is compliant — but callers in
+ * <p><strong>Worst-case wall-clock per {@code executeAsync} call (defaults):</strong> 4 attempts ×
+ * 99s per-request timeout + 1s + 2s + 4s backoff ≈ 6.75 minutes. SDK requirements §10 only mandates
+ * the per-request timeout, not an overall deadline, so this is compliant — but callers in
  * latency-sensitive contexts may want to wrap calls with their own {@code orTimeout} cap.
  *
  * <p>The constructor accepts custom values so tests can drive retries with sub-millisecond delays
@@ -36,9 +36,9 @@ final class RetryPolicy {
     this.maxBackoff = maxBackoff;
   }
 
-  /** Spec defaults: 3 attempts, 1s → 30s exponential. */
+  /** Defaults: 4 attempts, 1s → 30s exponential. */
   static RetryPolicy defaults() {
-    return new RetryPolicy(3, Duration.ofSeconds(1), Duration.ofSeconds(30));
+    return new RetryPolicy(4, Duration.ofSeconds(1), Duration.ofSeconds(30));
   }
 
   /**

src/test/java/com/marketdata/sdk/RetryPolicyTest.java

@@ -105,11 +105,12 @@ void unknownThrowableIsNotRetriable() {
   void retriesStopAfterMaxAttempts() {
     NetworkError retriable =
         new NetworkError("net", ErrorContext.empty(), new java.io.IOException("transport down"));
-    // Defaults: maxAttempts = 3 → only attempts 0 and 1 are eligible to be followed by a retry
-    // (attempt 2 was the third try; no fourth attempt allowed).
+    // Defaults: maxAttempts = 4 → attempts 0, 1, 2 are eligible to be followed by a retry
+    // (attempt 3 was the fourth try; no fifth attempt allowed).
     assertThat(DEFAULTS.shouldRetry(retriable, 0)).isTrue();
     assertThat(DEFAULTS.shouldRetry(retriable, 1)).isTrue();
-    assertThat(DEFAULTS.shouldRetry(retriable, 2)).isFalse();
+    assertThat(DEFAULTS.shouldRetry(retriable, 2)).isTrue();
+    assertThat(DEFAULTS.shouldRetry(retriable, 3)).isFalse();
     assertThat(DEFAULTS.shouldRetry(retriable, 99)).isFalse();
   }