Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ private OptionsQuotesRequest(Builder b) {
this.countback = b.countback;
}

/** Shortcut for {@code builder(first, rest...).build()}. */
public static OptionsQuotesRequest of(String first, String... rest) {
return builder(first, rest).build();
}

/**
* Start a builder with one or more option symbols. At least one symbol is required; duplicates
* are kept (each one results in its own HTTP call).
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ private StockQuotesRequest(Builder b) {
this.week52 = b.week52;
}

/** Shortcut for {@code builder(first, rest...).build()}. */
public static StockQuotesRequest of(String first, String... rest) {
return builder(first, rest).build();
}

/** Start a builder with one or more ticker symbols. At least one is required. */
public static Builder builder(String first, String... rest) {
Builder b = new Builder();
Expand Down
18 changes: 18 additions & 0 deletions src/test/java/com/marketdata/sdk/RequestValidationTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,16 @@ void stockQuotesOptInColumnSettersChain() {
assertThat(r.week52()).isTrue();
}

@Test
void stockQuotesOfFactoryCarriesSymbolsAndDefaultsOptionals() {
StockQuotesRequest r = StockQuotesRequest.of("AAPL", "MSFT");

assertThat(r.symbols()).containsExactly("AAPL", "MSFT");
assertThat(r.extended()).isNull();
assertThat(r.candle()).isNull();
assertThat(r.week52()).isNull();
}

@Test
void stockCandlesCountbackSetterIsCarried() {
StockCandlesRequest r =
Expand Down Expand Up @@ -114,6 +124,14 @@ void optionsQuotesFromSetterIsCarried() {
assertThat(r.from()).isEqualTo(TODAY.minusDays(1));
}

@Test
void optionsQuotesOfFactoryCarriesSymbolsAndDefaultsOptionals() {
OptionsQuotesRequest r = OptionsQuotesRequest.of("AAPL250620C00200000", "AAPL250620P00200000");

assertThat(r.optionSymbols()).containsExactly("AAPL250620C00200000", "AAPL250620P00200000");
assertThat(r.from()).isNull();
}

@Test
void optionsRequestsRejectEmptyInputs() {
assertThatThrownBy(() -> OptionsStrikesRequest.of(""))
Expand Down
Loading