Skip to content

refactor: remove retired Options Strikes endpoint#21

Merged
MarketDataDev03 merged 1 commit into
mainfrom
20_remove_strikes
Jun 29, 2026
Merged

refactor: remove retired Options Strikes endpoint#21
MarketDataDev03 merged 1 commit into
mainfrom
20_remove_strikes

Conversation

@MarketDataDev03

Copy link
Copy Markdown
Collaborator

refactor: remove retired Options Strikes endpoint

Closes #20.

The standalone Options Strikes endpoint (GET /v1/options/strikes/{symbol}/) has been
retired — strikes data is now obtained via the chain endpoint. The docs already dropped the
strikes page (the API reference and the Python/PHP/Go SDK docs redirect /options/strikes
/options/chain, and documentation@staging removed sdk/java/options/strikes.mdx). The Java SDK
still shipped the strikes() method, so it exposed a dead endpoint. This removes it.

Stacked on #18 (17_add_convinence_factory) — review/merge that first; this PR's base is that
branch, so the diff here is strikes-only.

Removed (strikes-endpoint only)

  • OptionsResourcestrikes(...) / strikesAsync(...) / strikesSpec(...), the
    OptionsStrikes deserializer registration, and now-unused imports
  • OptionsCsvResource / OptionsHtmlResourcestrikes() / strikesAsync()
  • Classes: options/OptionsStrikesRequest, OptionsStrikesResponse, OptionsStrikesDeserializer,
    options/OptionsStrikes, options/ExpirationStrikes
  • Tests: the strikes block in OptionsResourceTest (URL/params, decoding, envelope handling), the
    strikes assertions in the CSV/HTML facet coverage tests and RequestValidationTest, and
    OptionsIntegrationTest.strikesReturnsStrikesPerExpiration
  • Docs: MarketDataClient javadoc, README.md, docs/OPTIONS_REVIEW_GUIDE.md

Kept (shared with chain — NOT part of the strikes endpoint)

  • options/StrikeFilter and options/StrikeRange — used by OptionsChainRequest for the chain
    endpoint's strike filtering.

Testing

  • ./gradlew build passes: unit tests, Spotless, and jacocoTestCoverageVerification
    (100% line coverage maintained).
  • Repo-wide sweep confirms no remaining references to the removed endpoint
    (OptionsStrikes, ExpirationStrikes, .strikes(, strikesSpec, options/strikes).

Versioning

The SDK is pre-1.0 (0.x), so removing this endpoint is not a major/breaking bump under SemVer —
0.x explicitly allows API changes between minor releases. Bump the minor version (0.x → 0.(x+1)).

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

The author of this PR, MarketDataDev03, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at support@codecov.io with any questions.

@MarketDataDev03 MarketDataDev03 changed the base branch from main to 17_add_convinence_factory June 26, 2026 19:23
@MarketDataDev03 MarketDataDev03 force-pushed the 17_add_convinence_factory branch from 974058a to ca3704e Compare June 29, 2026 14:23
Base automatically changed from 17_add_convinence_factory to main June 29, 2026 14:25
@MarketDataDev03 MarketDataDev03 merged commit 31d1c1d into main Jun 29, 2026
5 checks passed
@MarketDataDev03 MarketDataDev03 deleted the 20_remove_strikes branch June 29, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove retired Options Strikes endpoint (strikes() method)

2 participants