Skip to content

Commit 772a11a

Browse files
Merge pull request #42 from MarketDataApp/update/php-8.2-8.5
v1.0.0 Release - PHP 8.2+ with Full Feature Parity
2 parents 9382d06 + b090d30 commit 772a11a

424 files changed

Lines changed: 48798 additions & 63633 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/BUG_FINDING.md

Lines changed: 689 additions & 0 deletions
Large diffs are not rendered by default.

.github/ISSUE_TEMPLATE/bug.yml

Lines changed: 112 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -1,58 +1,121 @@
11
name: Bug Report
2-
description: Report an Issue or Bug with the Package
2+
description: Report a bug in the Market Data PHP SDK
33
title: "[Bug]: "
44
labels: ["bug"]
55
body:
6-
- type: markdown
7-
attributes:
8-
value: |
9-
We're sorry to hear you have a problem. Can you help us solve it by providing the following details.
10-
- type: textarea
11-
id: what-happened
12-
attributes:
13-
label: What happened?
14-
description: What did you expect to happen?
15-
placeholder: I cannot currently do X thing because when I do, it breaks X thing.
16-
validations:
6+
- type: markdown
7+
attributes:
8+
value: |
9+
Thanks for reporting a bug. Please fill out all required fields to help us reproduce and fix the issue.
10+
11+
**Important:** The SDK returns data exactly as the API provides it. Before reporting, please verify the behavior you're seeing differs from what the [API documentation](https://www.marketdata.app/docs/api) describes.
12+
13+
- type: checkboxes
14+
id: api-docs-verified
15+
attributes:
16+
label: API Documentation Verification
17+
description: Confirm you've checked the API documentation before reporting this as an SDK bug.
18+
options:
19+
- label: I have reviewed the [API documentation](https://www.marketdata.app/docs/api) for this endpoint
1720
required: true
18-
- type: textarea
19-
id: how-to-reproduce
20-
attributes:
21-
label: How to reproduce the bug
22-
description: How did this occur, please add any config values used and provide a set of reliable steps if possible.
23-
placeholder: When I do X I see Y.
24-
validations:
21+
- label: The behavior I'm reporting differs from what the API documentation describes (not just unexpected to me)
2522
required: true
26-
- type: input
27-
id: package-version
28-
attributes:
29-
label: Package Version
30-
description: What version of our Package are you running? Please be as specific as possible
31-
placeholder: 2.0.0
32-
validations:
33-
required: true
34-
- type: input
35-
id: php-version
36-
attributes:
37-
label: PHP Version
38-
description: What version of PHP are you running? Please be as specific as possible
39-
placeholder: 8.2.0
40-
validations:
41-
required: true
42-
- type: dropdown
43-
id: operating-systems
44-
attributes:
45-
label: Which operating systems does with happen with?
46-
description: You may select more than one.
47-
multiple: true
48-
options:
23+
24+
- type: dropdown
25+
id: endpoint
26+
attributes:
27+
label: SDK Endpoint
28+
description: Which part of the SDK is affected?
29+
options:
30+
- stocks
31+
- options
32+
- markets
33+
- mutual_funds
34+
- utilities
35+
- Client (general)
36+
- Other
37+
validations:
38+
required: true
39+
40+
- type: input
41+
id: method
42+
attributes:
43+
label: Method
44+
description: Which method are you calling? (e.g., candles, quote, option_chain)
45+
placeholder: candles
46+
validations:
47+
required: true
48+
49+
- type: textarea
50+
id: reproduction
51+
attributes:
52+
label: Reproduction Code
53+
description: Complete, runnable PHP code that demonstrates the bug. Must be self-contained.
54+
placeholder: |
55+
<?php
56+
require 'vendor/autoload.php';
57+
58+
$client = new MarketDataApp\Client();
59+
$result = $client->stocks->candles('AAPL', from: '2024-01-01');
60+
// Bug: ...
61+
render: php
62+
validations:
63+
required: true
64+
65+
- type: textarea
66+
id: expected
67+
attributes:
68+
label: Expected Behavior
69+
description: What should happen?
70+
placeholder: The method should return candle data for the specified date range.
71+
validations:
72+
required: true
73+
74+
- type: textarea
75+
id: actual
76+
attributes:
77+
label: Actual Behavior
78+
description: What actually happens? Include any error messages.
79+
placeholder: |
80+
TypeError: Cannot access property on null
81+
Stack trace: ...
82+
validations:
83+
required: true
84+
85+
- type: input
86+
id: sdk-version
87+
attributes:
88+
label: SDK Version
89+
description: Run `composer show marketdataapp/sdk-php` to find this
90+
placeholder: "1.0.0"
91+
validations:
92+
required: true
93+
94+
- type: input
95+
id: php-version
96+
attributes:
97+
label: PHP Version
98+
description: Run `php -v` to find this
99+
placeholder: "8.2.0"
100+
validations:
101+
required: true
102+
103+
- type: dropdown
104+
id: os
105+
attributes:
106+
label: Operating System
107+
multiple: true
108+
options:
49109
- macOS
50110
- Windows
51111
- Linux
52-
- type: textarea
53-
id: notes
54-
attributes:
55-
label: Notes
56-
description: Use this field to provide any other notes that you feel might be relevant to the issue.
57-
validations:
58-
required: false
112+
validations:
113+
required: false
114+
115+
- type: textarea
116+
id: notes
117+
attributes:
118+
label: Additional Context
119+
description: Any other relevant information (config, workarounds tried, etc.)
120+
validations:
121+
required: false

0 commit comments

Comments
 (0)