Skip to content

fix: fix secret handling without curly braces #4900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaltat merged 1 commit into from
May 14, 2026
Merged

fix: fix secret handling without curly braces #4900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Browser/base/librarycomponent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,8 @@ def _replace_placeholder_variable(self, placeholder):
if value is NOT_FOUND:
logger.warn("Given variable placeholder could not be resolved.")
return placeholder
if isinstance(value, Secret):
return value.value
return value

@property
Expand Down
40 changes: 38 additions & 2 deletions atest/test/02_Content_Keywords/secret.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,52 @@ Test Setup Ensure Open Page ${LOGIN_URL}
Test Tags require-rf-7.4+

*** Test Cases ***
Type Secret
Type Secret And Verify
${secret} = Get Secret Value
Type Secret input#username_field ${secret}
Get Text input#username_field == Joulupukki

Fill Secret
Fill Secret And Verify
${secret} = Get Secret Value
Fill Secret input#username_field ${secret}
Get Text input#username_field == Joulupukki

Type Secret And Fails With Curly Brackets
Set Browser Timeout 500ms scope=Test
${secret} = Get Secret Value
TRY
Type Secret notHere ${secret}
EXCEPT * type=GLOB AS ${error}
Should Contain ${error} notHere
END

Fill Secret And Fails With Curly Brackets
Set Browser Timeout 500ms scope=Test
${secret} = Get Secret Value
TRY
Fill Secret notHere ${secret}
EXCEPT * type=GLOB AS ${error}
Should Contain ${error} notHere
END

Type Secret And Fails Without Curly Brackets
Set Browser Timeout 500ms scope=Test
${secret} = Get Secret Value
TRY
Type Secret notHere $secret
EXCEPT * type=GLOB AS ${error}
Should Contain ${error} notHere
END

Fill Secret And Fails Without Curly Brackets
Set Browser Timeout 500ms scope=Test
${secret} = Get Secret Value
TRY
Fill Secret notHere $secret
EXCEPT * type=GLOB AS ${error}
Should Contain ${error} notHere
END

New Context With Secret As Literal In httpCredentials Is Not Supported
${secret} = Get Secret Value
TRY
Expand Down
Loading