fix: Fix unused-variable reported on the FOR loop variable with type (#1706)

Author: bhirsz

docs/releasenotes/8.0.0.md

@@ -42,7 +42,7 @@
 
   ```
   Found 1 issue.
-  1 fixable with the ``--fix`` option.
+  1 fixable with the '--fix' option.
   ```
 
   Currently, I have added a few new rules with fixes and implemented fix for a few old rules.

src/robocop/linter/reports/print_issues.py

@@ -291,7 +291,7 @@ def print_run_summary(self, diagnostics: Diagnostics, run_stats: RunStatistic) -
             summary = f"Found {len(diagnostics.diagnostics)} issue{suffix}."
             could_fix = len(diagnostics.fixable_diagnostics())
             if could_fix > 0:
-                summary += f"\n{could_fix} fixable with the ``--fix`` option."
+                summary += f"\n{could_fix} fixable with the '--fix' option."
         self.console.print(summary)
 
     def _print_diffs(self, modified_files: list[SourceFile]) -> None:

src/robocop/linter/rules/misc.py

@@ -1460,7 +1460,7 @@ def visit_For(self, node: For) -> None:  # noqa: N802
         for token in node.header.get_tokens(Token.ARGUMENT, "OPTION"):  # Token.Option does not exist for RF3 and RF4
             self.find_not_nested_variable(token.value, can_be_escaped=False)
         for token in node.header.get_tokens(Token.VARIABLE):
-            self.handle_assign_variable(token, ignore_var_conversion=False)
+            self.handle_assign_variable(token)
         self.generic_visit(node)
         self.ignore_overwriting = False
         self.in_loop = False

tests/cache/test_cache_integration.py

@@ -278,12 +278,12 @@ def test_cache_with_fixable_rule(self, tmp_path, capsys):
             # Assert - first run not yet cached, all issues
             assert "Used cached results" not in out1
             assert len(result1) == 3
-            assert "1 fixable with the ``--fix`` option." in out1
+            assert "1 fixable with the '--fix' option." in out1
 
             # Assert - second run cached, all issues
             assert "Used cached results" in out2
             assert len(result2) == 3
-            assert "1 fixable with the ``--fix`` option." in out2
+            assert "1 fixable with the '--fix' option." in out2
 
             # Assert - third run not cached, only unfixable issues in results (fixable goes to diff)
             assert "Used cached results" not in out3  # we didn't use cache since we generated diff
@@ -293,7 +293,7 @@ def test_cache_with_fixable_rule(self, tmp_path, capsys):
             # Assert - fourth run cached, all issues (no changes from diff)
             assert "Used cached results" in out4
             assert len(result4) == 3
-            assert "1 fixable with the ``--fix`` option." in out4
+            assert "1 fixable with the '--fix' option." in out4
 
             # Assert - fifth run not cached, only unfixable issues in results (fixable are fixed)
             assert "Used cached results" not in out5

tests/linter/rules/deprecated/deprecated_force_tags/expected_output.txt

@@ -1,4 +1,4 @@
 test.robot:2:1 [W] DEPR07 'Force Tags' is deprecated, use 'Test Tags' instead
 
 Found 1 issue.
-1 fixable with the ``--fix`` option.
+1 fixable with the '--fix' option.

tests/linter/rules/deprecated/deprecated_force_tags/expected_output_extended.txt

@@ -6,4 +6,4 @@ test.robot:2:1 DEPR07 'Force Tags' is deprecated, use 'Test Tags' instead
    |
 
 Found 1 issue.
-1 fixable with the ``--fix`` option.
+1 fixable with the '--fix' option.

tests/linter/rules/deprecated/deprecated_return_keyword/expected_extended.txt

@@ -18,4 +18,4 @@ test.robot:4:5 DEPR10 'BuiltIn.Return From Keyword' is deprecated, use 'RETURN'
    |
 
 Found 2 issues.
-2 fixable with the ``--fix`` option.
+2 fixable with the '--fix' option.

tests/linter/rules/deprecated/deprecated_return_keyword/expected_output.txt

@@ -2,4 +2,4 @@ test.robot:3:5 [W] DEPR10 'Return From Keyword If' is deprecated, use 'IF and RE
 test.robot:4:5 [W] DEPR10 'BuiltIn.Return From Keyword' is deprecated, use 'RETURN' instead
 
 Found 2 issues.
-2 fixable with the ``--fix`` option.
+2 fixable with the '--fix' option.

tests/linter/rules/deprecated/deprecated_return_setting/expected_extended.txt

@@ -72,4 +72,4 @@ test_fix.robot:60:5 DEPR11 '[Return]' is deprecated, use 'RETURN' instead
     |
 
 Found 8 issues.
-8 fixable with the ``--fix`` option.
+8 fixable with the '--fix' option.

tests/linter/rules/deprecated/deprecated_return_setting/expected_output.txt

@@ -1,4 +1,4 @@
 test.robot:6:5 [W] DEPR11 '[Return]' is deprecated, use 'RETURN' instead
 
 Found 1 issue.
-1 fixable with the ``--fix`` option.
+1 fixable with the '--fix' option.