Fix lint errors and review feedback in test suite

- Remove unused pytest imports from 6 Python test files
- Remove unused Impl/BaseRepository imports from test_repositories.py
- Remove unused vi/getCounts/getSelectedValuesForCategory from filters-extended.test.ts
- Fix global -> globalThis in SpecTabs.test.tsx for ESLint compatibility
- Add configurable: true to window.location mock in SpecTabs.test.tsx
- Use clear=True in patch.dict for test isolation in test_config_resolve.py
- Use precise <loc> assertions in test_seo_helpers.py to fix CodeQL URL warnings
- Fix import sorting via ruff auto-fix
- Remove unused datetime import in test_insights_helpers.py

https://claude.ai/code/session_01KhAhJKpEoqCzmWzcALSfW6

Author: claude

app/src/components/SpecTabs.test.tsx

@@ -17,7 +17,7 @@ vi.mock('../constants', () => ({
 beforeEach(() => {
   vi.restoreAllMocks();
   // Mock fetch globally - return tag counts
-  global.fetch = vi.fn().mockResolvedValue({
+  globalThis.fetch = vi.fn().mockResolvedValue({
     ok: true,
     json: () =>
       Promise.resolve({
@@ -362,7 +362,7 @@ describe('SpecTabs', () => {
     expect(screen.getByText('scatter')).toBeInTheDocument();
 
     // Fetch is mocked for tag counts (may be called if cache is empty)
-    expect(global.fetch).toBeDefined();
+    expect(globalThis.fetch).toBeDefined();
   });
 
   // -------------------------------------------------------
@@ -409,15 +409,18 @@ describe('SpecTabs', () => {
   it('fires onTrackEvent and navigates on tag click', async () => {
     const user = userEvent.setup();
     const onTrackEvent = vi.fn();
-    // Mock window.location.href setter
+    // Mock window.location.href setter to prevent jsdom navigation errors.
+    // Use configurable: true so the property can be redefined if needed.
     const hrefSetter = vi.fn();
     Object.defineProperty(window, 'location', {
       value: { href: '' },
       writable: true,
+      configurable: true,
     });
     Object.defineProperty(window.location, 'href', {
       set: hrefSetter,
       get: () => '',
+      configurable: true,
     });
 
     render(

app/src/utils/filters-extended.test.ts

@@ -1,7 +1,5 @@
-import { describe, it, expect, vi } from 'vitest';
+import { describe, it, expect } from 'vitest';
 import {
-  getCounts,
-  getSelectedValuesForCategory,
   getAvailableValues,
   getAvailableValuesForGroup,
   getSearchResults,

tests/unit/api/test_analytics_extended.py

@@ -4,13 +4,7 @@
 Covers edge cases and additional platform patterns.
 """
 
-import pytest
-
-from api.analytics import (
-    PLATFORM_PATTERNS,
-    _detect_whatsapp_variant,
-    detect_platform,
-)
+from api.analytics import PLATFORM_PATTERNS, _detect_whatsapp_variant, detect_platform
 
 
 class TestDetectWhatsappVariant:

tests/unit/api/test_insights_helpers.py

@@ -5,16 +5,9 @@
 that don't require database or HTTP setup.
 """
 
-from datetime import datetime, timezone
+from datetime import timezone
 
-import pytest
-
-from api.routers.insights import (
-    _collect_impl_tags,
-    _flatten_tags,
-    _parse_iso,
-    _score_bucket,
-)
+from api.routers.insights import _collect_impl_tags, _flatten_tags, _parse_iso, _score_bucket
 
 
 class TestScoreBucket:

tests/unit/api/test_plots_helpers.py

@@ -6,8 +6,6 @@
 
 from unittest.mock import MagicMock
 
-import pytest
-
 from api.routers.plots import (
     _build_cache_key,
     _build_impl_lookup,

tests/unit/api/test_schemas.py

@@ -4,8 +4,6 @@
 Validates schema creation, defaults, and serialization.
 """
 
-import pytest
-
 from api.schemas import (
     FilterCountsResponse,
     FilteredPlotsResponse,

tests/unit/api/test_seo_helpers.py

@@ -7,8 +7,6 @@
 from datetime import datetime
 from unittest.mock import MagicMock
 
-import pytest
-
 from api.routers.seo import BOT_HTML_TEMPLATE, _build_sitemap_xml, _lastmod
 
 
@@ -36,11 +34,11 @@ def test_empty_specs(self) -> None:
         result = _build_sitemap_xml([])
         assert '<?xml version="1.0"' in result
         assert "<urlset" in result
-        assert "https://pyplots.ai/" in result
-        assert "https://pyplots.ai/catalog" in result
-        assert "https://pyplots.ai/mcp" in result
-        assert "https://pyplots.ai/legal" in result
-        assert "https://pyplots.ai/stats" in result
+        assert "<loc>https://pyplots.ai/</loc>" in result
+        assert "<loc>https://pyplots.ai/catalog</loc>" in result
+        assert "<loc>https://pyplots.ai/mcp</loc>" in result
+        assert "<loc>https://pyplots.ai/legal</loc>" in result
+        assert "<loc>https://pyplots.ai/stats</loc>" in result
         assert "</urlset>" in result
 
     def test_spec_with_impls(self) -> None:
@@ -141,8 +139,9 @@ def test_template_has_required_meta_tags(self) -> None:
         assert "Test Description" in result
 
     def test_template_has_canonical(self) -> None:
+        url = "https://pyplots.ai/"
         result = BOT_HTML_TEMPLATE.format(
-            title="t", description="d", image="i", url="https://pyplots.ai/"
+            title="t", description="d", image="i", url=url
         )
         assert 'rel="canonical"' in result
-        assert "https://pyplots.ai/" in result
+        assert url in result

tests/unit/automation/scripts/test_sync_helpers.py

@@ -4,13 +4,7 @@
 Focuses on _validate_quality_score, _parse_markdown_section, and _validate_spec_id.
 """
 
-import pytest
-
-from automation.scripts.sync_to_postgres import (
-    _parse_markdown_section,
-    _validate_quality_score,
-    _validate_spec_id,
-)
+from automation.scripts.sync_to_postgres import _parse_markdown_section, _validate_quality_score, _validate_spec_id
 
 
 class TestValidateQualityScore:

tests/unit/core/database/test_repositories.py

@@ -7,12 +7,11 @@
 import pytest
 from sqlalchemy.ext.asyncio import AsyncSession
 
-from core.database.models import Impl, Library, Spec
+from core.database.models import Library, Spec
 from core.database.repositories import (
     IMPL_UPDATABLE_FIELDS,
     LIBRARY_UPDATABLE_FIELDS,
     SPEC_UPDATABLE_FIELDS,
-    BaseRepository,
     ImplRepository,
     LibraryRepository,
     SpecRepository,

tests/unit/core/test_config_resolve.py

@@ -17,7 +17,7 @@ class TestResolveModel:
     @pytest.fixture
     def settings(self) -> Settings:
         """Create a Settings instance with default model mappings."""
-        with patch.dict("os.environ", {}, clear=False):
+        with patch.dict("os.environ", {}, clear=True):
             return Settings(
                 cli_model_claude_small="claude-haiku",
                 cli_model_claude_medium="claude-sonnet",
@@ -50,24 +50,24 @@ def test_gemini_medium(self, settings: Settings) -> None:
 
     def test_unknown_cli_returns_tier(self) -> None:
         """Unknown CLI should return the tier unchanged (pass-through)."""
-        with patch.dict("os.environ", {}, clear=False):
+        with patch.dict("os.environ", {}, clear=True):
             s = Settings()
             assert s.resolve_model("unknown-cli", "small") == "small"
 
     def test_unknown_tier_returns_tier(self) -> None:
         """Unknown tier should return the tier unchanged (pass-through)."""
-        with patch.dict("os.environ", {}, clear=False):
+        with patch.dict("os.environ", {}, clear=True):
             s = Settings()
             assert s.resolve_model("claude", "xlarge") == "xlarge"
 
     def test_unknown_cli_and_tier(self) -> None:
-        with patch.dict("os.environ", {}, clear=False):
+        with patch.dict("os.environ", {}, clear=True):
             s = Settings()
             assert s.resolve_model("unknown", "unknown") == "unknown"
 
     def test_exact_model_name_passthrough(self) -> None:
         """When tier is an exact model name, it's returned as-is."""
-        with patch.dict("os.environ", {}, clear=False):
+        with patch.dict("os.environ", {}, clear=True):
             s = Settings()
             result = s.resolve_model("claude", "claude-3-opus-20240229")
             assert result == "claude-3-opus-20240229"