fix: update plot request templates and validation checks

- Modify title format to include spec ID in plot update requests
- Update documentation for title formatting and dropdown descriptions
- Refine validation checks to skip update requests with existing spec IDs

Author: MarkusNeusinger

.github/ISSUE_TEMPLATE/plot-update.yml

@@ -1,6 +1,6 @@
 name: Plot Update
 description: Request updates or regeneration of an existing plot
-title: "[update] "
+title: "[spec-id] [update] "
 labels: ["plot-request", "update"]
 body:
   - type: markdown
@@ -11,25 +11,18 @@ body:
         Use this form to update or regenerate an existing plot.
 
         **Title Format:**
-        - `[update] scatter-basic` → Regenerate all 9 libraries
-        - `[update:seaborn] scatter-basic` → Regenerate only seaborn
+        - `[scatter-basic] [update] Regenerate` → Regenerate all 9 libraries
+        - `[scatter-basic] [update:seaborn] Fix colors` → Regenerate only seaborn
 
-        After submitting, a maintainer will add the `approved` label to trigger regeneration.
+        Replace `[spec-id]` in the title with the actual spec ID (e.g., `scatter-basic`).
 
-  - type: input
-    id: spec_id
-    attributes:
-      label: Spec ID
-      description: "The spec ID of the plot to update (will be appended to title)"
-      placeholder: "scatter-basic"
-    validations:
-      required: true
+        After submitting, a maintainer will add the `approved` label to trigger regeneration.
 
   - type: dropdown
     id: target_library
     attributes:
       label: Target Library (optional)
-      description: Update only a specific library, or leave empty for all
+      description: Update only a specific library, or leave empty for all. If you select a specific library, change [update] to [update:library] in the title.
       options:
         - All libraries
         - matplotlib
@@ -50,11 +43,10 @@ body:
       label: Type of Update
       description: What kind of change is this?
       options:
-        - Regenerate (use current spec)
+        - Regenerate (use current spec with new code style)
         - Spec Update (describe changes below)
         - Bug Fix (plot doesn't render correctly)
         - Visual Improvement (styling, colors, layout)
-        - Feature Addition (new parameter, option)
     validations:
       required: true
 

.github/workflows/bot-validate-request.yml

@@ -49,21 +49,24 @@ jobs:
             exit 0
           fi
 
-          # Check 2: Must not already have spec ID in title
-          # Spec ID format: [lowercase-with-hyphens] at the beginning, NOT [update...]
-          # Valid spec-id: [scatter-basic], [line-timeseries-multi]
-          # NOT spec-id: [update], [update:matplotlib], [Update:...]
+          # Check 2: Skip update requests (they already have spec-id)
+          HAS_UPDATE="${{ contains(github.event.issue.labels.*.name, 'update') }}"
+          if [[ "$HAS_UPDATE" == "true" ]]; then
+            echo "::notice::Skipping: Update request (spec-id already in title)"
+            echo "should_run=false" >> $GITHUB_OUTPUT
+            exit 0
+          fi
+
+          # Check 3: Must not already have spec ID in title
+          # Spec ID format: [lowercase-with-hyphens] at the beginning
           if [[ "$ISSUE_TITLE" =~ ^\[[a-z0-9-]+\] ]]; then
             FIRST_BRACKET=$(echo "$ISSUE_TITLE" | grep -oP '^\[\K[a-z0-9-]+(?=\])' || echo "")
-            # Skip only if it's a valid spec-id (not an update marker)
-            if [[ -n "$FIRST_BRACKET" && ! "$FIRST_BRACKET" =~ ^update ]]; then
-              echo "::notice::Skipping: Issue title already has spec ID: $FIRST_BRACKET"
-              echo "should_run=false" >> $GITHUB_OUTPUT
-              exit 0
-            fi
+            echo "::notice::Skipping: Issue title already has spec ID: $FIRST_BRACKET"
+            echo "should_run=false" >> $GITHUB_OUTPUT
+            exit 0
           fi
 
-          # Check 3: For labeled events, only trigger when plot-request label is added
+          # Check 4: For labeled events, only trigger when plot-request label is added
           if [[ "$EVENT_ACTION" == "labeled" && "$LABEL_NAME" != "plot-request" ]]; then
             echo "::notice::Skipping: Labeled event but not plot-request label"
             echo "should_run=false" >> $GITHUB_OUTPUT

.github/workflows/gen-create-spec.yml

@@ -60,7 +60,7 @@ jobs:
             echo "is_update=true" >> $GITHUB_OUTPUT
             echo "::notice::This is an update request"
 
-            # Extract target library from title [update:library] or empty for all
+            # Extract target library from title [spec-id] [update:library] or empty for all
             if [[ "$ISSUE_TITLE" =~ \[update:([a-z]+)\] ]]; then
               TARGET_LIB="${BASH_REMATCH[1]}"
               echo "target_library=$TARGET_LIB" >> $GITHUB_OUTPUT
@@ -120,13 +120,11 @@ jobs:
             SPEC_ID=$(echo "$COMMENTS" | grep -oP '\*\*Existing Spec:\*\* `\K[a-z0-9-]+(?=`)' | tail -1 || echo "")
           fi
 
-          # Fallback: extract from title if in brackets [spec-id]
-          # Must be at the beginning and NOT an update marker
+          # Fallback: extract from title - spec-id is always first bracket
+          # Format: [spec-id] ... or [spec-id] [update] ... or [spec-id] [update:lib] ...
           if [ -z "$SPEC_ID" ]; then
-            FIRST_BRACKET=$(echo "$ISSUE_TITLE" | grep -oP '^\[\K[a-z0-9-]+(?=\])' || echo "")
-            # Only use if it's not an update marker
-            if [[ -n "$FIRST_BRACKET" && ! "$FIRST_BRACKET" =~ ^update ]]; then
-              SPEC_ID="$FIRST_BRACKET"
+            if [[ "$ISSUE_TITLE" =~ ^\[([a-z0-9-]+)\] ]]; then
+              SPEC_ID="${BASH_REMATCH[1]}"
             fi
           fi