feat: enhance workflow for implementation generation

- Add pending label before dispatching workflow
- Implement retry mechanism for dispatching with exponential backoff
- Ensure implementations directory exists for new specifications
- Improve failure handling with automatic retries and comments

Author: MarkusNeusinger

.github/workflows/bulk-generate.yml

@@ -169,26 +169,71 @@ jobs:
             echo "::warning::$SPEC_YAML not found"
           fi
 
+      - name: Add pending label before dispatch
+        if: steps.spec.outputs.issue_number != ''
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          ISSUE: ${{ steps.spec.outputs.issue_number }}
+          LIBRARY: ${{ matrix.library }}
+        run: |
+          # Add pending label BEFORE dispatch so we can track what was attempted
+          gh issue edit "$ISSUE" --add-label "impl:${LIBRARY}:pending" 2>/dev/null || true
+
       - name: Trigger impl-generate for ${{ matrix.specification_id }} / ${{ matrix.library }}
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           ISSUE: ${{ steps.spec.outputs.issue_number }}
+          SPEC_ID: ${{ matrix.specification_id }}
+          LIBRARY: ${{ matrix.library }}
         run: |
-          echo "Triggering impl-generate.yml for ${{ matrix.specification_id }} / ${{ matrix.library }}"
-
-          # Run workflow with optional issue_number (avoid eval for security)
-          if [ -n "$ISSUE" ]; then
-            gh workflow run impl-generate.yml --repo ${{ github.repository }} \
-              -f specification_id="${{ matrix.specification_id }}" \
-              -f library="${{ matrix.library }}" \
-              -f issue_number="$ISSUE"
-          else
-            gh workflow run impl-generate.yml --repo ${{ github.repository }} \
-              -f specification_id="${{ matrix.specification_id }}" \
-              -f library="${{ matrix.library }}"
-          fi
+          echo "Triggering impl-generate.yml for ${SPEC_ID} / ${LIBRARY}"
+
+          # Retry dispatch up to 3 times with exponential backoff
+          MAX_RETRIES=3
+          RETRY_DELAY=5
+
+          for attempt in $(seq 1 $MAX_RETRIES); do
+            echo "Dispatch attempt $attempt/$MAX_RETRIES..."
+
+            # Run workflow with optional issue_number
+            if [ -n "$ISSUE" ]; then
+              gh workflow run impl-generate.yml --repo ${{ github.repository }} \
+                -f specification_id="${SPEC_ID}" \
+                -f library="${LIBRARY}" \
+                -f issue_number="$ISSUE" && DISPATCHED=true || DISPATCHED=false
+            else
+              gh workflow run impl-generate.yml --repo ${{ github.repository }} \
+                -f specification_id="${SPEC_ID}" \
+                -f library="${LIBRARY}" && DISPATCHED=true || DISPATCHED=false
+            fi
+
+            if [ "$DISPATCHED" = true ]; then
+              echo "::notice::Dispatched impl-generate for ${SPEC_ID} / ${LIBRARY} (issue: ${ISSUE:-none})"
+
+              # Wait and verify workflow appears in run list
+              sleep 5
+              FOUND=$(gh run list --workflow=impl-generate.yml --limit 10 --json displayTitle,createdAt \
+                --jq "[.[] | select(.displayTitle | test(\"${LIBRARY}\"))] | length")
 
-          echo "::notice::Dispatched impl-generate for ${{ matrix.specification_id }} / ${{ matrix.library }} (issue: ${ISSUE:-none})"
+              if [ "$FOUND" -gt 0 ]; then
+                echo "::notice::Verified workflow run started"
+                break
+              else
+                echo "::warning::Workflow dispatched but not found in run list, retrying..."
+              fi
+            fi
+
+            if [ "$attempt" -lt "$MAX_RETRIES" ]; then
+              echo "Waiting ${RETRY_DELAY}s before retry..."
+              sleep $RETRY_DELAY
+              RETRY_DELAY=$((RETRY_DELAY * 2))
+            fi
+          done
+
+          if [ "$DISPATCHED" != true ]; then
+            echo "::error::Failed to dispatch workflow after $MAX_RETRIES attempts"
+            exit 1
+          fi
 
   # ============================================================================
   # Summary

.github/workflows/impl-generate.yml

@@ -244,6 +244,14 @@ jobs:
             echo "is_regeneration=false" >> $GITHUB_OUTPUT
           fi
 
+      - name: Ensure implementations directory exists
+        env:
+          SPEC_ID: ${{ steps.inputs.outputs.specification_id }}
+        run: |
+          # Create implementations directory if it doesn't exist (for new specs)
+          mkdir -p "plots/${SPEC_ID}/implementations"
+          echo "::notice::Ensured implementations directory exists"
+
       - name: Run Claude Code to generate implementation
         id: claude
         continue-on-error: true
@@ -615,7 +623,7 @@ jobs:
           fi
 
       # ========================================================================
-      # Failure handling: Track failures and clean up labels
+      # Failure handling: Track failures via comments and auto-retry
       # ========================================================================
       - name: Handle generation failure
         if: failure() && steps.issue.outputs.number != ''
@@ -627,43 +635,60 @@ jobs:
         run: |
           echo "::notice::Handling generation failure for $LIBRARY/$SPEC_ID"
 
-          # Count previous failed generation runs for this spec/library
-          # Filter by both library AND spec ID to avoid counting unrelated failures
-          FAILURE_COUNT=$(gh run list \
-            --workflow=impl-generate.yml \
-            --limit 20 \
-            --json conclusion,displayTitle,createdAt \
-            -q "[.[] | select(.conclusion == \"failure\") | select(.displayTitle | (contains(\"$LIBRARY\") and contains(\"$SPEC_ID\")))] | length" \
-            2>/dev/null || echo "0")
+          # Count previous failures via hidden marker comments (more reliable than workflow runs)
+          MARKER="<!-- impl-fail:${SPEC_ID}:${LIBRARY} -->"
+          FAILURE_COUNT=$(gh api "repos/${{ github.repository }}/issues/${ISSUE}/comments" \
+            --jq "[.[] | select(.body | contains(\"$MARKER\"))] | length" 2>/dev/null || echo "0")
 
-          echo "::notice::Previous failures: $FAILURE_COUNT"
+          echo "::notice::Previous failures for ${LIBRARY}/${SPEC_ID}: $FAILURE_COUNT"
 
-          # After 3 failures, mark as failed (current run is the 3rd)
-          if [ "$FAILURE_COUNT" -ge 2 ]; then
-            echo "::warning::Marking $LIBRARY as failed after multiple generation failures"
+          # After 1 previous failure (= this is attempt 2) → mark as failed
+          if [ "$FAILURE_COUNT" -ge 1 ]; then
+            echo "::warning::Marking $LIBRARY as failed after 2 generation attempts"
 
             # Create failed label if needed
             gh label create "impl:${LIBRARY}:failed" --color "d73a4a" \
               --description "${LIBRARY} implementation failed" 2>/dev/null || true
 
-            # Remove stale labels and add failed (Fix #2: clean up duplicates)
+            # Remove stale labels and add failed
             gh issue edit "$ISSUE" \
               --remove-label "generate:${LIBRARY},impl:${LIBRARY}:pending" \
               --add-label "impl:${LIBRARY}:failed" 2>/dev/null || true
 
-            # Post failure comment
-            gh issue comment "$ISSUE" --body "## :x: ${LIBRARY} Failed
+            # Post final failure comment with marker
+            gh issue comment "$ISSUE" --body "${MARKER}
+          ## :x: ${LIBRARY} Failed (Attempt 2/2)
+
+          The **${LIBRARY}** implementation for \`${SPEC_ID}\` failed after 2 attempts.
 
-          The **${LIBRARY}** implementation for \`${SPEC_ID}\` failed after multiple attempts.
+          **Reason:** Claude Code failed to create the implementation file.
 
-          This may indicate that the library cannot implement this plot type natively.
+          To retry manually:
+          \`\`\`
+          gh workflow run impl-generate.yml -f specification_id=${SPEC_ID} -f library=${LIBRARY} -f issue_number=${ISSUE}
+          \`\`\`
 
           ---
           :robot: *[impl-generate](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }})*"
 
           else
-            # Not enough failures yet - just clean up stale generate label
-            # Keep pending label for retry
+            # First failure → post comment with marker and auto-retry
+            gh issue comment "$ISSUE" --body "${MARKER}
+          ## :warning: ${LIBRARY} Generation Failed (Attempt 1/2)
+
+          First attempt failed. Automatically retrying...
+
+          ---
+          :robot: *[impl-generate](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }})*"
+
+            # Clean up generate label before retry
             gh issue edit "$ISSUE" --remove-label "generate:${LIBRARY}" 2>/dev/null || true
-            echo "::notice::Cleaned up generate label, keeping pending for retry"
+
+            # Automatic retry via workflow_dispatch
+            gh workflow run impl-generate.yml \
+              -f specification_id="${SPEC_ID}" \
+              -f library="${LIBRARY}" \
+              -f issue_number="${ISSUE}"
+
+            echo "::notice::Triggered automatic retry for ${LIBRARY}/${SPEC_ID}"
           fi

prompts/workflow-prompts/impl-generate-claude.md

@@ -1,43 +1,45 @@
 # Generate Implementation
 
-You are generating the **{LIBRARY}** implementation for **{SPEC_ID}**.
+**YOUR PRIMARY TASK: Create a working Python plot implementation file.**
 
-**Regeneration:** {IS_REGENERATION}
+You MUST create: `plots/{SPEC_ID}/implementations/{LIBRARY}.py`
 
-## Step 1: Read required files
+This is NOT optional. The workflow will FAIL if this file does not exist after you finish.
 
-1. `prompts/plot-generator.md` - Base generation rules (IMPORTANT: Read the "Regeneration" section!)
-2. `prompts/default-style-guide.md` - Visual style requirements
-3. `prompts/quality-criteria.md` - Quality requirements
-4. `prompts/library/{LIBRARY}.md` - Library-specific rules
-5. `plots/{SPEC_ID}/specification.md` - The specification
+---
 
-## Step 1b: If Regeneration, read previous feedback
+**Variables:**
+- LIBRARY: {LIBRARY}
+- SPEC_ID: {SPEC_ID}
+- Regeneration: {IS_REGENERATION}
 
-If this is a regeneration ({IS_REGENERATION} == true):
+## Step 1: Read the rules (quickly)
 
-1. Read `plots/{SPEC_ID}/metadata/{LIBRARY}.yaml`
-   - Look at `review.strengths` (keep these aspects!)
-   - Look at `review.weaknesses` (fix these problems - decide HOW yourself)
-   - Look at `review.image_description` (understand what was generated visually)
-   - Look at `review.criteria_checklist` (see exactly which criteria failed)
-     - Focus on categories with low scores (e.g., visual_quality.score < visual_quality.max)
-     - Check items with `passed: false` - these need fixing
-     - VQ-XX items for visual issues
-     - SC-XX items for spec compliance
-     - CQ-XX items for code quality
-2. Read `plots/{SPEC_ID}/implementations/{LIBRARY}.py`
-   - Understand what was done before
-   - Keep what worked, fix what didn't
+Read these files to understand the requirements:
 
-## Step 2: Generate implementation
+1. `prompts/plot-generator.md` - Base generation rules
+2. `prompts/library/{LIBRARY}.md` - Library-specific rules (CRITICAL!)
+3. `plots/{SPEC_ID}/specification.md` - What to visualize
 
-Create: `plots/{SPEC_ID}/implementations/{LIBRARY}.py`
+Optional (if regenerating):
+- `plots/{SPEC_ID}/metadata/{LIBRARY}.yaml` - Previous review feedback
+- `plots/{SPEC_ID}/implementations/{LIBRARY}.py` - Previous implementation
+
+## Step 2: CREATE THE FILE (MANDATORY)
+
+**You MUST use the Write tool to create:**
+
+```
+plots/{SPEC_ID}/implementations/{LIBRARY}.py
+```
 
 The script MUST:
-- Save as `plot.png` in the current directory
+- Follow the KISS structure: imports → data → plot → save
+- Save output as `plot.png` in current directory
 - For interactive libraries (plotly, bokeh, altair, highcharts, pygal, letsplot): also save `plot.html`
 
+**DO NOT SKIP THIS STEP. The file MUST be created.**
+
 ## Step 3: Test and fix (up to 3 attempts)
 
 Run the implementation:
@@ -64,7 +66,17 @@ ruff format plots/{SPEC_ID}/implementations/{LIBRARY}.py
 ruff check --fix plots/{SPEC_ID}/implementations/{LIBRARY}.py
 ```
 
-## Step 6: Commit
+## Step 6: Verify file exists (CRITICAL)
+
+Before committing, verify the implementation file exists:
+
+```bash
+ls -la plots/{SPEC_ID}/implementations/{LIBRARY}.py
+```
+
+**If the file does NOT exist, you MUST go back to Step 2 and create it!**
+
+## Step 7: Commit
 
 ```bash
 git config user.name "github-actions[bot]"
@@ -74,8 +86,11 @@ git commit -m "feat({LIBRARY}): implement {SPEC_ID}"
 git push -u origin implementation/{SPEC_ID}/{LIBRARY}
 ```
 
-## Report result
+## Final Check
+
+Before finishing, confirm:
+1. ✅ `plots/{SPEC_ID}/implementations/{LIBRARY}.py` exists
+2. ✅ `plot.png` was generated successfully
+3. ✅ Changes were committed and pushed
 
-Print exactly one line:
-- `GENERATION_SUCCESS` - if everything worked
-- `GENERATION_FAILED: <reason>` - if it failed
+If any of these failed, DO NOT report success.