fix: address PR review — datetime handling, deferred fields, noqa stripping

- Fix _build_dashboard passing datetime to _parse_iso (expects str)
- Add ImplRepository.get_code() that only undefers code field
- Use get_code() in /specs/{id}/{lib}/code endpoint (avoids loading review fields)
- Apply strip_noqa_comments to POTD code response for consistency
- Fix docstring in get_by_id() to match actual undefer behavior
- Remove stale changelog/comparison references from module docstring
- Update tests to use get_code mock

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: MarkusNeusinger

api/routers/insights.py

@@ -5,8 +5,6 @@
 - Dashboard: Rich platform statistics and visualizations
 - Plot of the Day: Daily featured high-quality implementation
 - Related Plots: Tag-based similarity recommendations
-- Library Comparison: Head-to-head library analysis
-- Changelog: Recent additions and updates activity feed
 """
 
 from __future__ import annotations
@@ -24,6 +22,7 @@
 from core.constants import SUPPORTED_LIBRARIES
 from core.database import ImplRepository, SpecRepository
 from core.database.connection import get_db_context
+from core.utils import strip_noqa_comments
 
 
 router = APIRouter(prefix="/insights", tags=["insights"])
@@ -257,8 +256,8 @@ async def _build_dashboard(repo: SpecRepository, impl_repo: ImplRepository) -> D
                         )
                     )
 
-            # Timeline from generated_at
-            gen_dt = _parse_iso(impl.generated_at)
+            # Timeline from generated_at (datetime field, not string)
+            gen_dt = impl.generated_at
             if gen_dt:
                 monthly_counts[gen_dt.strftime("%Y-%m")] += 1
 
@@ -397,7 +396,7 @@ async def _build_potd(spec_repo: SpecRepository, impl_repo: ImplRepository) -> P
         quality_score=quality_score,
         preview_url=preview_url,
         image_description=full_impl.review_image_description if full_impl else None,
-        code=full_impl.code if full_impl else None,
+        code=strip_noqa_comments(full_impl.code) if full_impl and full_impl.code else None,
         date=today,
     )
 

api/routers/specs.py

@@ -143,7 +143,7 @@ async def get_impl_code(spec_id: str, library: str, db: AsyncSession = Depends(r
         return cached
 
     repo = ImplRepository(db)
-    impl = await repo.get_by_spec_and_library(spec_id, library)
+    impl = await repo.get_code(spec_id, library)
 
     if not impl or not impl.code:
         raise_not_found("Implementation code", f"{spec_id}/{library}")

core/database/repositories.py

@@ -114,9 +114,8 @@ class SpecRepository(BaseRepository[Spec]):
     async def get_by_id(self, spec_id: str) -> Optional[Spec]:
         """Get a spec by ID with implementations and library info.
 
-        Note: Heavy deferred fields (code, review_criteria_checklist) are NOT loaded.
-        Use ImplRepository.get_by_spec_and_library() for full impl details.
-        review_image_description IS loaded (small, needed for detail display).
+        Loads review_image_description and review_criteria_checklist (needed for detail display).
+        Code and tested remain deferred — use /specs/{id}/{lib}/code for code.
         """
         result = await self.session.execute(
             select(Spec)
@@ -231,6 +230,13 @@ async def get_by_library(self, library_id: str) -> list[Impl]:
         )
         return list(result.scalars().all())
 
+    async def get_code(self, spec_id: str, library_id: str) -> Optional[Impl]:
+        """Get a specific implementation with only the code field undeferred."""
+        result = await self.session.execute(
+            select(Impl).where(Impl.spec_id == spec_id, Impl.library_id == library_id).options(undefer(Impl.code))
+        )
+        return result.scalar_one_or_none()
+
     async def get_by_spec_and_library(self, spec_id: str, library_id: str) -> Optional[Impl]:
         """Get a specific implementation by spec and library (includes all deferred fields)."""
         result = await self.session.execute(

tests/unit/api/test_routers.py

@@ -1584,7 +1584,7 @@ def test_code_with_db(self, client: TestClient) -> None:
         mock_impl = MagicMock()
         mock_impl.code = "import matplotlib.pyplot as plt\nplt.plot([1,2,3])"
         mock_impl_repo = MagicMock()
-        mock_impl_repo.get_by_spec_and_library = AsyncMock(return_value=mock_impl)
+        mock_impl_repo.get_code = AsyncMock(return_value=mock_impl)
 
         with (
             patch(DB_CONFIG_PATCH, return_value=True),
@@ -1602,7 +1602,7 @@ def test_code_with_db(self, client: TestClient) -> None:
     def test_code_not_found(self, client: TestClient) -> None:
         """Code endpoint should return 404 when implementation not found."""
         mock_impl_repo = MagicMock()
-        mock_impl_repo.get_by_spec_and_library = AsyncMock(return_value=None)
+        mock_impl_repo.get_code = AsyncMock(return_value=None)
 
         with (
             patch(DB_CONFIG_PATCH, return_value=True),