Commit 4137a5e
committed
fix(impl-merge): clean up stale impl:LIB:failed label on successful merge
When impl-generate.yml fails (e.g. environment setup error) it tags the
parent issue with `impl:LIB:failed`. A subsequent successful retry merges
through impl-merge.yml, which previously only removed `impl:LIB:pending`
and added `impl:LIB:done` — leaving the stale `:failed` label in place.
Observed on #3802 (skewt-logp-atmospheric/makie): first generate failed
on Project.toml setup (added :failed), retry succeeded after PR #7614
(added :done), and the issue closed with both labels for the same lib.
The close-check counts in this same workflow use if/elif (done wins over
failed) so totals weren't actually broken — but the labels were a lie.
Other readers (DB sync, UI, future workflows) could trust them less
charitably, so remove the stale label at the canonical merge point.1 parent e4a69c6 commit 4137a5e
1 file changed
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
292 | 292 | | |
293 | 293 | | |
294 | 294 | | |
295 | | - | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
296 | 300 | | |
297 | 301 | | |
| 302 | + | |
298 | 303 | | |
299 | 304 | | |
300 | 305 | | |
| |||
0 commit comments