Skip to content

Commit 551ea5c

Browse files
fix: address Copilot review feedback
- Fix docstring: sync engine, not async (connection.py) - Add missing docstring params for spec_lookup and impl_lookup (plots.py) - Remove duplicate columndatasource from techniques (bokeh.yaml) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 4016f0f commit 551ea5c

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed

api/routers/plots.py

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,18 @@ def _calculate_contextual_counts(filtered_images: list[dict], spec_id_to_tags: d
198198
def _calculate_or_counts(
199199
filter_groups: list[dict], all_images: list[dict], spec_id_to_tags: dict, spec_lookup: dict, impl_lookup: dict
200200
) -> list[dict]:
201-
"""Calculate OR preview counts for each filter group."""
201+
"""Calculate OR preview counts for each filter group.
202+
203+
Args:
204+
filter_groups: List of filter group dictionaries defining categories and values.
205+
all_images: List of image dictionaries to evaluate against the filter groups.
206+
spec_id_to_tags: Mapping from specification IDs to their associated tag metadata.
207+
spec_lookup: Mapping from specification IDs to full specification metadata.
208+
impl_lookup: Mapping from (spec_id, library) pairs to implementation-level tags.
209+
210+
Returns:
211+
List of dicts, one per filter group, mapping values to matching image counts.
212+
"""
202213
or_counts: list[dict] = []
203214

204215
for group_idx, group in enumerate(filter_groups):

core/database/connection.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ def get_conn():
7171

7272

7373
def _create_direct_engine():
74-
"""Create async engine using direct DATABASE_URL connection."""
74+
"""Create sync engine using direct DATABASE_URL connection."""
7575
url = DATABASE_URL
7676

7777
# Ensure async driver

plots/arc-basic/metadata/bokeh.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ impl_tags:
1616
techniques:
1717
- custom-legend
1818
- bezier-curves
19-
- columndatasource
2019
- html-export
2120
patterns:
2221
- data-generation

0 commit comments

Comments
 (0)