chore(altair): update quality score 82 and review feedback for sankey-basic

Author: github-actions[bot]

plots/sankey-basic/implementations/python/altair.py

@@ -1,7 +1,7 @@
 """ anyplot.ai
 sankey-basic: Basic Sankey Diagram
 Library: altair 6.1.0 | Python 3.13.13
-Quality: 85/100 | Updated: 2026-04-30
+Quality: 82/100 | Updated: 2026-04-30
 """
 
 import os

plots/sankey-basic/metadata/python/altair.yaml

@@ -2,7 +2,7 @@ library: altair
 language: python
 specification_id: sankey-basic
 created: '2025-12-23T19:50:52Z'
-updated: '2026-04-30T09:06:47Z'
+updated: '2026-04-30T09:24:49Z'
 generated_by: claude-sonnet
 workflow_run: 25156438466
 issue: 810
@@ -12,137 +12,113 @@ preview_url_light: https://storage.googleapis.com/anyplot-images/plots/sankey-ba
 preview_url_dark: https://storage.googleapis.com/anyplot-images/plots/sankey-basic/python/altair/plot-dark.png
 preview_html_light: https://storage.googleapis.com/anyplot-images/plots/sankey-basic/python/altair/plot-light.html
 preview_html_dark: https://storage.googleapis.com/anyplot-images/plots/sankey-basic/python/altair/plot-dark.html
-quality_score: 85
+quality_score: 82
 review:
   strengths:
-  - Custom Sankey implementation in Altair (no native Sankey support) using smooth
-    bezier/smoothstep curves — technically impressive
-  - 'Source node colors follow Okabe-Ito canonical order: Coal=#009E73, Gas=#D55E00,
-    Nuclear=#0072B2, Renewable=#CC79A7'
-  - 'Both renders are fully theme-adaptive with correct backgrounds (#FAF8F1 light
-    / #1A1A17 dark) and readable text in both themes'
-  - All font sizes explicitly set (title=28px, subtitle=20px, node labels=20px bold,
-    legend title=18px, legend labels=16px)
-  - 'Correct title format: ''sankey-basic · altair · anyplot.ai'' with descriptive
-    subtitle'
-  - Interactive tooltips on nodes and HTML export alongside PNG — leverages Altair's
-    interactive capabilities
-  - Realistic energy flow domain (Coal/Gas/Nuclear/Renewable → Residential/Commercial/Industrial/Transport)
-    with plausible values
-  - Layer composition with alt.layer() is idiomatic Altair; detail encoding correctly
-    groups flow polygons per source-target pair
+  - Correct Okabe-Ito palette (positions 1-4) for source node and flow colors
+  - Smooth smoothstep bezier S-curves create a professional Sankey appearance
+  - Theme-adaptive chrome (background, text, legend) works correctly in both light
+    and dark renders with no dark-on-dark failures
+  - Complete spec compliance including correct title format and interactive HTML export
+  - Clean, deterministic, readable code with no functions or classes
+  - Tooltips on nodes provide interactive value information
   weaknesses:
-  - 'Target node colors (#7EC8C8, #A8D8A8, #E8C07A, #C8A8E8) are custom hexes not
-    in Okabe-Ito palette — use Okabe-Ito positions 5–7 (#E69F00, #56B4E9, #F0E442)
-    and adaptive neutral for the 4 target nodes'
-  - No visual emphasis or storytelling — the dominant flow (Coal→Industrial, value=45)
-    is the single largest flow but receives no special treatment; no focal point guides
-    the viewer
-  - 'Node ordering creates maximum crossing: sorting source/target nodes to minimize
-    crossings would improve readability'
-  - Top-gap between subtitle and diagram is slightly large (top_margin=100 creates
-    visible dead space under the subtitle text); compact layout would better utilize
-    canvas
-  - 'DE-03 is default (data displayed, no hierarchy): adding subtle emphasis to the
-    largest flow or highlighting one key insight would elevate storytelling'
+  - Transport label clipped at bottom canvas edge — only 'T' visible; increase bottom_margin
+    from 60 to 100 or reduce height scale factor from 0.85 to 0.80
+  - 'Target node colors are custom hex values (#7EC8C8, #A8D8A8, #E8C07A, #C8A8E8)
+    not from the Okabe-Ito palette; replace with positions 5-7 (#E69F00, #56B4E9,
+    #F0E442) plus adaptive neutral'
+  - Legend shows line symbols (colored dashes) for what are actually filled area marks;
+    consider a custom legend solution
   image_description: |-
     Light render (plot-light.png):
-      Background: Warm off-white (#FAF8F1) — correct, not pure white.
-      Chrome: Title "sankey-basic · altair · anyplot.ai" in bold dark text; subtitle "Energy Flow from Sources to Sectors" in dark-gray. All text clearly readable against the light background. Node labels (Renewable, Nuclear, Gas, Coal on left; Transport, Industrial, Commercial, Residential on right) are 20px bold dark text — fully readable.
-      Data: Source nodes colored Okabe-Ito canonical order: Coal (#009E73 green-teal, bottom-left), Gas (#D55E00 orange, middle-left), Nuclear (#0072B2 blue, upper-middle-left), Renewable (#CC79A7 pink-purple, top-left). Flow bands inherit source colors with opacity=0.55. Target nodes use custom colors: Residential=teal, Commercial=light-green, Industrial=warm-tan, Transport=light-purple. Legend box (bottom-right) shows "Energy Source" with correct color swatches. Significant flow crossing visible in the center (X-pattern) — inherent to full mesh of 4 sources × 4 targets.
-      Legibility verdict: PASS — all text dark on off-white, no contrast failures.
+      Background: Warm off-white (#FAF8F1) - correct
+      Chrome: Title "sankey-basic · altair · anyplot.ai" (28px, dark ink) and subtitle "Energy Flow from Sources to Sectors" (20px) are clearly readable. Node labels for Coal, Nuclear, Gas, Renewable (left), Industrial, Commercial, Residential (right) are readable in dark ink at 20px bold. Legend text readable at 16px. ISSUE: Transport target label is clipped - only "T" is visible at the bottom-right canvas edge.
+      Data: Four sources use Okabe-Ito positions 1-4: Coal=#009E73 (green), Gas=#D55E00 (vermillion), Nuclear=#0072B2 (blue), Renewable=#CC79A7 (pink-purple). Flow bands are semi-transparent (opacity=0.55) colored by source. Target node colors (#7EC8C8, #A8D8A8, #E8C07A, #C8A8E8) are custom non-Okabe-Ito values. Smooth S-curves connect sources to targets.
+      Legibility verdict: PASS (with caveat: Transport label clipped to "T")
 
     Dark render (plot-dark.png):
-      Background: Near-black (#1A1A17) — correct, not pure black.
-      Chrome: Title and subtitle in light/white text — readable. Node labels in light (#F0EFE8) text — no dark-on-dark failures detected. Legend box has dark elevated background (#242420) with light-colored text.
-      Data: Data colors are the same underlying hex values as light render (theme-constant). Due to opacity=0.55 alpha-blending on flow bands, colors appear visually darker/more saturated against the dark background (expected blending behavior). Node rectangles remain clearly visible with INK_SOFT borders. Flow crossing pattern identical to light render.
-      Legibility verdict: PASS — all text is light on dark, no dark-on-dark failures.
+      Background: Near-black (#1A1A17) - correct
+      Chrome: Title and subtitle rendered in light ink (#F0EFE8), clearly readable against dark background. Node labels rendered in INK token (light) - readable for all visible nodes. Legend box uses elevated dark fill (#242420) with subtle border. No dark-on-dark failures for any visible text elements.
+      Data: Flow band colors are identical to light render - Coal=#009E73, Gas=#D55E00, Nuclear=#0072B2, Renewable=#CC79A7. Data colors unchanged, only chrome flips between themes. Same Transport label clipping issue persists.
+      Legibility verdict: PASS (with caveat: Transport label clipped to "T", same as light render)
   criteria_checklist:
     visual_quality:
-      score: 27
+      score: 24
       max: 30
       items:
       - id: VQ-01
         name: Text Legibility
-        score: 8
+        score: 7
         max: 8
         passed: true
-        comment: 'All font sizes explicitly set: title=28px, subtitle=20px, node labels=20px
-          bold, legend title=18px, legend labels=16px. Readable in both themes.'
+        comment: Font sizes excellent (title 28, labels 20, legend 16); Transport
+          label clipped to 'T'
       - id: VQ-02
         name: No Overlap
-        score: 6
+        score: 5
         max: 6
         passed: true
-        comment: No overlapping text. Source and target labels positioned outside
-          the crossing flow area. Legend well-placed.
+        comment: Labels well-spaced; Transport truncation counts as partial failure
       - id: VQ-03
         name: Element Visibility
         score: 5
         max: 6
         passed: true
-        comment: All elements visible. Flow bands opacity=0.55 appropriate for crossing
-          flows. Individual flow tracing is difficult due to the X-crossing pattern,
-          but this is inherent to the full-mesh Sankey layout.
+        comment: All flows visible at opacity=0.55; Transport node very small but
+          present
       - id: VQ-04
         name: Color Accessibility
         score: 2
         max: 2
         passed: true
-        comment: Okabe-Ito source colors are CVD-safe. Flow bands distinguishable
-          by hue + position.
+        comment: Okabe-Ito for sources; labels provide text identification
       - id: VQ-05
         name: Layout & Canvas
-        score: 3
+        score: 2
         max: 4
-        passed: true
-        comment: Diagram fills ~80% of canvas horizontally and ~75% vertically. Slight
-          dead-space gap between subtitle and diagram start due to top_margin=100.
+        passed: false
+        comment: Transport node partially clipped at bottom canvas edge; label shows
+          only 'T'
       - id: VQ-06
         name: Axis Labels & Title
         score: 2
         max: 2
         passed: true
-        comment: Correct title format. Node names serve as labels. Subtitle describes
-          the flow context. No traditional axes needed for Sankey.
+        comment: Correct title format; descriptive subtitle; axes hidden appropriately
       - id: VQ-07
         name: Palette Compliance
         score: 1
         max: 2
         passed: false
-        comment: 'Source flow colors follow Okabe-Ito canonical order (Coal=#009E73,
-          Gas=#D55E00, Nuclear=#0072B2, Renewable=#CC79A7). However, target node colors
-          (#7EC8C8, #A8D8A8, #E8C07A, #C8A8E8) are custom hexes not in Okabe-Ito palette.
-          Both backgrounds are theme-correct. Partial compliance.'
+        comment: 'Source colors use Okabe-Ito positions 1-4 correctly. Target node
+          colors (#7EC8C8, #A8D8A8, #E8C07A, #C8A8E8) are custom hex values not from
+          Okabe-Ito'
     design_excellence:
-      score: 11
+      score: 12
       max: 20
       items:
       - id: DE-01
         name: Aesthetic Sophistication
         score: 5
         max: 8
         passed: true
-        comment: Above generic default — building a full Sankey from scratch in Altair
-          demonstrates thoughtful implementation. Good color scheme for sources. Target
-          node custom colors reduce coherence. Not publication-ready.
+        comment: Professional manual Sankey via Altair primitives; smooth bezier S-curves;
+          styled legend
       - id: DE-02
         name: Visual Refinement
         score: 4
         max: 6
         passed: true
-        comment: No grid lines (appropriate), no spines, smooth bezier curves, opacity-blended
-          flows, node borders with INK_SOFT. Good refinement above defaults but top
-          gap reduces polish.
+        comment: No axes/spines appropriate; no grid; clean background; good node
+          padding
       - id: DE-03
         name: Data Storytelling
-        score: 2
+        score: 3
         max: 6
-        passed: false
-        comment: Data displayed correctly but no visual hierarchy or emphasis. The
-          largest single flow (Coal→Industrial, value=45) is not highlighted. Crossing
-          node order creates a maximally complex visual without guiding the viewer
-          to any insight.
+        passed: true
+        comment: Clear energy source->sector flow narrative; width encoding communicates
+          magnitudes; no explicit emphasis on dominant pathways
     spec_compliance:
       score: 15
       max: 15
@@ -152,54 +128,51 @@ review:
         score: 5
         max: 5
         passed: true
-        comment: Correct Sankey diagram with proportional flow band widths and smooth
-          curves.
+        comment: Correct Sankey diagram with nodes and proportional flow bands
       - id: SC-02
         name: Required Features
         score: 4
         max: 4
         passed: true
-        comment: Source nodes, target nodes, proportional values, distinct source
-          colors, link opacity for crossings — all present.
+        comment: Source nodes, target nodes, proportional widths, distinct source
+          colors, link opacity, no circular flows
       - id: SC-03
         name: Data Mapping
         score: 3
         max: 3
         passed: true
-        comment: All 12 flows correctly represented. Band widths proportional to values.
-          All nodes visible.
+        comment: Energy flow sources to sectors; values mapped to band widths
       - id: SC-04
         name: Title & Legend
         score: 3
         max: 3
         passed: true
-        comment: 'Title: ''sankey-basic · altair · anyplot.ai'' correct. Legend shows
-          Energy Source with correct Okabe-Ito color swatches.'
+        comment: Title matches spec-id·library·anyplot.ai format; legend labels match
+          source categories
     data_quality:
-      score: 15
+      score: 14
       max: 15
       items:
       - id: DQ-01
         name: Feature Coverage
-        score: 6
+        score: 5
         max: 6
         passed: true
-        comment: 'Shows all Sankey aspects: multiple sources, multiple targets, varying
-          flow magnitudes, crossing flows, proportional node heights.'
+        comment: 12 flows across 4x4 source/target grid; Transport only receives one
+          flow limiting full coverage
       - id: DQ-02
         name: Realistic Context
         score: 5
         max: 5
         passed: true
-        comment: Real-world energy flow scenario (Coal/Gas/Nuclear/Renewable → Residential/Commercial/Industrial/Transport).
-          Neutral domain.
+        comment: Energy distribution domain realistic and neutral; Coal->Industrial
+          largest is plausible
       - id: DQ-03
         name: Appropriate Scale
         score: 4
         max: 4
         passed: true
-        comment: Values 10–45 units. Coal→Industrial (45) being the dominant industrial
-          flow is realistic. Proportions plausible for energy sector distribution.
+        comment: 12 flows within 5-50 recommended range; values 10-45 sensible
     code_quality:
       score: 10
       max: 10
@@ -209,36 +182,32 @@ review:
         score: 3
         max: 3
         passed: true
-        comment: 'Linear structure: imports → data → geometry computation → chart
-          layers → save. No functions or classes.'
+        comment: No functions or classes; clean procedural flow
       - id: CQ-02
         name: Reproducibility
         score: 2
         max: 2
         passed: true
-        comment: Fully deterministic — all data is hardcoded, no random generation
-          needed.
+        comment: No random elements; fully deterministic
       - id: CQ-03
         name: Clean Imports
         score: 2
         max: 2
         passed: true
-        comment: Only os, altair, pandas imported and all are used.
+        comment: Only os, altair, pandas - all used
       - id: CQ-04
         name: Code Elegance
         score: 2
         max: 2
         passed: true
-        comment: The bezier geometry computation (~100 lines) is appropriate complexity
-          for a custom Sankey in a library with no native Sankey support. No fake
-          UI elements.
+        comment: Complexity justified by manual Sankey construction; no fake UI
       - id: CQ-05
         name: Output & API
         score: 1
         max: 1
         passed: true
-        comment: Saves plot-{THEME}.png (scale_factor=3.0) and plot-{THEME}.html.
-          Correct altair API.
+        comment: Saves plot-{THEME}.png (scale_factor=3.0) and plot-{THEME}.html;
+          current Altair 6.x API
     library_mastery:
       score: 7
       max: 10
@@ -248,29 +217,26 @@ review:
         score: 4
         max: 5
         passed: true
-        comment: Uses alt.layer() composition, detail encoding for flow grouping,
-          mark_line(filled=True) for polygon fills, mark_rect for nodes, mark_text
-          for labels — all idiomatic Altair patterns.
+        comment: Correct alt.layer() composition, proper encoding types (Q/N), alt.Title
+          with subtitle, configure_legend/configure_view
       - id: LM-02
         name: Distinctive Features
         score: 3
         max: 5
         passed: true
-        comment: detail:N encoding for grouping polygon paths, alt.layer() multi-layer
-          composition, interactive tooltips on nodes, dual PNG+HTML output — several
-          Altair-distinctive features leveraged.
-  verdict: REJECTED
+        comment: Interactive HTML export, node tooltips, layer composition of primitive
+          marks to build custom chart type
+  verdict: APPROVED
 impl_tags:
   dependencies: []
   techniques:
-  - html-export
   - layer-composition
-  - hover-tooltips
   - bezier-curves
+  - hover-tooltips
+  - html-export
   patterns:
-  - data-generation
+  - groupby-aggregation
   - iteration-over-groups
   dataprep: []
   styling:
   - alpha-blending
-  - minimal-chrome