Skip to content

Commit 6fea914

Browse files
feat(cache): extend cache duration for uploaded assets
- Increase cache duration to 7 days for PNG, thumbnail, and HTML uploads - Update cache settings in impl-generate.yml, impl-merge.yml, and impl-repair.yml
1 parent d24ed36 commit 6fea914

3 files changed

Lines changed: 7 additions & 7 deletions

File tree

.github/workflows/impl-generate.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -534,7 +534,7 @@ jobs:
534534
535535
# Upload PNG (with watermark)
536536
if [ -f "$IMPL_DIR/plot.png" ]; then
537-
gsutil -h "Cache-Control:public, max-age=86400" cp "$IMPL_DIR/plot.png" "${STAGING_PATH}/plot.png"
537+
gsutil -h "Cache-Control:public, max-age=604800" cp "$IMPL_DIR/plot.png" "${STAGING_PATH}/plot.png"
538538
gsutil acl ch -u AllUsers:R "${STAGING_PATH}/plot.png" 2>/dev/null || true
539539
echo "png_url=${PUBLIC_URL}/plot.png" >> $GITHUB_OUTPUT
540540
echo "uploaded=true" >> $GITHUB_OUTPUT
@@ -545,15 +545,15 @@ jobs:
545545
546546
# Upload thumbnail
547547
if [ -f "$IMPL_DIR/plot_thumb.png" ]; then
548-
gsutil -h "Cache-Control:public, max-age=86400" cp "$IMPL_DIR/plot_thumb.png" "${STAGING_PATH}/plot_thumb.png"
548+
gsutil -h "Cache-Control:public, max-age=604800" cp "$IMPL_DIR/plot_thumb.png" "${STAGING_PATH}/plot_thumb.png"
549549
gsutil acl ch -u AllUsers:R "${STAGING_PATH}/plot_thumb.png" 2>/dev/null || true
550550
echo "thumb_url=${PUBLIC_URL}/plot_thumb.png" >> $GITHUB_OUTPUT
551551
echo "::notice::Uploaded thumbnail"
552552
fi
553553
554554
# Upload HTML (interactive libraries)
555555
if [ -f "$IMPL_DIR/plot.html" ]; then
556-
gsutil -h "Cache-Control:public, max-age=86400" cp "$IMPL_DIR/plot.html" "${STAGING_PATH}/plot.html"
556+
gsutil -h "Cache-Control:public, max-age=604800" cp "$IMPL_DIR/plot.html" "${STAGING_PATH}/plot.html"
557557
gsutil acl ch -u AllUsers:R "${STAGING_PATH}/plot.html" 2>/dev/null || true
558558
echo "html_url=${PUBLIC_URL}/plot.html" >> $GITHUB_OUTPUT
559559
fi

.github/workflows/impl-merge.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ jobs:
201201
PRODUCTION="gs://pyplots-images/plots/${SPEC_ID}/${LIBRARY}"
202202
203203
# Copy from staging to production
204-
gsutil -m -h "Cache-Control:public, max-age=86400" cp -r "${STAGING}/*" "${PRODUCTION}/" 2>/dev/null || echo "No staging files to promote"
204+
gsutil -m -h "Cache-Control:public, max-age=604800" cp -r "${STAGING}/*" "${PRODUCTION}/" 2>/dev/null || echo "No staging files to promote"
205205
206206
# Make production files public
207207
gsutil -m acl ch -r -u AllUsers:R "${PRODUCTION}/" 2>/dev/null || true

.github/workflows/impl-repair.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,17 +187,17 @@ jobs:
187187
gcloud auth activate-service-account --key-file=/tmp/gcs-key.json
188188
189189
if [ -f "$IMPL_DIR/plot.png" ]; then
190-
gsutil -h "Cache-Control:public, max-age=86400" cp "$IMPL_DIR/plot.png" "${STAGING_PATH}/plot.png"
190+
gsutil -h "Cache-Control:public, max-age=604800" cp "$IMPL_DIR/plot.png" "${STAGING_PATH}/plot.png"
191191
gsutil acl ch -u AllUsers:R "${STAGING_PATH}/plot.png" 2>/dev/null || true
192192
fi
193193
194194
if [ -f "$IMPL_DIR/plot_thumb.png" ]; then
195-
gsutil -h "Cache-Control:public, max-age=86400" cp "$IMPL_DIR/plot_thumb.png" "${STAGING_PATH}/plot_thumb.png"
195+
gsutil -h "Cache-Control:public, max-age=604800" cp "$IMPL_DIR/plot_thumb.png" "${STAGING_PATH}/plot_thumb.png"
196196
gsutil acl ch -u AllUsers:R "${STAGING_PATH}/plot_thumb.png" 2>/dev/null || true
197197
fi
198198
199199
if [ -f "$IMPL_DIR/plot.html" ]; then
200-
gsutil -h "Cache-Control:public, max-age=86400" cp "$IMPL_DIR/plot.html" "${STAGING_PATH}/plot.html"
200+
gsutil -h "Cache-Control:public, max-age=604800" cp "$IMPL_DIR/plot.html" "${STAGING_PATH}/plot.html"
201201
gsutil acl ch -u AllUsers:R "${STAGING_PATH}/plot.html" 2>/dev/null || true
202202
fi
203203

0 commit comments

Comments
 (0)