fix(letsplot): address review feedback for column-stratigraphic

Attempt 1/3 - fixes based on AI review

Author: github-actions[bot]

plots/column-stratigraphic/implementations/letsplot.py

@@ -1,4 +1,4 @@
-""" pyplots.ai
+"""pyplots.ai
 column-stratigraphic: Stratigraphic Column with Lithology Patterns
 Library: letsplot 4.9.0 | Python 3.14.3
 Quality: 80/100 | Created: 2026-03-15
@@ -62,78 +62,216 @@
 layers["xmin"] = 0.0
 layers["xmax"] = 1.0
 
-# Lithology color palette (earthy geological tones)
+# Lithology color palette (improved contrast between types)
 lithology_colors = {
-    "Sandstone": "#F2CC6B",
-    "Shale": "#8B8B8B",
-    "Limestone": "#5B9BD5",
-    "Siltstone": "#B5A48B",
+    "Sandstone": "#F5D76E",
+    "Shale": "#7A7A7A",
+    "Limestone": "#6BAED6",
+    "Siltstone": "#C4956A",
     "Conglomerate": "#D4726A",
 }
 lithology_order = ["Sandstone", "Shale", "Limestone", "Siltstone", "Conglomerate"]
 
-# Build label data: formation names (right) + age labels (left)
-label_rows = []
+# Generate lithology pattern overlay data
+pattern_segments = []  # For line-based patterns (shale dashes, limestone bricks)
+pattern_points = []  # For dot-based patterns (sandstone stipple, conglomerate circles)
+
+for _, row in layers.iterrows():
+    top, bottom, lith = row["top"], row["bottom"], row["lithology"]
+    thickness = bottom - top
+    margin = 0.03
+
+    if lith == "Shale":
+        # Horizontal dashes
+        spacing = 4
+        n_lines = max(1, int(thickness / spacing))
+        for i in range(n_lines):
+            y = top + (i + 0.5) * thickness / n_lines
+            for x_start in [0.05, 0.25, 0.5, 0.75]:
+                pattern_segments.append({"x": x_start, "y": y, "xend": x_start + 0.15, "yend": y})
+
+    elif lith == "Limestone":
+        # Brick pattern: horizontal lines + offset vertical lines
+        spacing = 5
+        n_rows = max(1, int(thickness / spacing))
+        for i in range(n_rows + 1):
+            y = top + margin + i * (thickness - 2 * margin) / max(n_rows, 1)
+            if top + margin <= y <= bottom - margin:
+                pattern_segments.append({"x": 0.02, "y": y, "xend": 0.98, "yend": y})
+        for i in range(n_rows):
+            y_top = top + margin + i * (thickness - 2 * margin) / max(n_rows, 1)
+            y_bot = top + margin + (i + 1) * (thickness - 2 * margin) / max(n_rows, 1)
+            offset = 0.25 if i % 2 == 0 else 0.0
+            for vx in [0.25 + offset, 0.5 + offset, 0.75 + offset]:
+                if 0.02 < vx < 0.98:
+                    pattern_segments.append({"x": vx, "y": y_top, "xend": vx, "yend": y_bot})
+
+    elif lith == "Sandstone":
+        # Stipple dots
+        spacing_y = 4
+        spacing_x = 0.12
+        n_rows = max(1, int(thickness / spacing_y))
+        for i in range(n_rows):
+            y = top + (i + 0.5) * thickness / n_rows
+            offset = 0.06 if i % 2 == 0 else 0.0
+            x = 0.08 + offset
+            while x < 0.95:
+                pattern_points.append({"x": x, "y": y, "shape": "dot"})
+                x += spacing_x
+
+    elif lith == "Siltstone":
+        # Short random-angle dashes (tilted segments)
+        spacing_y = 5
+        n_rows = max(1, int(thickness / spacing_y))
+        for i in range(n_rows):
+            y = top + (i + 0.5) * thickness / n_rows
+            offset = 0.08 if i % 2 == 0 else 0.0
+            for x in [0.12 + offset, 0.32 + offset, 0.52 + offset, 0.72 + offset]:
+                if x < 0.95:
+                    pattern_segments.append({"x": x, "y": y - 0.8, "xend": x + 0.06, "yend": y + 0.8})
+
+    elif lith == "Conglomerate":
+        # Circles (larger dots)
+        spacing_y = 6
+        n_rows = max(1, int(thickness / spacing_y))
+        for i in range(n_rows):
+            y = top + (i + 0.5) * thickness / n_rows
+            offset = 0.1 if i % 2 == 0 else 0.0
+            for x in [0.15 + offset, 0.4 + offset, 0.65 + offset]:
+                if x < 0.95:
+                    pattern_points.append({"x": x, "y": y, "shape": "circle"})
+
+pattern_seg_df = pd.DataFrame(pattern_segments) if pattern_segments else None
+pattern_dot_df = pd.DataFrame([p for p in pattern_points if p["shape"] == "dot"]) if pattern_points else None
+pattern_circle_df = pd.DataFrame([p for p in pattern_points if p["shape"] == "circle"]) if pattern_points else None
+
+# Formation labels (right side)
+form_labels = []
 for _, row in layers.iterrows():
     mid_depth = (row["top"] + row["bottom"]) / 2
-    label_rows.append({"x": 1.12, "y": mid_depth, "label": row["formation"]})
+    form_labels.append({"x": 1.08, "y": mid_depth, "label": row["formation"]})
+form_df = pd.DataFrame(form_labels)
 
+# Age labels (left side) with bracket indicators
 age_spans = {"Triassic": (0, 35), "Jurassic": (35, 110), "Cretaceous": (110, 195), "Paleogene": (195, 260)}
+age_labels = []
+age_brackets = []
 for age_name, (age_top, age_bottom) in age_spans.items():
-    label_rows.append({"x": -0.12, "y": (age_top + age_bottom) / 2, "label": age_name})
-
-labels_df = pd.DataFrame(label_rows)
+    age_labels.append({"x": -0.18, "y": (age_top + age_bottom) / 2, "label": age_name})
+    # Bracket lines on left
+    age_brackets.append({"x": -0.06, "y": age_top + 1, "xend": -0.06, "yend": age_bottom - 1})
+    age_brackets.append({"x": -0.06, "y": age_top + 1, "xend": -0.03, "yend": age_top + 1})
+    age_brackets.append({"x": -0.06, "y": age_bottom - 1, "xend": -0.03, "yend": age_bottom - 1})
+age_df = pd.DataFrame(age_labels)
+bracket_df = pd.DataFrame(age_brackets)
 
 # Age boundary dashed lines
 age_boundary_depths = [35, 110, 195]
 boundaries_df = pd.DataFrame(
     {"x": [-0.02] * 3, "y": age_boundary_depths, "xend": [1.02] * 3, "yend": age_boundary_depths}
 )
 
-# Plot
+# Unconformity wavy line at Jurassic/Cretaceous boundary (110m)
+wavy_x = []
+wavy_y = []
+n_waves = 20
+for i in range(n_waves + 1):
+    xi = i / n_waves
+    yi = 110 + 1.5 * (1 if (i % 2 == 0) else -1)
+    wavy_x.append(xi)
+    wavy_y.append(yi)
+wavy_df = pd.DataFrame({"x": wavy_x, "y": wavy_y})
+
+# Plot assembly
 plot = (
     ggplot()
+    # Layer rectangles with interactive tooltips
     + geom_rect(
         aes(xmin="xmin", xmax="xmax", ymin="top", ymax="bottom", fill="lithology"),
         data=layers,
-        color="black",
-        size=0.8,
-        alpha=0.85,
+        color="#2C2C2C",
+        size=1.0,
+        alpha=0.8,
         tooltips=layer_tooltips()
         .line("@lithology")
         .line("Depth: @top\u2013@bottom m")
         .line("Thickness: @thickness m")
         .line("Formation: @formation")
         .line("Age: @age"),
     )
-    + geom_segment(
+)
+
+# Add pattern overlays
+if pattern_seg_df is not None and len(pattern_seg_df) > 0:
+    plot = plot + geom_segment(
         aes(x="x", y="y", xend="xend", yend="yend"),
-        data=boundaries_df,
-        linetype="dashed",
-        color="#888888",
-        size=0.7,
+        data=pattern_seg_df,
+        color="#3C3C3C",
+        size=0.4,
+        alpha=0.55,
         show_legend=False,
     )
-    + geom_text(aes(x="x", y="y", label="label"), data=labels_df, size=10, color="#333333")
+
+if pattern_dot_df is not None and len(pattern_dot_df) > 0:
+    plot = plot + geom_point(
+        aes(x="x", y="y"), data=pattern_dot_df, color="#5C4A1E", size=1.2, alpha=0.5, shape=16, show_legend=False
+    )
+
+if pattern_circle_df is not None and len(pattern_circle_df) > 0:
+    plot = plot + geom_point(
+        aes(x="x", y="y"), data=pattern_circle_df, color="#6B3A3A", size=4, alpha=0.45, shape=1, show_legend=False
+    )
+
+# Unconformity wavy line at 110m
+plot = plot + geom_line(aes(x="x", y="y"), data=wavy_df, color="#C44E52", size=1.2, show_legend=False)
+
+# Age boundary dashed lines (non-unconformity)
+non_unconformity_boundaries = pd.DataFrame(
+    {"x": [-0.02, -0.02], "y": [35, 195], "xend": [1.02, 1.02], "yend": [35, 195]}
+)
+plot = plot + geom_segment(
+    aes(x="x", y="y", xend="xend", yend="yend"),
+    data=non_unconformity_boundaries,
+    linetype="dashed",
+    color="#666666",
+    size=0.6,
+    show_legend=False,
+)
+
+# Age brackets (left side)
+plot = plot + geom_segment(
+    aes(x="x", y="y", xend="xend", yend="yend"), data=bracket_df, color="#444444", size=0.6, show_legend=False
+)
+
+# Formation labels (right side)
+plot = plot + geom_text(aes(x="x", y="y", label="label"), data=form_df, size=12, color="#2C2C2C", hjust=0)
+
+# Age labels (left side)
+plot = plot + geom_text(aes(x="x", y="y", label="label"), data=age_df, size=13, color="#2C2C2C", fontface="italic")
+
+# Scales and theme
+plot = (
+    plot
     + scale_fill_manual(values=lithology_colors, name="Lithology", limits=lithology_order)
     + scale_y_reverse()
-    + scale_x_continuous(limits=[-0.35, 1.85])
+    + scale_x_continuous(limits=[-0.35, 1.65])
     + labs(title="column-stratigraphic \u00b7 letsplot \u00b7 pyplots.ai", y="Depth (m)", x="")
     + theme_minimal()
     + theme(
-        plot_title=element_text(size=24, face="bold"),
-        axis_title_y=element_text(size=20),
+        plot_title=element_text(size=24, face="bold", color="#1A1A1A"),
+        axis_title_y=element_text(size=20, color="#333333"),
         axis_title_x=element_blank(),
-        axis_text_y=element_text(size=16),
+        axis_text_y=element_text(size=16, color="#444444"),
         axis_text_x=element_blank(),
         axis_ticks_x=element_blank(),
         legend_title=element_text(size=16, face="bold"),
         legend_text=element_text(size=14),
         legend_position="bottom",
         panel_grid_major_x=element_blank(),
         panel_grid_minor_x=element_blank(),
-        panel_grid_major_y=element_line(size=0.3, color="#dddddd"),
+        panel_grid_major_y=element_line(size=0.3, color="#E0E0E0"),
         panel_grid_minor_y=element_blank(),
+        plot_background=element_rect(color="white", fill="white"),
     )
     + ggsize(1600, 900)
 )