Skip to content

Commit abcf604

Browse files
chore(altair): update quality score 87 and review feedback for column-stratigraphic
1 parent 2af9147 commit abcf604

2 files changed

Lines changed: 70 additions & 73 deletions

File tree

plots/column-stratigraphic/implementations/altair.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
"""pyplots.ai
1+
""" pyplots.ai
22
column-stratigraphic: Stratigraphic Column with Lithology Patterns
33
Library: altair 6.0.0 | Python 3.14.3
4-
Quality: 85/100 | Created: 2026-03-15
4+
Quality: 87/100 | Created: 2026-03-15
55
"""
66

77
import altair as alt

plots/column-stratigraphic/metadata/altair.yaml

Lines changed: 68 additions & 71 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
library: altair
22
specification_id: column-stratigraphic
33
created: '2026-03-15T22:59:28Z'
4-
updated: '2026-03-15T23:25:10Z'
4+
updated: '2026-03-15T23:37:05Z'
55
generated_by: claude-opus-4-5-20251101
66
workflow_run: 23121198787
77
issue: 4573
@@ -10,39 +10,38 @@ library_version: 6.0.0
1010
preview_url: https://storage.googleapis.com/pyplots-images/plots/column-stratigraphic/altair/plot.png
1111
preview_thumb: https://storage.googleapis.com/pyplots-images/plots/column-stratigraphic/altair/plot_thumb.png
1212
preview_html: https://storage.googleapis.com/pyplots-images/plots/column-stratigraphic/altair/plot.html
13-
quality_score: 85
13+
quality_score: 87
1414
review:
1515
strengths:
16-
- Excellent geological context with real Grand Canyon formation data and accurate
17-
stratigraphy
18-
- Strong visual hierarchy with bold formations, italic ages, and red unconformity
19-
focal points
20-
- Clean declarative Altair code with well-organized layer composition
21-
- Good use of age brackets and unconformity markers to organize the geological narrative
22-
- Professional color palette with colorblind-safe distinct lithology colors
16+
- Excellent spec compliance with all required features including unconformity markers,
17+
age brackets, and 5 distinct lithology patterns
18+
- Highly realistic data using real Grand Canyon formation names with correct geological
19+
ordering
20+
- Professional design with custom color palette, typography hierarchy, and clean
21+
visual refinement
22+
- Red unconformity lines create effective focal points that tell a geological story
23+
- Clean, well-organized code with deterministic data
2324
weaknesses:
24-
- Text-based pattern approximations are less distinct than true geological hatching
25-
(Altair limitation)
26-
- Column width could be wider to better fill the horizontal canvas space
27-
- Minor visual crowding near unconformity labels where they overlap with pattern
28-
text
29-
- Thickness variation in layers is modest (15-25 m range)
30-
image_description: 'The plot displays a vertical stratigraphic column of the Grand
31-
Canyon sedimentary section spanning Cambrian to Permian periods. Ten geological
32-
layers are shown as colored horizontal rectangles stacked vertically with depth
33-
increasing downward (0-200 m). Colors used: yellow (Sandstone), gray (Shale),
34-
blue (Limestone), purple (Siltstone), orange (Conglomerate). Each layer has text-based
35-
pattern overlays approximating geological symbols (dots for sandstone, dashes
36-
for shale, squares for limestone, dashes for siltstone, circles for conglomerate).
37-
Formation names (Cedar Mesa Fm, Organ Rock Fm, White Rim Fm, De Chelly Fm, Coconino
38-
Fm, Hermit Fm, Supai Group, Redwall Fm, Temple Butte Fm, Muav Fm) are labeled
39-
to the right in bold. Thickness annotations (15 m, 20 m, 25 m) appear on the far
40-
right in italic gray. Age period labels (Permian, Pennsylvanian, Mississippian,
41-
Devonian, Cambrian) are on the left with vertical bracket lines. Two red dashed
42-
unconformity lines appear at depths 110 and 155 m with labels. The title reads
43-
"column-stratigraphic · altair · pyplots.ai" with subtitle "Grand Canyon Sedimentary
44-
Section — Cambrian to Permian". A horizontal legend at the bottom shows all 5
45-
lithology types. Background is light gray.'
25+
- Pattern text overlays could be more prominent — some are subtle against their
26+
background colors
27+
- Minor crowding near unconformity labels and adjacent formation names at 120m and
28+
170m depth
29+
- Some canvas space at edges could be better utilized
30+
image_description: 'The plot displays a vertical stratigraphic column representing
31+
a Grand Canyon sedimentary section spanning Cambrian to Permian periods (0–200m
32+
depth). Ten rectangular layers are stacked vertically with depth increasing downward.
33+
Each layer is colored by lithology: yellow (Sandstone), gray (Shale), blue (Limestone),
34+
purple (Siltstone), and orange (Conglomerate). Text-based pattern overlays differentiate
35+
lithologies (dots for sandstone, dashes for shale, squares for limestone, small
36+
dashes for siltstone, circles for conglomerate). Formation names (Cedar Mesa Fm,
37+
Organ Rock Fm, White Rim Fm, etc.) appear in bold black text to the right of the
38+
column. Thickness values in italic gray text appear on the far right. Age period
39+
labels (Permian, Pennsylvanian, Mississippian, Devonian, Cambrian) in bold italic
40+
dark text appear on the left with vertical bracket lines connecting them to their
41+
respective layer ranges. Two red dashed unconformity lines cross the column at
42+
120m and 170m with red labels. A horizontal legend at the bottom shows all 5 lithology
43+
types. Title reads "column-stratigraphic · altair · pyplots.ai" with subtitle.
44+
Background is light off-white.'
4645
criteria_checklist:
4746
visual_quality:
4847
score: 26
@@ -53,42 +52,40 @@ review:
5352
score: 7
5453
max: 8
5554
passed: true
56-
comment: All font sizes explicitly set (title 28pt, axis 18/22pt, formation
57-
17pt, age 18pt, patterns 16pt). Thickness labels at 13pt slightly small
58-
but readable.
55+
comment: All font sizes explicitly set (title 28pt, labels 18-22pt, ticks
56+
16-18pt). Pattern overlay text slightly less crisp.
5957
- id: VQ-02
6058
name: No Overlap
6159
score: 5
6260
max: 6
6361
passed: true
64-
comment: Generally clean layout, minor crowding near unconformity label at
65-
depth 110 with Supai Group pattern dashes.
62+
comment: Minor crowding near unconformity labels and adjacent formation names
63+
around 120m and 170m depth.
6664
- id: VQ-03
6765
name: Element Visibility
6866
score: 5
6967
max: 6
7068
passed: true
71-
comment: Layer rectangles well-sized with clear boundaries. Text-based patterns
72-
visible but inherently less distinct than true hatching.
69+
comment: Layer rectangles clear. Pattern text overlays visible but some patterns
70+
subtle against background.
7371
- id: VQ-04
7472
name: Color Accessibility
7573
score: 4
7674
max: 4
7775
passed: true
78-
comment: Five distinct colorblind-safe colors with good contrast.
76+
comment: Custom colorblind-safe palette with 5 well-differentiated colors.
7977
- id: VQ-05
8078
name: Layout & Canvas
8179
score: 3
8280
max: 4
8381
passed: true
84-
comment: Good vertical space usage. Column width narrow relative to full canvas;
85-
some horizontal space underutilized.
82+
comment: Good proportions but some empty space at left and right edges.
8683
- id: VQ-06
8784
name: Axis Labels & Title
8885
score: 2
8986
max: 2
9087
passed: true
91-
comment: Y-axis labeled Depth (m) with units. X-axis appropriately hidden.
88+
comment: Depth (m) with units on y-axis.
9289
design_excellence:
9390
score: 14
9491
max: 20
@@ -98,78 +95,78 @@ review:
9895
score: 6
9996
max: 8
10097
passed: true
101-
comment: Custom geological color palette, good typography hierarchy, custom
102-
background. Clearly above defaults with professional geological chart appearance.
98+
comment: Custom geological color palette, professional typography hierarchy,
99+
clean dark borders, thoughtful subtitle.
103100
- id: DE-02
104101
name: Visual Refinement
105102
score: 4
106103
max: 6
107104
passed: true
108-
comment: View stroke removed, subtle dashed grid, clean background, bracket
109-
tick marks for age groups.
105+
comment: View stroke removed, custom background, subtle dashed grid, clean
106+
domain styling.
110107
- id: DE-03
111108
name: Data Storytelling
112109
score: 4
113110
max: 6
114111
passed: true
115-
comment: Grand Canyon stratigraphy through time. Red unconformity markers
116-
create focal points. Age brackets organize the narrative.
112+
comment: Red unconformity lines create focal points. Age brackets group formations
113+
logically. Visual hierarchy guides viewer.
117114
spec_compliance:
118-
score: 14
115+
score: 15
119116
max: 15
120117
items:
121118
- id: SC-01
122119
name: Plot Type
123120
score: 5
124121
max: 5
125122
passed: true
126-
comment: Correct vertical stratigraphic column with stacked rectangular layers.
123+
comment: Correct stratigraphic column with stacked rectangular blocks and
124+
lithology differentiation.
127125
- id: SC-02
128126
name: Required Features
129-
score: 3
127+
score: 4
130128
max: 4
131129
passed: true
132-
comment: All major features present. Patterns are text approximations rather
133-
than true geological hatching (Altair limitation).
130+
comment: All spec features present including patterns, labels, age groups,
131+
unconformities.
134132
- id: SC-03
135133
name: Data Mapping
136134
score: 3
137135
max: 3
138136
passed: true
139-
comment: Depth correctly mapped to Y-axis with proper reversal. Layers properly
140-
positioned.
137+
comment: Depth axis correctly oriented 0-200m increasing downward.
141138
- id: SC-04
142139
name: Title & Legend
143140
score: 3
144141
max: 3
145142
passed: true
146-
comment: Title format correct. Legend shows all 5 lithology types with correct
143+
comment: Title format correct. Legend shows all 5 lithology types with matching
147144
labels.
148145
data_quality:
149-
score: 14
146+
score: 15
150147
max: 15
151148
items:
152149
- id: DQ-01
153150
name: Feature Coverage
154-
score: 5
151+
score: 6
155152
max: 6
156153
passed: true
157-
comment: Shows 5 lithology types, varying thicknesses, 5 geological periods,
158-
2 unconformities, 10 layers.
154+
comment: Shows all 5 lithology types, varying thicknesses, multiple geological
155+
periods, unconformities.
159156
- id: DQ-02
160157
name: Realistic Context
161158
score: 5
162159
max: 5
163160
passed: true
164-
comment: Grand Canyon stratigraphy with real formation names and correct geological
161+
comment: Grand Canyon section with real formation names and correct geological
165162
ages.
166163
- id: DQ-03
167164
name: Appropriate Scale
168165
score: 4
169166
max: 4
170167
passed: true
171-
comment: Depths 0-200 m realistic. Layer thicknesses 15-25 m sensible. Geologically
172-
accurate.
168+
comment: Depths 0-200m reasonable. Thicknesses 10-35m appropriate. Ages in
169+
correct stratigraphic order.
173170
code_quality:
174171
score: 10
175172
max: 10
@@ -179,13 +176,13 @@ review:
179176
score: 3
180177
max: 3
181178
passed: true
182-
comment: Linear structure with no functions or classes.
179+
comment: Clean imports-data-plot-save flow. No functions or classes.
183180
- id: CQ-02
184181
name: Reproducibility
185182
score: 2
186183
max: 2
187184
passed: true
188-
comment: Fully deterministic data.
185+
comment: Fully deterministic hardcoded data.
189186
- id: CQ-03
190187
name: Clean Imports
191188
score: 2
@@ -197,13 +194,13 @@ review:
197194
score: 2
198195
max: 2
199196
passed: true
200-
comment: Clean, well-organized code with creative text mark pattern approximation.
197+
comment: Well-structured with appropriate complexity. Creative pattern approach.
201198
- id: CQ-05
202199
name: Output & API
203200
score: 1
204201
max: 1
205202
passed: true
206-
comment: Saves as plot.png and plot.html with current API.
203+
comment: Saves as plot.png with scale_factor=3.0 and plot.html.
207204
library_mastery:
208205
score: 7
209206
max: 10
@@ -213,15 +210,15 @@ review:
213210
score: 4
214211
max: 5
215212
passed: true
216-
comment: 'Good declarative patterns: layer composition, transform_calculate,
217-
proper encoding types, tooltip encoding.'
213+
comment: Good declarative grammar usage with mark_rect, mark_text, mark_rule,
214+
layered composition, transform_calculate.
218215
- id: LM-02
219216
name: Distinctive Features
220217
score: 3
221218
max: 5
222219
passed: true
223-
comment: Uses declarative layer composition, transform_calculate, interactive
224-
tooltips in HTML, dual PNG/HTML output.
220+
comment: Declarative layer composition, transform_calculate, native tooltips,
221+
dual HTML+PNG export.
225222
verdict: REJECTED
226223
impl_tags:
227224
dependencies: []

0 commit comments

Comments
 (0)