chore(altair): update quality score 86 and review feedback for heatmap-cohort-retention

Author: github-actions[bot]

plots/heatmap-cohort-retention/implementations/altair.py

@@ -1,7 +1,7 @@
-"""pyplots.ai
+""" pyplots.ai
 heatmap-cohort-retention: Cohort Retention Heatmap
-Library: altair | Python 3.13
-Quality: pending | Created: 2026-03-16
+Library: altair 6.0.0 | Python 3.14.3
+Quality: 86/100 | Created: 2026-03-16
 """
 
 import altair as alt

plots/heatmap-cohort-retention/metadata/altair.yaml

@@ -1,10 +1,7 @@
-# Per-library metadata for altair implementation of heatmap-cohort-retention
-# Auto-generated by impl-generate.yml
-
 library: altair
 specification_id: heatmap-cohort-retention
 created: '2026-03-16T20:46:10Z'
-updated: '2026-03-16T20:46:10Z'
+updated: '2026-03-16T20:50:10Z'
 generated_by: claude-opus-4-5-20251101
 workflow_run: 23165007983
 issue: 4570
@@ -13,7 +10,215 @@ library_version: 6.0.0
 preview_url: https://storage.googleapis.com/pyplots-images/plots/heatmap-cohort-retention/altair/plot.png
 preview_thumb: https://storage.googleapis.com/pyplots-images/plots/heatmap-cohort-retention/altair/plot_thumb.png
 preview_html: https://storage.googleapis.com/pyplots-images/plots/heatmap-cohort-retention/altair/plot.html
-quality_score: null
+quality_score: 86
 review:
-  strengths: []
-  weaknesses: []
+  strengths:
+  - Perfect spec compliance — all required features implemented correctly (triangular
+    shape, cell annotations, cohort sizes, color bar)
+  - Excellent data quality with realistic SaaS retention patterns and plausible cohort
+    sizes
+  - Clean, idiomatic Altair code with good use of layer composition and conditional
+    encoding
+  - Smart conditional text coloring (white on dark, dark on light) for readability
+  weaknesses:
+  - Design excellence could be improved — the plot looks like a well-configured default
+    rather than publication-quality
+  - No visual emphasis or storytelling to highlight interesting patterns
+  - Y-axis label font size (15pt) is slightly small relative to other text elements
+  image_description: 'The plot displays a triangular cohort retention heatmap using
+    a blue sequential colormap. The title "heatmap-cohort-retention · altair · pyplots.ai"
+    is centered at the top in large font. The y-axis labeled "Signup Cohort" shows
+    10 cohorts from "Jan 2024 (n=1,926)" to "Oct 2024 (n=1,266)" with cohort sizes
+    in parentheses. The x-axis labeled "Months Since Signup" shows "Month 0" through
+    "Month 9". Each cell contains a retention percentage value displayed in bold text
+    — white text on darker (high-retention) cells and dark gray text on lighter (low-retention)
+    cells. The triangular shape is correct: Jan 2024 has all 10 periods while Oct
+    2024 has only Month 0. Cells are separated by white borders. A vertical color
+    bar legend on the right shows "Retention %" ranging from 0 to 100. Period 0 is
+    always 100% (darkest blue), with realistic decay patterns across subsequent months.'
+  criteria_checklist:
+    visual_quality:
+      score: 28
+      max: 30
+      items:
+      - id: VQ-01
+        name: Text Legibility
+        score: 7
+        max: 8
+        passed: true
+        comment: Font sizes explicitly set throughout (title 28, axis titles 22, axis
+          labels 15-17, cell text 16). Y-axis labels at 15pt slightly small.
+      - id: VQ-02
+        name: No Overlap
+        score: 6
+        max: 6
+        passed: true
+        comment: No overlapping text anywhere
+      - id: VQ-03
+        name: Element Visibility
+        score: 6
+        max: 6
+        passed: true
+        comment: Cells well-sized with clear color differentiation and white borders
+      - id: VQ-04
+        name: Color Accessibility
+        score: 4
+        max: 4
+        passed: true
+        comment: Blues colormap is colorblind-safe with conditional text color for
+          readability
+      - id: VQ-05
+        name: Layout & Canvas
+        score: 3
+        max: 4
+        passed: true
+        comment: Good layout, triangular shape inherently leaves empty space in lower-right
+      - id: VQ-06
+        name: Axis Labels & Title
+        score: 2
+        max: 2
+        passed: true
+        comment: 'Descriptive labels: Months Since Signup, Signup Cohort'
+    design_excellence:
+      score: 11
+      max: 20
+      items:
+      - id: DE-01
+        name: Aesthetic Sophistication
+        score: 5
+        max: 8
+        passed: true
+        comment: Blues colormap well-chosen, white cell borders, conditional text
+          coloring. Above defaults but not publication-level.
+      - id: DE-02
+        name: Visual Refinement
+        score: 3
+        max: 6
+        passed: true
+        comment: View stroke removed, white cell separators. Some refinement but could
+          be further polished.
+      - id: DE-03
+        name: Data Storytelling
+        score: 3
+        max: 6
+        passed: true
+        comment: Triangular shape and color gradient guide the eye, but no explicit
+          focal point or emphasis on key insights.
+    spec_compliance:
+      score: 15
+      max: 15
+      items:
+      - id: SC-01
+        name: Plot Type
+        score: 5
+        max: 5
+        passed: true
+        comment: Correct triangular heatmap
+      - id: SC-02
+        name: Required Features
+        score: 4
+        max: 4
+        passed: true
+        comment: 'All spec features present: triangular shape, cell annotations, cohort
+          sizes, color bar'
+      - id: SC-03
+        name: Data Mapping
+        score: 3
+        max: 3
+        passed: true
+        comment: X=periods, Y=cohorts, correct mapping
+      - id: SC-04
+        name: Title & Legend
+        score: 3
+        max: 3
+        passed: true
+        comment: Title format correct, color bar legend labeled Retention %
+    data_quality:
+      score: 15
+      max: 15
+      items:
+      - id: DQ-01
+        name: Feature Coverage
+        score: 6
+        max: 6
+        passed: true
+        comment: Full retention decay, cohort variation, triangular shape, period
+          0 always 100%
+      - id: DQ-02
+        name: Realistic Context
+        score: 5
+        max: 5
+        passed: true
+        comment: Realistic SaaS monthly cohort retention with plausible user counts
+      - id: DQ-03
+        name: Appropriate Scale
+        score: 4
+        max: 4
+        passed: true
+        comment: Realistic retention values and cohort sizes
+    code_quality:
+      score: 10
+      max: 10
+      items:
+      - id: CQ-01
+        name: KISS Structure
+        score: 3
+        max: 3
+        passed: true
+        comment: 'Clean linear flow: imports, data, chart, save'
+      - id: CQ-02
+        name: Reproducibility
+        score: 2
+        max: 2
+        passed: true
+        comment: np.random.seed(42) set
+      - id: CQ-03
+        name: Clean Imports
+        score: 2
+        max: 2
+        passed: true
+        comment: All imports used
+      - id: CQ-04
+        name: Code Elegance
+        score: 2
+        max: 2
+        passed: true
+        comment: Clean, well-structured, appropriate complexity
+      - id: CQ-05
+        name: Output & API
+        score: 1
+        max: 1
+        passed: true
+        comment: Saves plot.png with scale_factor=3.0 and plot.html
+    library_mastery:
+      score: 7
+      max: 10
+      items:
+      - id: LM-01
+        name: Idiomatic Usage
+        score: 4
+        max: 5
+        passed: true
+        comment: 'Good declarative API usage: mark_rect + mark_text layering, proper
+          encoding types, alt.Scale/Axis'
+      - id: LM-02
+        name: Distinctive Features
+        score: 3
+        max: 5
+        passed: true
+        comment: Uses alt.condition for conditional text coloring, layer composition,
+          configure_view
+  verdict: REJECTED
+impl_tags:
+  dependencies: []
+  techniques:
+  - annotations
+  - layer-composition
+  - html-export
+  patterns:
+  - data-generation
+  - iteration-over-groups
+  dataprep: []
+  styling:
+  - custom-colormap
+  - edge-highlighting