Skip to content

Commit de7fcc4

Browse files
Fix inaccuracies in copilot-instructions.md based on review feedback
Co-authored-by: MarkusNeusinger <2921697+MarkusNeusinger@users.noreply.github.com>
1 parent b5aa105 commit de7fcc4

1 file changed

Lines changed: 7 additions & 6 deletions

File tree

.github/copilot-instructions.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ Examples: `scatter-basic`, `scatter-color-mapped`, `bar-grouped-horizontal`, `he
6868
- **`plots/{library}/{plot_type}/{spec_id}/{variant}.py`**: Library-specific implementations
6969
- **`core/`**: Shared business logic (database, repositories, config)
7070
- **`api/`**: FastAPI backend (routers, schemas, dependencies)
71-
- **`app/`**: Next.js frontend (React + TypeScript + Vite + MUI)
71+
- **`app/`**: React frontend (React 19 + TypeScript + Vite 7 + MUI 7)
7272
- **`rules/`**: Versioned rules for AI code generation and quality evaluation
7373
- **`tests/unit/`**: Unit tests mirroring source structure
7474
- **`docs/`**: Architecture and workflow documentation
@@ -96,9 +96,10 @@ Every implementation file should:
9696
1. Start with docstring describing spec ID, library, variant
9797
2. Define `create_plot()` function with type hints
9898
3. Validate inputs first (empty data, missing columns)
99-
4. Use sensible defaults (`figsize=(10, 6)`, `alpha=0.8`)
100-
5. Include grid for readability
101-
6. Return the Figure object
99+
4. Validate data types (numeric columns)
100+
5. Use sensible defaults (`figsize=(16, 9)`, `alpha=0.6`)
101+
6. Include grid for readability
102+
7. Return the Figure object
102103

103104
### Anti-Patterns to Avoid
104105

@@ -108,8 +109,8 @@ Every implementation file should:
108109

109110
## Tech Stack
110111

111-
- **Backend**: FastAPI, SQLAlchemy (async), PostgreSQL, Python 3.10+
112-
- **Frontend**: Next.js 14, TypeScript, Tailwind CSS, MUI 7
112+
- **Backend**: FastAPI, SQLAlchemy (async), PostgreSQL, Python 3.14+
113+
- **Frontend**: React 19, TypeScript, Vite 7, MUI 7
113114
- **Package Manager**: uv (Python), yarn (Node.js)
114115
- **Linting**: Ruff (Python)
115116

0 commit comments

Comments
 (0)