Skip to content

feat(plotly): implement area-basic#111

Merged
MarkusNeusinger merged 1 commit intomainfrom
auto/area-basic/plotly
Dec 1, 2025
Merged

feat(plotly): implement area-basic#111
MarkusNeusinger merged 1 commit intomainfrom
auto/area-basic/plotly

Conversation

@claude
Copy link
Copy Markdown
Contributor

@claude claude Bot commented Dec 1, 2025

Summary

Implements area-basic for plotly library.

Parent Issue: #99
Sub-Issue: #102
Attempt: 1/3

Implementation

  • plots/plotly/scatter/area-basic/default.py

Details

This implementation creates a basic area chart using plotly's go.Scatter trace with fill='tozeroy'.

Features

  • Full type hints for all parameters
  • Google-style docstring with Args, Returns, Raises, Example
  • Input validation (empty data, missing columns)
  • Clear error messages with context
  • Professional styling with:
    • Subtle grid (alpha=0.3)
    • Clean white background
    • Centered title
    • Proper axis labels
    • Hover information
  • 16:9 aspect ratio (1600x900)

Quality Criteria Met

  • Axes labeled clearly
  • Grid visible but subtle
  • Area fill visible but not overwhelming
  • Line at top clearly visible
  • No overlapping labels
  • Appropriate figure size
  • Type hints and validation present
  • Passes ruff linting

Test

source .venv/bin/activate
MPLBACKEND=Agg python plots/plotly/scatter/area-basic/default.py
# Output: Plot saved to plot.png

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 1, 2025

✅ Plot Tests Passed

Created with Python 3.14

Compatibility: 3.11 3.12 3.13

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 1, 2025

The author of this PR, claude[bot], is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at support@codecov.io with any questions.

@claude claude Bot added the ai-approved Quality OK, ready for merge label Dec 1, 2025
@MarkusNeusinger MarkusNeusinger enabled auto-merge (squash) December 1, 2025 21:47
Add basic area chart implementation for plotly library.

- Creates spec file: specs/area-basic.md
- Implements plotly version: plots/plotly/scatter/area-basic/default.py
- Includes input validation, type hints, Google-style docstring
- Uses go.Scatter with fill='tozeroy' for area fill
- Professional styling with subtle grid and clean layout
@MarkusNeusinger MarkusNeusinger merged commit c6ed6d6 into main Dec 1, 2025
6 checks passed
@MarkusNeusinger MarkusNeusinger deleted the auto/area-basic/plotly branch December 1, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-approved Quality OK, ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant