Skip to content

feat(plotnine): implement area-basic#114

Merged
MarkusNeusinger merged 1 commit intomainfrom
auto/area-basic/plotnine
Dec 1, 2025
Merged

feat(plotnine): implement area-basic#114
MarkusNeusinger merged 1 commit intomainfrom
auto/area-basic/plotnine

Conversation

@claude
Copy link
Copy Markdown
Contributor

@claude claude Bot commented Dec 1, 2025

Summary

Implements area-basic for plotnine library.

Parent Issue: #99
Sub-Issue: #105
Attempt: 1/3

Implementation

  • specs/area-basic.md - Specification for basic area chart
  • plots/plotnine/area/area-basic/default.py - plotnine implementation

Features

  • Uses geom_area() and geom_line() to create filled area charts with line overlay
  • Customizable fill color, transparency, and line styling
  • 16:9 aspect ratio (default 16x9 inches)
  • Subtle grid with alpha=0.3
  • Input validation with informative error messages
  • Google-style docstrings with type hints
  • Sorts data by x-axis to ensure proper area rendering

Quality Checklist

  • Axes labeled with column names or custom labels
  • Grid visible but subtle (alpha=0.3)
  • Area fill clearly visible with appropriate transparency
  • Line on top provides clear boundary
  • Type hints on all parameters and return type
  • Input validation for empty data and missing columns
  • Ruff lint and format checks pass
  • Implementation runs successfully and creates plot.png

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 1, 2025

✅ Plot Tests Passed

Created with Python 3.14

Compatibility: 3.11 3.12 3.13

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 1, 2025

The author of this PR, claude[bot], is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at support@codecov.io with any questions.

@claude claude Bot added the ai-approved Quality OK, ready for merge label Dec 1, 2025
@MarkusNeusinger MarkusNeusinger enabled auto-merge (squash) December 1, 2025 21:47
@MarkusNeusinger MarkusNeusinger force-pushed the auto/area-basic/plotnine branch 3 times, most recently from d5c4d7f to d3b7e29 Compare December 1, 2025 21:53
Add basic area chart implementation for plotnine library.

- Creates spec file: specs/area-basic.md
- Creates implementation: plots/plotnine/area/area-basic/default.py
- Features: filled area with line overlay, customizable colors and transparency
- Uses geom_area() and geom_line() from plotnine
- Includes input validation, type hints, and Google-style docstrings
@MarkusNeusinger MarkusNeusinger merged commit 2ce46bd into main Dec 1, 2025
7 checks passed
@MarkusNeusinger MarkusNeusinger deleted the auto/area-basic/plotnine branch December 1, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-approved Quality OK, ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant