update(area-basic): bokeh — comprehensive quality review

[MarkusNeusinger]

Summary

Updated bokeh implementation for area-basic.

Changes

• Added HoverTool with formatted date/visitor tooltips
• Added invisible scatter layer for precise hover targets
• Improved y-axis label with units "(count)"

Test Plan

• Preview images uploaded to GCS staging
• Implementation file passes ruff format/check
• Metadata YAML updated with current versions
• Automated review triggered

---

Generated with Claude Code /update command

[claude]

AI Review - Attempt 1/3

Image Description

The plot displays a basic area chart titled "area-basic · bokeh · pyplots.ai" showing daily website visitors over January 2024. The x-axis shows dates from Jan 01, 2024 to Feb 01, with major ticks at weekly intervals. The y-axis is labeled "Daily Visitors (count)" and ranges from 0 to approximately 7,000. The area below the line is filled with a semi-transparent blue (#306998, alpha 0.4), and a solid blue line (line_width=5) traces the top edge of the filled area. The data exhibits a clear weekly cyclical pattern with an overall upward trend, starting around 5,000 visitors and ending near 7,000. Dashed grid lines are visible at low opacity (alpha 0.3). The layout is well-balanced with the plot filling a large portion of the 4800×2700 canvas. All text is clearly legible with appropriately scaled font sizes (title 48pt, axis labels 36pt, tick labels 28pt). The toolbar is removed for a clean static export.

Quality Score: 92/100

Criteria Checklist

Visual Quality (40/40)

• VQ-01: Text Legibility (10/10) - Title 48pt, axis labels 36pt, tick labels 28pt — all well above minimums and perfectly readable
• VQ-02: No Overlap (8/8) - No overlapping text; date ticks well-spaced at weekly intervals
• VQ-03: Element Visibility (8/8) - Area fill clearly visible with good alpha, line_width=5 provides clear edge definition for 31 data points
• VQ-04: Color Accessibility (5/5) - Single blue color (#306998), no accessibility concerns
• VQ-05: Layout Balance (5/5) - Plot fills >50% of canvas, balanced margins with min_border adjustments
• VQ-06: Axis Labels (2/2) - "Date" and "Daily Visitors (count)" — descriptive with units
• VQ-07: Grid & Legend (2/2) - Subtle dashed grid at alpha 0.3, no legend needed for single series

Spec Compliance (25/25)

• SC-01: Plot Type (8/8) - Correct area chart with filled region below the line using varea
• SC-02: Data Mapping (5/5) - X=datetime (dates), Y=numeric (visitors) correctly assigned
• SC-03: Required Features (5/5) - Semi-transparent fill (alpha 0.4) ✓, gridlines ✓, clear axis labels with units ✓
• SC-04: Data Range (3/3) - Y-axis starts at 0, all data visible, full date range shown
• SC-05: Legend Accuracy (2/2) - No legend needed for single-series area chart
• SC-06: Title Format (2/2) - "area-basic · bokeh · pyplots.ai" matches required format

Data Quality (19/20)

• DQ-01: Feature Coverage (7/8) - Shows upward trend, weekly cyclical pattern, and noise; demonstrates magnitude and volume well, though could show more dramatic variation
• DQ-02: Realistic Context (7/7) - Daily website visitors over a month — matches spec's example application exactly
• DQ-03: Appropriate Scale (5/5) - 4,000–7,000 daily visitors is realistic for a mid-sized website

Code Quality (10/10)

• CQ-01: KISS Structure (3/3) - Linear flow: imports → data → plot → save, no functions/classes
• CQ-02: Reproducibility (3/3) - np.random.seed(42) set
• CQ-03: Clean Imports (2/2) - All imports used (numpy, pandas, bokeh.io, bokeh.models, bokeh.plotting)
• CQ-04: No Deprecated API (1/1) - All current Bokeh 3.x API
• CQ-05: Output Correct (1/1) - Saves as plot.png via export_png

Library Features (4/5)

• LF-01: Uses distinctive library features (4/5) - ColumnDataSource, varea, HoverTool with datetime formatter, invisible scatter for hover targets, dual HTML+PNG export

Strengths

• Excellent text scaling for 4800×2700 canvas with font sizes well above minimums
• Good use of Bokeh-specific features: ColumnDataSource, varea, HoverTool with vline mode, invisible scatter for hover targets
• Realistic data generation with trend + weekly seasonality + noise components
• Clean code structure following KISS principle with proper seed for reproducibility
• Semi-transparent fill at alpha 0.4 provides good readability while maintaining visual weight
• Y-axis properly starts at 0 to avoid misleading area representation
• Dual export (PNG + HTML) leverages Bokeh's interactive capabilities

Weaknesses

• Data could show more dramatic variation or events (e.g., a traffic spike or dip) to better demonstrate the area chart's ability to convey magnitude changes
• Font sizes exceed the bokeh.md library guide recommendations (48pt vs 28pt title, 36pt vs 22pt labels) — while readable, they are larger than the standard

Verdict: APPROVED

[Copilot]

Pull request overview

Updates the bokeh implementation for the area-basic plot, aiming to improve interactivity and labeling while updating the associated metadata.

Changes:

• Added a HoverTool with formatted date/visitor tooltips and an invisible scatter layer to improve hover precision.
• Updated the y-axis label to include units (“(count)”).
• Bumped recorded Python/Bokeh versions in bokeh.yaml and refreshed generation metadata.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
plots/area-basic/implementations/bokeh.py	Adds hover interactivity and adjusts labeling in the Bokeh area chart implementation.
plots/area-basic/metadata/bokeh.yaml	Updates implementation metadata (versions/timestamps) and quality score field.

[Copilot]

The header’s quality field is malformed (Quality: /100) and the header also switches to Updated: instead of the usual Created:. This likely breaks any tooling that parses the standard 4-line header (which expects a numeric score like 91/100). Please restore a valid quality value (or use the existing convention like pending) and keep the header format consistent with other plot implementations.

[Copilot]

The module docstring header format is inconsistent with the convention used elsewhere in the repo (e.g., most implementations start with """ pyplots.ai including a space after the opening quotes). Please keep the header formatting consistent to avoid noisy diffs and potential downstream parsing issues.

[Copilot]

quality_score was changed from a numeric value to null. Other plot metadata files use an integer quality score, and this plot’s implementation header also relies on having a real score. If the score is temporarily unknown, consider using the existing convention (e.g., keep the previous score until the automated review updates it, or use an agreed sentinel like pending if supported) rather than null to avoid breaking consumers that expect an integer.

[Copilot]

The updated timestamp format changed from the ...Z form used elsewhere in plot metadata to an offset form (...+00:00). Please keep the timestamp format consistent (typically RFC3339 with Z) so downstream tooling can parse it uniformly.