update(bar-basic): plotly — comprehensive quality review

[MarkusNeusinger]

Summary

Updated plotly implementation for bar-basic.

Changes

• Added tickprefix and tickformat for Y-axis dollar formatting
• Text labels now include $ prefix
• Font sizes rebalanced (40→28pt) for better proportions at scale_factor=3
• Unicode middot separator

Test Plan

• Preview images uploaded to GCS staging
• Implementation file passes ruff format/check
• Metadata YAML updated with current versions
• Automated review triggered

---

Generated with Claude Code /update command

[Copilot]

Pull request overview

This PR updates the plotly implementation for the bar-basic plot specification with formatting and styling improvements. The changes focus on better visual proportions through font size adjustments, improved Y-axis dollar formatting using tickprefix and tickformat, and the use of Unicode middot separator in the title.

Changes:

• Updated font sizes from 40pt→28pt (title), 32pt→22pt/18pt (axis labels/ticks) for better visual balance
• Added tickprefix: "$" and tickformat: ",.0f" to Y-axis for proper dollar formatting
• Modified text labels to include $ prefix in template
• Updated to Unicode middot (\u00b7) separator in title
• Bumped plotly version to 6.5.2 and Python to 3.14

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
plots/bar-basic/metadata/plotly.yaml	Updated metadata with newer versions (plotly 6.5.2, Python 3.14), changed quality_score to null, updated timestamps and generated_by field
plots/bar-basic/implementations/plotly.py	Refined font sizes for better proportions, added Y-axis dollar formatting properties, updated header docstring format and dates, adjusted margins

[Copilot]

The docstring opening should have a space after the triple quotes to match the established codebase convention. All other implementations in bar-basic (altair.py, bokeh.py, highcharts.py, letsplot.py, matplotlib.py, plotnine.py, pygal.py, seaborn.py) use """ pyplots.ai (with space), and this pattern is overwhelmingly dominant across the entire codebase. The current format """pyplots.ai (without space) is inconsistent with this convention.

Suggested change

	"""pyplots.ai
	""" pyplots.ai

[Copilot]

The quality score in the header docstring is incomplete, showing "/100" instead of an actual score value. This should be updated to show the actual quality score once the automated review is complete, or temporarily show a placeholder value like "pending" rather than a malformed score.

Suggested change

	Quality: /100 | Updated: 2026-02-14
	Quality: pending | Updated: 2026-02-14

[Copilot]

The quality_score field is set to null. Based on the PR description stating this is a comprehensive quality review with improvements, and the fact that the original had a quality_score of 100, this field should either retain a meaningful value or be updated after the automated review completes. Setting it to null may cause issues with systems expecting a numeric value.

Suggested change

	quality_score: null
	quality_score: 100

[claude]

AI Review - Attempt 1/3

Image Description

The plot displays a vertical bar chart with 8 product categories on the x-axis (Electronics, Clothing, Home & Garden, Sports, Books, Toys, Automotive, Health) sorted in descending order by sales value. All bars use a single dark blue color (#306998 — Python Blue). Each bar has a dollar-formatted value label positioned above it (ranging from $45,200 for Electronics down to $15,400 for Health). The y-axis shows "Sales ($)" with dollar-formatted tick labels from $0 to $45,000 and subtle gray gridlines. The x-axis is labeled "Product Category." The title "bar-basic · plotly · pyplots.ai" is centered at the top. The background is clean white (plotly_white template) with good spacing between bars.

Quality Score: 84/100

Criteria Checklist

Visual Quality (29/30)

• VQ-01: Text Legibility (8/8) — All font sizes explicitly set: title=28pt, axis labels=22pt, ticks=18pt, value labels=22pt. All perfectly readable.
• VQ-02: No Overlap (6/6) — No overlapping text elements. Categories well-spaced, value labels above bars don't collide.
• VQ-03: Element Visibility (6/6) — Bars well-sized with bargap=0.3, all clearly visible and proportioned.
• VQ-04: Color Accessibility (4/4) — Single Python Blue color, no colorblind concerns.
• VQ-05: Layout & Canvas (3/4) — Good layout with explicit margins, but some vertical wasted space above the tallest value label. Plot fills ~60% of canvas.
• VQ-06: Axis Labels & Title (2/2) — "Sales ($)" includes units, "Product Category" is descriptive.

Design Excellence (10/20)

• DE-01: Aesthetic Sophistication (4/8) — Well-configured plotly_white template with Python Blue. Clean but looks like a standard configured default, not FiveThirtyEight-level design. No typographic hierarchy beyond size differences.
• DE-02: Visual Refinement (4/6) — plotly_white removes background clutter, subtle gridlines via rgba(0,0,0,0.1), explicit margins. Visible refinement above pure defaults.
• DE-03: Data Storytelling (2/6) — Data is sorted descending which implies ranking, and value labels aid precise reading. However, there are no annotations, callouts, or narrative emphasis highlighting key insights (e.g., "Electronics leads by 17%").

Spec Compliance (15/15)

• SC-01: Plot Type (5/5) — Correct vertical bar chart.
• SC-02: Required Features (4/4) — Value labels on bars (spec recommends), consistent bar widths, adequate spacing, single color.
• SC-03: Data Mapping (3/3) — Categories on X, values on Y, correctly assigned.
• SC-04: Title & Legend (3/3) — Title format "bar-basic · plotly · pyplots.ai" correct. No legend needed for single-series.

Data Quality (14/15)

• DQ-01: Feature Coverage (5/6) — 8 categories with good value range ($15k–$45k). Sorted descending shows ranking well. Could highlight a specific bar per spec suggestion for more visual variety.
• DQ-02: Realistic Context (5/5) — Product sales by department is a real, neutral, comprehensible business scenario.
• DQ-03: Appropriate Scale (4/4) — Sales figures in $15k–$45k range are realistic for department-level retail data.

Code Quality (9/10)

• CQ-01: KISS Structure (3/3) — Linear flow: imports → data → figure → layout → save. No functions or classes.
• CQ-02: Reproducibility (2/2) — Deterministic hardcoded data, no random generation needed.
• CQ-03: Clean Imports (2/2) — Only plotly.graph_objects imported and used.
• CQ-04: Code Elegance (1/2) — Clean and readable, slightly verbose with large textfont size for labels. Minor.
• CQ-05: Output & API (1/1) — Saves plot.png at 1600×900 scale=3, plus HTML.

Library Mastery (7/10)

• LM-01: Idiomatic Usage (4/5) — Uses go.Figure() + go.Bar() correctly with plotly idioms (texttemplate, textposition, marker_color). Could use px.bar() for express-style, but graph_objects is valid.
• LM-02: Distinctive Features (3/5) — Uses Plotly-distinctive texttemplate format string, write_html for interactive output, plotly_white template. Distinctive but not extraordinary.

Strengths

• Excellent text legibility with all font sizes explicitly configured for 4800×2700 output
• Clean plotly_white template with subtle gridlines produces a professional, uncluttered look
• Data sorted in descending order aids readability and implies ranking narrative
• Dollar-formatted value labels above bars with texttemplate provide precise reading
• Realistic business scenario with plausible sales figures
• HTML export leverages Plotly's native interactivity strength

Weaknesses

• No data storytelling: add an annotation highlighting a key insight (e.g., top performer, gap between categories, or a threshold line)
• Aesthetic sophistication is "well-configured default" level — consider subtle enhancements like rounded bar corners, a gradient effect, or a more refined color treatment to elevate beyond standard template
• Could highlight one specific bar with a different color/opacity to draw attention, as the spec suggests

Verdict: REJECTED

[github-actions]

🔧 Repair Attempt 1/3

Applied fixes based on AI review feedback.

Status: Repair completed, re-triggering review...

---

🤖 impl-repair

[claude]

AI Review - Attempt 2/3

Image Description

The plot displays a vertical bar chart titled "bar-basic · plotly · pyplots.ai" centered at the top. Eight bars represent product sales by department, sorted in descending order from left to right: Electronics ($45,200), Clothing ($38,700), Home & Garden ($31,500), Sports ($27,800), Books ($24,300), Toys ($21,600), Automotive ($18,900), and Health ($15,400). Dollar-formatted value labels appear above each bar. The top-performing Electronics bar is rendered in a slightly darker navy blue (#1A4971) while the remaining bars use a medium blue (#306998). A "Top seller / 17% ahead of #2" annotation with an arrow points to the Electronics bar. A dotted horizontal reference line marks the average at $27,925 with a label on the far right. The background is white with very subtle horizontal gridlines. The x-axis is labeled "Product Category" and the y-axis "Sales ($)" with dollar-formatted tick marks. Overall layout is clean and well-proportioned.

Quality Score: 92/100

Criteria Checklist

Visual Quality (28/30)

• VQ-01: Text Legibility (8/8) — All font sizes explicitly set: title 28pt, axis labels 22pt, tick labels 18pt, bar text 20pt. All perfectly readable at 4800×2700.
• VQ-02: No Overlap (4/6) — The "Top seller" annotation box and the "$45,200" value label on the Electronics bar create visual clutter; the annotation arrow and value text compete for the same space.
• VQ-03: Element Visibility (6/6) — Bars are well-sized with appropriate bargap (0.3), all elements clearly visible.
• VQ-04: Color Accessibility (4/4) — Single-hue blue palette is inherently colorblind-safe. No red-green differentiation.
• VQ-05: Layout Balance (4/4) — Good canvas utilization with balanced margins (t=100, b=80, l=100, r=120). Plot fills appropriate portion of canvas.
• VQ-06: Axis Labels & Title (2/2) — "Product Category" and "Sales ($)" are descriptive with units.

Design Excellence (16/20)

• DE-01: Aesthetic Sophistication (6/8) — Custom color palette with intentional hierarchy (darker top performer), subtle bar outlines (rgba border), clean plotly_white template. Clearly above defaults, strong design. Not quite publication-pinnacle.
• DE-02: Visual Refinement (5/6) — Subtle gridlines (rgba 0.07), clean template, generous whitespace, polished margins. Minor: average line label pushed to far right edge.
• DE-03: Data Storytelling (5/6) — Annotation highlighting top seller with contextual insight ("17% ahead of Add Claude Code GitHub Workflow #2"), average reference line for context. Good narrative elements guiding the viewer.

Spec Compliance (15/15)

• SC-01: Plot Type (5/5) — Correct vertical bar chart.
• SC-02: Required Features (4/4) — Consistent bar widths, value labels above bars, single color with highlight for emphasis, adequate spacing between bars. All spec notes addressed.
• SC-03: Data Mapping (3/3) — Categories on x-axis, values on y-axis, correct mapping.
• SC-04: Title & Legend (3/3) — Title format "bar-basic · plotly · pyplots.ai" correct. No legend needed for single series (showlegend=False appropriate).

Data Quality (14/15)

• DQ-01: Feature Coverage (5/6) — 8 categories with clear variation in bar heights, sorted descending. Good range ($15K–$45K). Could show more extreme variation to better demonstrate the chart type's strengths.
• DQ-02: Realistic Context (5/5) — Product sales by department is a real, neutral business scenario.
• DQ-03: Appropriate Scale (4/4) — Sales figures $15K–$45K are realistic for department-level retail sales.

Code Quality (10/10)

• CQ-01: KISS Structure (3/3) — Clean flat structure: import → data → figure → annotation → layout → save.
• CQ-02: Reproducibility (2/2) — Deterministic hardcoded data, no randomness.
• CQ-03: Clean Imports (2/2) — Only plotly.graph_objects imported and used.
• CQ-04: Code Elegance (2/2) — Clean, well-organized, appropriate complexity.
• CQ-05: Output & API (1/1) — Saves as plot.png (1600×900, scale=3) and plot.html. No deprecated APIs.

Library Mastery (9/10)

• LM-01: Idiomatic Usage (5/5) — Expert use of graph_objects API: go.Bar, add_trace, update_layout, add_annotation, add_hline with annotation dict.
• LM-02: Distinctive Features (4/5) — Uses Plotly-specific features: hovertemplate with custom formatting, texttemplate for bar labels, add_hline with embedded annotation, dual output (PNG + HTML). These are clearly Plotly-distinctive.

Strengths

• Excellent data storytelling with the "Top seller" annotation providing contextual insight ("17% ahead of Add Claude Code GitHub Workflow #2") and the average reference line giving statistical context
• All font sizes explicitly set and well-calibrated for 4800×2700 output — perfectly readable
• Clean, idiomatic Plotly code with good use of library-specific features (hovertemplate, texttemplate, add_hline with annotation)
• Thoughtful visual hierarchy with subtle darker shade for top performer and minimal bar outlines
• Dual output (PNG + interactive HTML) leverages Plotly's interactive strengths

Weaknesses

• The "Top seller" annotation box overlaps/crowds the "$45,200" value label on the Electronics bar, creating visual clutter at the most important data point
• The color contrast between the highlighted top bar (#1A4971) and regular bars (#306998) is quite subtle — could be more visually distinct to reinforce the storytelling
• The average line annotation is pushed to the far right margin — could be positioned more prominently

Verdict: APPROVED