-
Notifications
You must be signed in to change notification settings - Fork 0
update(box-basic): letsplot — comprehensive quality review and improvement #4240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
79d96a7
update(box-basic): letsplot — comprehensive quality review and improv…
MarkusNeusinger a8fe0f7
chore(letsplot): update quality score 83 and review feedback for box-…
github-actions[bot] b3b4c29
fix(letsplot): address review feedback for box-basic
github-actions[bot] eddb982
chore(letsplot): update quality score 88 and review feedback for box-…
github-actions[bot] f7b0d0f
fix(letsplot): address review feedback for box-basic
github-actions[bot] bd91441
chore(letsplot): update quality score 90 and review feedback for box-…
github-actions[bot] d1d837f
Merge branch 'main' into implementation/box-basic/letsplot
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The DataFrame column names have been changed from "category" and "value" (as specified in specification.md) to "department" and "salary". While these names are more semantically meaningful for this specific use case, they deviate from the specification which defines the expected column names as "category" (string) and "value" (numeric). Consider whether this change should be reflected in the specification or if the implementation should adhere to the original column naming convention for consistency across all library implementations.