-
Notifications
You must be signed in to change notification settings - Fork 0
update(heatmap-basic): seaborn — comprehensive quality review #4253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
16eb277
update(heatmap-basic): seaborn — comprehensive quality review
MarkusNeusinger 9fedde2
chore(seaborn): update quality score 82 and review feedback for heatm…
github-actions[bot] b8d5302
fix(seaborn): address review feedback for heatmap-basic
github-actions[bot] 71000af
chore(seaborn): update quality score 92 and review feedback for heatm…
github-actions[bot] e21f243
Merge branch 'main' into implementation/heatmap-basic/seaborn
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
sns.clustermap()with hierarchical clustering is inappropriate for a "basic" heatmap specification. The specification for heatmap-basic asks for a simple matrix heatmap with logical ordering (alphabetical, by magnitude, or by similarity), not hierarchical clustering with dendrograms. Clustering functionality is the defining feature of the separateheatmap-clusteredspecification. This implementation should usesns.heatmap()instead, similar to the matplotlib implementation and the heatmap-correlation seaborn implementation. The current approach violates the principle that each specification should demonstrate a distinct plot type.