-
Notifications
You must be signed in to change notification settings - Fork 1
update(violin-basic): pygal — comprehensive quality review #4328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
776c392
update(violin-basic): pygal — comprehensive quality review
MarkusNeusinger 92d99c8
chore(pygal): update quality score 80 and review feedback for violin-…
github-actions[bot] ffb1109
fix(pygal): address review feedback for violin-basic
github-actions[bot] b021be6
chore(pygal): update quality score 81 and review feedback for violin-…
github-actions[bot] ec6e580
fix(pygal): address review feedback for violin-basic
github-actions[bot] c91f3d2
chore(pygal): update quality score 86 and review feedback for violin-…
github-actions[bot] 83b2e56
fix(pygal): address review feedback for violin-basic
github-actions[bot] e7682c1
chore(pygal): update quality score 85 and review feedback for violin-…
github-actions[bot] 3fa7944
Merge branch 'main' into implementation/violin-basic/pygal
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation header docstring no longer follows the repository’s standard 4-line format: the quality score is missing ("Quality: /100") and the date label changed to "Updated" instead of "Created". If any tooling parses these headers, this will break consistency with other violin-basic implementations (e.g., matplotlib.py uses "Quality: 92/100 | Created: ..."). Update the header to include an actual score and keep the conventional "Created" field (or whichever field the repo expects).