feat(pygal): implement area-basic#447
Merged
github-actions[bot] merged 2 commits intoplot/area-basicfrom Dec 7, 2025
Merged
Conversation
Contributor
This was referenced Dec 7, 2025
- Add reference to spec in data comment - Clarify that area chart uses Line with fill=True This change ONLY modifies the area/ implementation without deleting the duplicate in line/ to avoid CI issues with deleted files being tested.
b5582a2 to
880cf37
Compare
This was referenced Dec 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
area-basicfor pygal library.Parent Issue: #201
Sub-Issue: #427
Base Branch:
plot/area-basicAttempt: 4/3
Implementation
plots/pygal/area/area-basic/default.pyFeatures
fill=TrueFix for CI Issue
Previous attempts failed because:
plots/pygal/line/area-basic/default.pyThis attempt keeps only the correct
area/implementation in the diff without touching theline/duplicate. The duplicate should be cleaned up separately.