-
Notifications
You must be signed in to change notification settings - Fork 0
update(dendrogram-basic): pygal — comprehensive quality review #5206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
776ad46
update(dendrogram-basic): pygal — comprehensive quality review
MarkusNeusinger f5d744e
chore(pygal): update quality score 80 and review feedback for dendrog…
github-actions[bot] 0f771b0
fix(pygal): address review feedback for dendrogram-basic
github-actions[bot] 06637b1
chore(pygal): update quality score 79 and review feedback for dendrog…
github-actions[bot] 613175c
fix(pygal): address review feedback for dendrogram-basic
github-actions[bot] 1fee4a4
chore(pygal): update quality score 83 and review feedback for dendrog…
github-actions[bot] ade3289
fix(pygal): address review feedback for dendrogram-basic
github-actions[bot] 9c3f45a
chore(pygal): update quality score 82 and review feedback for dendrog…
github-actions[bot] 2a5cdb9
Merge branch 'main' into implementation/dendrogram-basic/pygal
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For
dendrogram-basic, other library implementations (and the existing metadata review text) use the title formatdendrogram-basic · {library} · pyplots.ai. This change adds a descriptive prefix, which makes the pygal version inconsistent within the same spec and may reduce spec compliance. Consider reverting to the standard title format for this plot.