-
Notifications
You must be signed in to change notification settings - Fork 0
update(chord-basic): plotly — comprehensive review #5213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
19bd632
update(chord-basic): plotly — comprehensive review
MarkusNeusinger cf7bd7c
chore(plotly): update quality score 76 and review feedback for chord-…
github-actions[bot] cab0a86
chore(plotly): update quality score 82 and review feedback for chord-…
github-actions[bot] 4ea4c9d
fix(plotly): address review feedback for chord-basic
github-actions[bot] a511a7a
chore(plotly): update quality score 88 and review feedback for chord-…
github-actions[bot] ea94aa1
fix(plotly): address review feedback for chord-basic
github-actions[bot] 9aa2af8
chore(plotly): update quality score 88 and review feedback for chord-…
github-actions[bot] 74bc9d3
Merge branch 'main' into implementation/chord-basic/plotly
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arc end positions are computed as
(total / total_flow) * (...), buttotal_flowis currentlyflow_matrix.sum()whiletotalcomes fromtotals = row_sum + col_sum. Sincetotals.sum()equals2 * flow_matrix.sum(), this scaling can make the arcs wrap more than once around the circle. Use a denominator consistent withtotals(e.g., settotal_flow = totals.sum()).