chore: implement audit quick wins and architectural doc updates by MarkusNeusinger · Pull Request #5506 · MarkusNeusinger/anyplot

MarkusNeusinger · 2026-04-27T14:10:03Z

This PR addresses several quick wins identified in the recent audit:

Fix legacy Python 2 except syntax in scripts and plots
Update Claude model name to valid Anthropic identifier
Sync architectural docs and agentic commands with modular router structure
Complete Web Vitals reporting (added FCP and TTFB)
Fix typo in agentic command filename (dokument.md -> document.md)
Use settings.claude_max_tokens in scripts to avoid hardcoded limits
Optimize model routing in plan.py (Phase 1 uses small model)

- Fix legacy Python 2 except syntax in scripts and plots - Update Claude model name to valid Anthropic identifier - Sync architectural docs and agentic commands with modular router structure - Complete Web Vitals reporting (added FCP and TTFB) - Fix typo in agentic command filename (dokument.md -> document.md) - Use settings.claude_max_tokens in scripts to avoid hardcoded limits - Optimize model routing in plan.py (Phase 1 uses small model)

Copilot

Pull request overview

This PR implements a set of audit-driven “quick wins” across scripts, agentic workflows/commands, frontend analytics, and documentation to align the repository with the current architecture and configuration patterns.

Changes:

Replace hardcoded Claude token limits and update the default Claude model identifier in configuration and scripts.
Fix legacy Python 2 except syntax and update agentic workflow/command docs (including adding document.md).
Expand Web Vitals reporting to include FCP and TTFB in Plausible events, and refresh architecture documentation.

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
scripts/upgrade_specs_ai.py	Uses `settings.claude_max_tokens` instead of a hardcoded max token count.
scripts/evaluate-plot.py	Uses `settings.claude_review_max_tokens` for review token limits.
plots/stereonet-equal-area/implementations/python/highcharts.py	Fixes Python 2-style `except` syntax to Python 3 tuple form.
docs/reference/repository.md	Updates API structure documentation to reflect modular routers and related modules.
core/config.py	Updates default `claude_model` to a valid Anthropic model identifier.
automation/scripts/sync_to_postgres.py	Fixes Python 2-style `except` syntax to Python 3 tuple form.
app/src/analytics/reportWebVitals.ts	Adds FCP and TTFB reporting to Plausible via `web-vitals`.
agentic/workflows/plan.py	Routes Phase 1 classification through the “small” model tier.
agentic/workflows/document.py	Points the document workflow at the corrected `agentic/commands/document.md` template.
agentic/commands/refactor.md	Updates documented repo structure to match current `core/` and modular API layout.
agentic/commands/feature.md	Updates documented repo structure to match current `core/` and modular API layout.
agentic/commands/chore.md	Updates documented repo structure to match current `core/` and modular API layout.
agentic/commands/bug.md	Updates documented repo structure to match current `core/` and modular API layout.
agentic/commands/document.md	Adds a new document-generation command template.
agentic/audits/latest.md	Replaces prior audit content with the latest audit snapshot.
agentic/audits/2026-04-27-all.md	Adds a dated audit snapshot file for 2026-04-27.

Copilot · 2026-04-27T14:14:04Z

+| 1 | SyntaxError: Python 2 style 'except' blocks | ruff | `automation/scripts/sync_to_postgres.py`, `plots/stereonet-equal-area/implementations/python/highcharts.py` | Change `except E1, E2:` to `except (E1, E2):` |
+| 2 | Critical Versioning Risk: Python 3.14 | manual | `pyproject.toml`, Dockerfiles, `.github/workflows/*.yml` | Downgrade to stable Python 3.12 or 3.13 |
+| 3 | Invalid Claude Model Name | manual | `core/config.py` | Change `claude-sonnet-4-6` to `claude-3-5-sonnet-20240620` |
+| 4 | Stale Agentic Commands / Docs | manual | `agentic/commands/*.md`, `docs/reference/*.md` | Update structure references to modular routers |


This audit snapshot is added in the same PR that implements several of the listed quick wins (Python-2 except syntax, invalid claude_model, dokument→document). As written, the report will be stale/inaccurate immediately after merge. Please regenerate the report post-fix, or annotate that these findings were addressed by this PR.

Copilot · 2026-04-27T14:14:04Z

@@ -43,6 +43,26 @@ export function reportWebVitals() {
        },
      });
    });
+
+    onFCP((metric) => {
+      window.plausible?.('FCP', {
+        props: {
+          ...getAnalyticsAmbientProps(),
+          value: String(Math.round(metric.value / 100) * 100),
+          rating: metric.rating,
+        },
+      });
+    });
+
+    onTTFB((metric) => {
+      window.plausible?.('TTFB', {


reportWebVitals() now destructures and calls onFCP/onTTFB, but the existing reportWebVitals.test.ts mock for web-vitals only provides onLCP/onCLS/onINP. This will cause tests (and any environment with a partial mock) to throw TypeError: onFCP is not a function. Update the web-vitals mock to include onFCP and onTTFB (or add a defensive check before calling them).

Copilot · 2026-04-27T14:14:05Z

+| 1 | SyntaxError: Python 2 style 'except' blocks | ruff | `automation/scripts/sync_to_postgres.py`, `plots/stereonet-equal-area/implementations/python/highcharts.py` | Change `except E1, E2:` to `except (E1, E2):` |
+| 2 | Critical Versioning Risk: Python 3.14 | manual | `pyproject.toml`, Dockerfiles, `.github/workflows/*.yml` | Downgrade to stable Python 3.12 or 3.13 |
+| 3 | Invalid Claude Model Name | manual | `core/config.py` | Change `claude-sonnet-4-6` to `claude-3-5-sonnet-20240620` |
+| 4 | Stale Agentic Commands / Docs | manual | `agentic/commands/*.md`, `docs/reference/*.md` | Update structure references to modular routers |


This audit report still lists issues that this PR appears to fix (e.g. Python-2 except syntax and invalid claude_model), so agentic/audits/latest.md will be inaccurate after merge. Consider regenerating the audit after applying the quick wins, or add a clear note that the report reflects the pre-fix state.

- Update web-vitals mock and tests to include FCP/TTFB - Annotate audit reports with post-fix status note

codecov · 2026-04-27T14:17:40Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copilot AI review requested due to automatic review settings April 27, 2026 14:10

Copilot started reviewing on behalf of MarkusNeusinger April 27, 2026 14:10 View session

Copilot AI reviewed Apr 27, 2026

View reviewed changes

chore: address copilot review feedback

cb170bf

- Update web-vitals mock and tests to include FCP/TTFB - Annotate audit reports with post-fix status note

MarkusNeusinger merged commit 065875a into main Apr 27, 2026
9 checks passed

MarkusNeusinger deleted the fix/audit-quick-wins branch April 27, 2026 14:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: implement audit quick wins and architectural doc updates#5506

chore: implement audit quick wins and architectural doc updates#5506
MarkusNeusinger merged 2 commits intomainfrom
fix/audit-quick-wins

MarkusNeusinger commented Apr 27, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 27, 2026

Uh oh!

Copilot AI Apr 27, 2026

Uh oh!

Copilot AI Apr 27, 2026

Uh oh!

codecov Bot commented Apr 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

MarkusNeusinger commented Apr 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Apr 27, 2026

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants